From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Boaz Harrosh <bharrosh@panasas.com>, linux-scsi@vger.kernel.org
Subject: Re: [RFC 1/2] scsi core: alloc_cmnd
Date: Tue, 23 Oct 2007 20:27:57 +0100 [thread overview]
Message-ID: <20071023192757.GA20713@infradead.org> (raw)
In-Reply-To: <20071023174804.GR27248@parisc-linux.org>
On Tue, Oct 23, 2007 at 11:48:04AM -0600, Matthew Wilcox wrote:
> On Tue, Oct 23, 2007 at 06:49:17PM +0200, Boaz Harrosh wrote:
> > You know Matthew when you first talked about this, I envisioned
> > something else.
>
> Right, so did I. Christoph felt that alloc_cmnd/destroy_cmnd a la the
> VFS layer's alloc_inode/destroy_inode was a better route. I didn't have
> a strong feeling, so I implemented that.
Yeah. Let me repeat my rationale for the method here: If we only
have a size member that means we can only allocate things using the
slab allocator. But there's a variety of drivers requiring other
allocations (e.g. pci_pool or the sym2 allocator) aswell, and having
the methods means we can always have a pre-constructed command for those
aswell, which makes these drivers deadlock-safe without much effort.
next prev parent reply other threads:[~2007-10-23 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 18:33 [RFC 1/2] scsi core: alloc_cmnd Matthew Wilcox
2007-10-23 16:49 ` Boaz Harrosh
2007-10-23 17:48 ` Matthew Wilcox
2007-10-23 18:46 ` Boaz Harrosh
2007-10-23 19:15 ` Matthew Wilcox
2007-10-23 19:49 ` Boaz Harrosh
2007-10-23 19:27 ` Christoph Hellwig [this message]
2007-10-23 20:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023192757.GA20713@infradead.org \
--to=hch@infradead.org \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox