From: Matthew Wilcox <matthew@wil.cx>
To: Arjan van de Ven <arjan@infradead.org>
Cc: FUJITA Tomonori <tomof@acm.org>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
fujita.tomonori@lab.ntt.co.jp
Subject: Re: Subject: [PATCH] tgt: use KMEM_CACHE
Date: Wed, 24 Oct 2007 21:25:24 -0600 [thread overview]
Message-ID: <20071025032524.GJ27248@parisc-linux.org> (raw)
In-Reply-To: <20071024195755.14e9c37f@laptopd505.fenrus.org>
On Wed, Oct 24, 2007 at 07:57:55PM -0700, Arjan van de Ven wrote:
> On Thu, 25 Oct 2007 01:21:29 +0900
> FUJITA Tomonori <tomof@acm.org> wrote:
> > - scsi_tgt_cmd_cache = kmem_cache_create("scsi_tgt_cmd",
> > - sizeof(struct
> > scsi_tgt_cmd),
> > - 0, 0, NULL);
> > + scsi_tgt_cmd_cache = KMEM_CACHE(scsi_tgt_cmd, 0);
>
> I have a question that is not described in your change log: why would
> you want to do this change? kmem_cache_create() is THE linux API to
> achieve this.... why would you not want to use it?? I'm sure you have a
> good reason for this change, but I can't figure out what that is from
> the changelog of your patch.
Looks like the preferred API was changed in May by clameter; see
commit 0a31bd5f2bbb6473ef9d24f0063ca91cfa678b64
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-25 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:21 Subject: [PATCH] tgt: use KMEM_CACHE FUJITA Tomonori
2007-10-25 2:57 ` Arjan van de Ven
2007-10-25 3:25 ` Matthew Wilcox [this message]
2007-10-25 6:33 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025032524.GJ27248@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=arjan@infradead.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).