RE: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

Yang, Bo
2007-11-09T20:44:30Z

James,

We are re-submitting those patches with the two patches (patch [2/8]--
"add module param fast_load" and patch [3/8] -- "add module param
max_sectors, cmd_per_lun" ) droped for now. Later on we may implement
the module params as suggested by the community members.

Regards.

Bo Yang

-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Wednesday, November 07, 2007 12:40 PM
To: Yang, Bo
Cc: Christoph Hellwig; linux-scsi@vger.kernel.org;
James.Bottomley@SteelEye.com; akpm@osdl.org;
linux-kernel@vger.kernel.org
Subject: Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

On Tue, Nov 06, 2007 at 12:04:31PM -0700, Yang, Bo wrote:
> I see that scsi_scan_host_selected is in scsi_priv.h and currently is
> not used by any other driver. The scsi_priv.h is not part of the
> include dir (/include/scsi). One of the major Linux distro's don't
> even include this file in /usr/src/kernels. Also it looks like at this

> time this function may not be available (not exported?) for driver
modules to use.
> Even if I include scsi_priv.h I get "unknown symbol" for this function

> while loading.

Yes, it would have to be exported and moved to a public header.

> May be in the long run we can solve all these issues to call
> scsi_scan_host_selected. However, the current implementation works
> fine and has been tested by LSI and others. This implementation
> doesn't break any protocol nor does it adversely affect any driver
functionality.

Your implementation adds state to scanning that could easily break and
makes the driver complex for things that don't belong into a driver, so
there's a clear NACK for this from me.