From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8 Date: Wed, 7 Nov 2007 17:33:07 +0000 Message-ID: <20071107173307.GB25560@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Salyzyn, Mark" Cc: Andreas Schwab , Stephen Rothwell , linux-scsi@vger.kernel.org, LKML List-Id: linux-scsi@vger.kernel.org On Wed, Nov 07, 2007 at 10:58:12AM -0500, Salyzyn, Mark wrote: > Good point, thanks. The intent of the management applications > utilization of this AIF report is to observe the LSB of the value of > integer value in BlinkLED. The actions of the cpu_to_le32 actually > breaks this and reports the wrong content in swapped architectures. > > This attached follow-up patch is against current scsi-misc-2.6 *after* > the application of the 'don't assign cpu_to_le32(constant) to u8' patch > submitted by Stephen Rothwell which has already been taken by the -mm > tree. Inspection of other areas of the aacraid driver came up blank for > similar style bugs. Did anyone run the driver through sparse to see if we have more issues like this?