From: Matthew Wilcox <matthew@wil.cx>
To: Jens Axboe <jens.axboe@oracle.com>,
linux-scsi@vger.kernel.org, andmike@us.ibm.com
Subject: Re: [PATCH] blk request timeout minor fixes...
Date: Sun, 2 Dec 2007 19:49:45 -0700 [thread overview]
Message-ID: <20071203024945.GO2584@parisc-linux.org> (raw)
In-Reply-To: <20071203015330.GA3485@us.ibm.com>
On Sun, Dec 02, 2007 at 05:53:30PM -0800, malahal@us.ibm.com wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 917fe86..e495d61 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -295,7 +295,8 @@ struct request {
> void *data;
> void *sense;
>
> - unsigned long timeout;
> + unsigned long deadline;
> + unsigned int timeout;
> struct list_head timeout_list;
> int retries;
Can I suggest running 'pahole' over this when compiled on 64-bit?
You've just introduced a 4-byte hole.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-12-03 2:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 6:54 [PATCH] gdth: scp timeout clean up malahal
2007-11-06 7:54 ` Boaz Harrosh
2007-11-06 16:18 ` malahal
2007-11-06 22:34 ` [PATCH] gdth: scp timeout clean up (try #2) malahal
2007-11-07 13:22 ` Jens Axboe
2007-11-14 2:39 ` malahal
2007-12-03 1:53 ` [PATCH] blk request timeout minor fixes malahal
2007-12-03 2:49 ` Matthew Wilcox [this message]
2007-12-03 23:47 ` malahal
2007-12-04 9:00 ` Jens Axboe
2007-12-05 20:05 ` malahal
2007-12-05 20:10 ` Jens Axboe
2007-12-05 20:40 ` malahal
2007-12-05 21:06 ` Another use for block-layer timeouts Matthew Wilcox
2007-11-07 17:35 ` [PATCH] gdth: scp timeout clean up (try #2) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203024945.GO2584@parisc-linux.org \
--to=matthew@wil.cx \
--cc=andmike@us.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).