From: Sam Ravnborg <sam@ravnborg.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m
Date: Fri, 7 Dec 2007 17:06:03 +0100 [thread overview]
Message-ID: <20071207160603.GB31641@uranus.ravnborg.org> (raw)
In-Reply-To: <47594C57.4070006@gmail.com>
On Fri, Dec 07, 2007 at 10:36:23PM +0900, Tejun Heo wrote:
> subdir-y|m isn't supposed to contain modules or built-in components.
> Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: James Bottomley <James.Bottomley@SteelEye.com>
Ack-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/scsi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index 2e6129f..72c8d2e 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -18,7 +18,7 @@ CFLAGS_aha152x.o = -DAHA152X_STAT -DAUTOCONF
> CFLAGS_gdth.o = # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS
> CFLAGS_seagate.o = -DARBITRATE -DPARITY -DSEAGATE_USE_ASM
>
> -subdir-$(CONFIG_PCMCIA) += pcmcia
> +obj-$(CONFIG_PCMCIA) += pcmcia/
>
> obj-$(CONFIG_SCSI) += scsi_mod.o
> obj-$(CONFIG_SCSI_TGT) += scsi_tgt.o
next prev parent reply other threads:[~2007-12-07 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 13:36 [PATCH] SCSI: make pcmcia directory use obj-y|m instead of subdir-y|m Tejun Heo
2007-12-07 16:06 ` Sam Ravnborg [this message]
2007-12-07 22:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207160603.GB31641@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=James.Bottomley@SteelEye.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox