From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH][SCSI] hptiop: add more adapter models and other fixes Date: Mon, 10 Dec 2007 09:50:30 -0700 Message-ID: <20071210165030.GB26334@parisc-linux.org> References: <200712101354.53575.linux@highpoint-tech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:59798 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbXLJQuc (ORCPT ); Mon, 10 Dec 2007 11:50:32 -0500 Content-Disposition: inline In-Reply-To: <200712101354.53575.linux@highpoint-tech.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: HighPoint Linux Team Cc: Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com On Mon, Dec 10, 2007 at 01:54:53PM +0800, HighPoint Linux Team wrote: > Most code changes were made to support adapters based on Marvell IOP, plus some > other fixes. > > - add more PCI device IDs > - support for adapters based on Marvell IOP Are you sure it's a good idea to do this? This patch is 1200 lines long ... the same size as the existing driver: $ wc drivers/scsi/hptiop.* 947 2273 24531 drivers/scsi/hptiop.c 256 612 6175 drivers/scsi/hptiop.h 1203 2885 30706 total That suggests to me there's not much commonality between the two drivers, and you'd be better off adding a second driver for the 4xxx cards. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."