From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: akpm@linux-foundation.org
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
bunk@kernel.org
Subject: Re: [patch 18/30] scsi/qla2xxx/: possible cleanups
Date: Fri, 14 Dec 2007 07:37:24 -0800 [thread overview]
Message-ID: <20071214153723.GC1823@plap3.qlogic.org> (raw)
In-Reply-To: <200712140014.lBE0ELSg026228@imap1.linux-foundation.org>
On Thu, 13 Dec 2007, akpm@linux-foundation.org wrote:
> From: Adrian Bunk <bunk@kernel.org>
>
> - make the following needlessly global code static:
> - qla_attr.c: qla24xx_vport_delete()
> - qla_attr.c: qla24xx_vport_disable()
> - qla_mid.c: qla24xx_allocate_vp_id()
> - qla_mid.c: qla24xx_find_vhost_by_name()
> - qla_mid.c: qla2x00_do_dpc_vp()
> - qla_os.c: struct qla2x00_driver_template
> - qla_os.c: qla2x00_stop_timer()
> - qla_os.c: qla2x00_mem_alloc()
> - qla_os.c: qla2x00_mem_free()
> - qla_sup.c: qla2x00_lock_nvram_access()
> - qla_sup.c: qla2x00_unlock_nvram_access()
> - qla_sup.c: qla2x00_get_nvram_word()
> - qla_sup.c: qla2x00_write_nvram_word()
> - #if 0 the following unused global functions:
> - qla_dbg.c: qla2x00_dump_pkt()
> - qla_mbx.c: qla2x00_system_error()
> - qla_mbx.c: qla2x00_get_serdes_params()
> - qla_mbx.c: qla2x00_get_idma_speed()
> - qla_mbx.c: qla24xx_get_vp_database()
> - qla_mbx.c: qla24xx_get_vp_entry()
> - qla_os.c: remove some unneeded function prototypes
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Andrew,
Could you drop this patch from your queue. I'll carry it in my tree
(along with additional code removals) for 2.6.25 submission.
Thanks,
Andrew Vasquez
next prev parent reply other threads:[~2007-12-14 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 0:14 [patch 18/30] scsi/qla2xxx/: possible cleanups akpm
2007-12-14 15:37 ` Andrew Vasquez [this message]
2007-12-14 17:55 ` Andrew Morton
2007-12-14 18:20 ` Andrew Vasquez
2007-12-21 10:46 ` Andrew Morton
2007-12-21 18:50 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214153723.GC1823@plap3.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox