[patch 18/30] scsi/qla2xxx/: possible cleanups

[patch 18/30] scsi/qla2xxx/: possible cleanups

[akpm]

From: Adrian Bunk <bunk@kernel.org>

- make the following needlessly global code static:
  - qla_attr.c: qla24xx_vport_delete()
  - qla_attr.c: qla24xx_vport_disable()
  - qla_mid.c: qla24xx_allocate_vp_id()
  - qla_mid.c: qla24xx_find_vhost_by_name()
  - qla_mid.c: qla2x00_do_dpc_vp()
  - qla_os.c: struct qla2x00_driver_template
  - qla_os.c: qla2x00_stop_timer()
  - qla_os.c: qla2x00_mem_alloc()
  - qla_os.c: qla2x00_mem_free()
  - qla_sup.c: qla2x00_lock_nvram_access()
  - qla_sup.c: qla2x00_unlock_nvram_access()
  - qla_sup.c: qla2x00_get_nvram_word()
  - qla_sup.c: qla2x00_write_nvram_word()
- #if 0 the following unused global functions:
  - qla_dbg.c: qla2x00_dump_pkt()
  - qla_mbx.c: qla2x00_system_error()
  - qla_mbx.c: qla2x00_get_serdes_params()
  - qla_mbx.c: qla2x00_get_idma_speed()
  - qla_mbx.c: qla24xx_get_vp_database()
  - qla_mbx.c: qla24xx_get_vp_entry()
- qla_os.c: remove some unneeded function prototypes

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/qla2xxx/qla_attr.c |    6 +++---
 drivers/scsi/qla2xxx/qla_dbg.c  |    2 ++
 drivers/scsi/qla2xxx/qla_gbl.h  |   25 -------------------------
 drivers/scsi/qla2xxx/qla_mbx.c  |   10 ++++++++++
 drivers/scsi/qla2xxx/qla_mid.c  |    6 +++---
 drivers/scsi/qla2xxx/qla_os.c   |   20 ++++++--------------
 drivers/scsi/qla2xxx/qla_sup.c  |    8 ++++----
 7 files changed, 28 insertions(+), 49 deletions(-)

diff -puN drivers/scsi/qla2xxx/qla_attr.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_attr.c
--- a/drivers/scsi/qla2xxx/qla_attr.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_attr.c
@@ -9,7 +9,7 @@
 #include <linux/kthread.h>
 #include <linux/vmalloc.h>
 
-int qla24xx_vport_disable(struct fc_vport *, bool);
+static int qla24xx_vport_disable(struct fc_vport *, bool);
 
 /* SYSFS attributes --------------------------------------------------------- */
 
@@ -1113,7 +1113,7 @@ vport_create_failed_2:
 	return FC_VPORT_FAILED;
 }
 
-int
+static int
 qla24xx_vport_delete(struct fc_vport *fc_vport)
 {
 	scsi_qla_host_t *ha = shost_priv(fc_vport->shost);
@@ -1146,7 +1146,7 @@ qla24xx_vport_delete(struct fc_vport *fc
 	return 0;
 }
 
-int
+static int
 qla24xx_vport_disable(struct fc_vport *fc_vport, bool disable)
 {
 	scsi_qla_host_t *vha = fc_vport->dd_data;
diff -puN drivers/scsi/qla2xxx/qla_dbg.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_dbg.c
--- a/drivers/scsi/qla2xxx/qla_dbg.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_dbg.c
@@ -1428,6 +1428,7 @@ qla2x00_print_scsi_cmd(struct scsi_cmnd 
 	printk("  sp flags=0x%x\n", sp->flags);
 }
 
+#if 0
 void
 qla2x00_dump_pkt(void *pkt)
 {
@@ -1442,6 +1443,7 @@ qla2x00_dump_pkt(void *pkt)
 	}
 	printk("\n");
 }
+#endif  /*  0  */
 
 #if defined(QL_DEBUG_ROUTINES)
 /*
diff -puN drivers/scsi/qla2xxx/qla_gbl.h~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_gbl.h
--- a/drivers/scsi/qla2xxx/qla_gbl.h~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_gbl.h
@@ -68,30 +68,20 @@ extern int num_hosts;
 /*
  * Global Functions in qla_mid.c source file.
  */
-extern struct scsi_host_template qla2x00_driver_template;
 extern struct scsi_host_template qla24xx_driver_template;
 extern struct scsi_transport_template *qla2xxx_transport_vport_template;
-extern uint8_t qla2x00_mem_alloc(scsi_qla_host_t *);
 extern void qla2x00_timer(scsi_qla_host_t *);
 extern void qla2x00_start_timer(scsi_qla_host_t *, void *, unsigned long);
-extern void qla2x00_stop_timer(scsi_qla_host_t *);
-extern uint32_t qla24xx_allocate_vp_id(scsi_qla_host_t *);
 extern void qla24xx_deallocate_vp_id(scsi_qla_host_t *);
 extern int qla24xx_disable_vp (scsi_qla_host_t *);
 extern int qla24xx_enable_vp (scsi_qla_host_t *);
-extern void qla2x00_mem_free(scsi_qla_host_t *);
 extern int qla24xx_control_vp(scsi_qla_host_t *, int );
 extern int qla24xx_modify_vp_config(scsi_qla_host_t *);
 extern int qla2x00_send_change_request(scsi_qla_host_t *, uint16_t, uint16_t);
 extern void qla2x00_vp_stop_timer(scsi_qla_host_t *);
 extern int qla24xx_configure_vhba (scsi_qla_host_t *);
-extern int qla24xx_get_vp_entry(scsi_qla_host_t *, uint16_t, int);
-extern int qla24xx_get_vp_database(scsi_qla_host_t *, uint16_t);
-extern int qla2x00_do_dpc_vp(scsi_qla_host_t *);
 extern void qla24xx_report_id_acquisition(scsi_qla_host_t *,
     struct vp_rpt_id_entry_24xx *);
-extern scsi_qla_host_t * qla24xx_find_vhost_by_name(scsi_qla_host_t *,
-    uint8_t *);
 extern void qla2x00_do_dpc_all_vps(scsi_qla_host_t *);
 extern int qla24xx_vport_create_req_sanity_check(struct fc_vport *);
 extern scsi_qla_host_t * qla24xx_create_vhost(struct fc_vport *);
@@ -113,7 +103,6 @@ extern void qla2xxx_wake_dpc(scsi_qla_ho
 extern void qla2x00_alert_all_vps(scsi_qla_host_t *, uint16_t *);
 extern void qla2x00_async_event(scsi_qla_host_t *, uint16_t *);
 extern void qla2x00_vp_abort_isp(scsi_qla_host_t *);
-extern int qla24xx_vport_delete(struct fc_vport *);
 
 /*
  * Global Function Prototypes in qla_iocb.c source file.
@@ -231,12 +220,6 @@ qla24xx_get_isp_stats(scsi_qla_host_t *,
 extern int qla24xx_abort_command(scsi_qla_host_t *, srb_t *);
 extern int qla24xx_abort_target(fc_port_t *);
 
-extern int qla2x00_system_error(scsi_qla_host_t *);
-
-extern int
-qla2x00_get_serdes_params(scsi_qla_host_t *, uint16_t *, uint16_t *,
-    uint16_t *);
-
 extern int
 qla2x00_set_serdes_params(scsi_qla_host_t *, uint16_t, uint16_t, uint16_t);
 
@@ -250,9 +233,6 @@ extern int
 qla2x00_read_sfp(scsi_qla_host_t *, dma_addr_t, uint16_t, uint16_t, uint16_t);
 
 extern int
-qla2x00_get_idma_speed(scsi_qla_host_t *, uint16_t, uint16_t *, uint16_t *);
-
-extern int
 qla2x00_set_idma_speed(scsi_qla_host_t *, uint16_t, uint16_t, uint16_t *);
 
 /*
@@ -270,11 +250,7 @@ extern void qla2x00_free_irqs(scsi_qla_h
 /*
  * Global Function Prototypes in qla_sup.c source file.
  */
-extern void qla2x00_lock_nvram_access(scsi_qla_host_t *);
-extern void qla2x00_unlock_nvram_access(scsi_qla_host_t *);
 extern void qla2x00_release_nvram_protection(scsi_qla_host_t *);
-extern uint16_t qla2x00_get_nvram_word(scsi_qla_host_t *, uint32_t);
-extern void qla2x00_write_nvram_word(scsi_qla_host_t *, uint32_t, uint16_t);
 extern uint32_t *qla24xx_read_flash_data(scsi_qla_host_t *, uint32_t *,
     uint32_t, uint32_t);
 extern uint8_t *qla2x00_read_nvram_data(scsi_qla_host_t *, uint8_t *, uint32_t,
@@ -321,7 +297,6 @@ extern void qla25xx_fw_dump(scsi_qla_hos
 extern void qla2x00_dump_regs(scsi_qla_host_t *);
 extern void qla2x00_dump_buffer(uint8_t *, uint32_t);
 extern void qla2x00_print_scsi_cmd(struct scsi_cmnd *);
-extern void qla2x00_dump_pkt(void *);
 
 /*
  * Global Function Prototypes in qla_gs.c source file.
diff -puN drivers/scsi/qla2xxx/qla_mbx.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_mbx.c
--- a/drivers/scsi/qla2xxx/qla_mbx.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_mbx.c
@@ -2331,6 +2331,8 @@ atarget_done:
 	return rval;
 }
 
+#if 0
+
 int
 qla2x00_system_error(scsi_qla_host_t *ha)
 {
@@ -2402,6 +2404,8 @@ qla2x00_get_serdes_params(scsi_qla_host_
 	return rval;
 }
 
+#endif  /*  0  */
+
 /**
  * qla2x00_set_serdes_params() -
  * @ha: HA context
@@ -2548,6 +2552,7 @@ qla2x00_read_sfp(scsi_qla_host_t *ha, dm
 	return rval;
 }
 
+#if 0
 int
 qla2x00_get_idma_speed(scsi_qla_host_t *ha, uint16_t loop_id,
     uint16_t *port_speed, uint16_t *mb)
@@ -2590,6 +2595,7 @@ qla2x00_get_idma_speed(scsi_qla_host_t *
 
 	return rval;
 }
+#endif  /*  0  */
 
 int
 qla2x00_set_idma_speed(scsi_qla_host_t *ha, uint16_t loop_id,
@@ -2634,6 +2640,8 @@ qla2x00_set_idma_speed(scsi_qla_host_t *
 	return rval;
 }
 
+#if 0
+
 /*
  * qla24xx_get_vp_database
  *	Get the VP's database for all configured ports.
@@ -2724,6 +2732,8 @@ qla24xx_get_vp_entry(scsi_qla_host_t *ha
 	return rval;
 }
 
+#endif  /*  0  */
+
 void
 qla24xx_report_id_acquisition(scsi_qla_host_t *ha,
 	struct vp_rpt_id_entry_24xx *rptid_entry)
diff -puN drivers/scsi/qla2xxx/qla_mid.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_mid.c
--- a/drivers/scsi/qla2xxx/qla_mid.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_mid.c
@@ -39,7 +39,7 @@ qla2x00_vp_stop_timer(scsi_qla_host_t *v
 	}
 }
 
-uint32_t
+static uint32_t
 qla24xx_allocate_vp_id(scsi_qla_host_t *vha)
 {
 	uint32_t vp_id;
@@ -77,7 +77,7 @@ qla24xx_deallocate_vp_id(scsi_qla_host_t
 	up(&ha->vport_sem);
 }
 
-scsi_qla_host_t *
+static scsi_qla_host_t *
 qla24xx_find_vhost_by_name(scsi_qla_host_t *ha, uint8_t *port_name)
 {
 	scsi_qla_host_t *vha;
@@ -265,7 +265,7 @@ qla2x00_vp_abort_isp(scsi_qla_host_t *vh
 	qla24xx_enable_vp(vha);
 }
 
-int
+static int
 qla2x00_do_dpc_vp(scsi_qla_host_t *vha)
 {
 	if (test_and_clear_bit(VP_IDX_ACQUIRED, &vha->vp_flags)) {
diff -puN drivers/scsi/qla2xxx/qla_os.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_os.c
--- a/drivers/scsi/qla2xxx/qla_os.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_os.c
@@ -111,7 +111,7 @@ static int qla2x00_device_reset(scsi_qla
 static int qla2x00_change_queue_depth(struct scsi_device *, int);
 static int qla2x00_change_queue_type(struct scsi_device *, int);
 
-struct scsi_host_template qla2x00_driver_template = {
+static struct scsi_host_template qla2x00_driver_template = {
 	.module			= THIS_MODULE,
 	.name			= QLA2XXX_DRIVER_NAME,
 	.queuecommand		= qla2x00_queuecommand,
@@ -179,13 +179,6 @@ struct scsi_transport_template *qla2xxx_
  * Timer routines
  */
 
-void qla2x00_timer(scsi_qla_host_t *);
-
-__inline__ void qla2x00_start_timer(scsi_qla_host_t *,
-    void *, unsigned long);
-static __inline__ void qla2x00_restart_timer(scsi_qla_host_t *, unsigned long);
-__inline__ void qla2x00_stop_timer(scsi_qla_host_t *);
-
 __inline__ void
 qla2x00_start_timer(scsi_qla_host_t *ha, void *func, unsigned long interval)
 {
@@ -203,7 +196,7 @@ qla2x00_restart_timer(scsi_qla_host_t *h
 	mod_timer(&ha->timer, jiffies + interval * HZ);
 }
 
-__inline__ void
+static __inline__ void
 qla2x00_stop_timer(scsi_qla_host_t *ha)
 {
 	del_timer_sync(&ha->timer);
@@ -214,12 +207,11 @@ static int qla2x00_do_dpc(void *data);
 
 static void qla2x00_rst_aen(scsi_qla_host_t *);
 
-uint8_t qla2x00_mem_alloc(scsi_qla_host_t *);
-void qla2x00_mem_free(scsi_qla_host_t *ha);
+static uint8_t qla2x00_mem_alloc(scsi_qla_host_t *);
+static void qla2x00_mem_free(scsi_qla_host_t *ha);
 static int qla2x00_allocate_sp_pool( scsi_qla_host_t *ha);
 static void qla2x00_free_sp_pool(scsi_qla_host_t *ha);
 static void qla2x00_sp_free_dma(scsi_qla_host_t *, srb_t *);
-void qla2x00_sp_compl(scsi_qla_host_t *ha, srb_t *);
 
 /* -------------------------------------------------------------------------- */
 
@@ -2016,7 +2008,7 @@ qla2x00_mark_all_devices_lost(scsi_qla_h
 *      0  = success.
 *      1  = failure.
 */
-uint8_t
+static uint8_t
 qla2x00_mem_alloc(scsi_qla_host_t *ha)
 {
 	char	name[16];
@@ -2213,7 +2205,7 @@ qla2x00_mem_alloc(scsi_qla_host_t *ha)
 * Input:
 *      ha = adapter block pointer.
 */
-void
+static void
 qla2x00_mem_free(scsi_qla_host_t *ha)
 {
 	struct list_head	*fcpl, *fcptemp;
diff -puN drivers/scsi/qla2xxx/qla_sup.c~scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_sup.c
--- a/drivers/scsi/qla2xxx/qla_sup.c~scsi-qla2xxx-possible-cleanups
+++ a/drivers/scsi/qla2xxx/qla_sup.c
@@ -22,7 +22,7 @@ static void qla2x00_nv_write(scsi_qla_ho
  * qla2x00_lock_nvram_access() -
  * @ha: HA context
  */
-void
+static void
 qla2x00_lock_nvram_access(scsi_qla_host_t *ha)
 {
 	uint16_t data;
@@ -55,7 +55,7 @@ qla2x00_lock_nvram_access(scsi_qla_host_
  * qla2x00_unlock_nvram_access() -
  * @ha: HA context
  */
-void
+static void
 qla2x00_unlock_nvram_access(scsi_qla_host_t *ha)
 {
 	struct device_reg_2xxx __iomem *reg = &ha->iobase->isp;
@@ -74,7 +74,7 @@ qla2x00_unlock_nvram_access(scsi_qla_hos
  *
  * Returns the word read from nvram @addr.
  */
-uint16_t
+static uint16_t
 qla2x00_get_nvram_word(scsi_qla_host_t *ha, uint32_t addr)
 {
 	uint16_t	data;
@@ -93,7 +93,7 @@ qla2x00_get_nvram_word(scsi_qla_host_t *
  * @addr: Address in NVRAM to write
  * @data: word to program
  */
-void
+static void
 qla2x00_write_nvram_word(scsi_qla_host_t *ha, uint32_t addr, uint16_t data)
 {
 	int count;
_

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

[Andrew Vasquez]

On Thu, 13 Dec 2007, akpm@linux-foundation.org wrote:

> From: Adrian Bunk <bunk@kernel.org>
> 
> - make the following needlessly global code static:
>   - qla_attr.c: qla24xx_vport_delete()
>   - qla_attr.c: qla24xx_vport_disable()
>   - qla_mid.c: qla24xx_allocate_vp_id()
>   - qla_mid.c: qla24xx_find_vhost_by_name()
>   - qla_mid.c: qla2x00_do_dpc_vp()
>   - qla_os.c: struct qla2x00_driver_template
>   - qla_os.c: qla2x00_stop_timer()
>   - qla_os.c: qla2x00_mem_alloc()
>   - qla_os.c: qla2x00_mem_free()
>   - qla_sup.c: qla2x00_lock_nvram_access()
>   - qla_sup.c: qla2x00_unlock_nvram_access()
>   - qla_sup.c: qla2x00_get_nvram_word()
>   - qla_sup.c: qla2x00_write_nvram_word()
> - #if 0 the following unused global functions:
>   - qla_dbg.c: qla2x00_dump_pkt()
>   - qla_mbx.c: qla2x00_system_error()
>   - qla_mbx.c: qla2x00_get_serdes_params()
>   - qla_mbx.c: qla2x00_get_idma_speed()
>   - qla_mbx.c: qla24xx_get_vp_database()
>   - qla_mbx.c: qla24xx_get_vp_entry()
> - qla_os.c: remove some unneeded function prototypes
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Andrew,

Could you drop this patch from your queue.  I'll carry it in my tree
(along with additional code removals) for 2.6.25 submission.

Thanks,
Andrew Vasquez

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

[Andrew Morton]

On Fri, 14 Dec 2007 07:37:24 -0800 Andrew Vasquez <andrew.vasquez@qlogic.com> wrote:

> On Thu, 13 Dec 2007, akpm@linux-foundation.org wrote:
> 
> > From: Adrian Bunk <bunk@kernel.org>
> > 
> > - make the following needlessly global code static:
> >   - qla_attr.c: qla24xx_vport_delete()
> >   - qla_attr.c: qla24xx_vport_disable()
> >   - qla_mid.c: qla24xx_allocate_vp_id()
> >   - qla_mid.c: qla24xx_find_vhost_by_name()
> >   - qla_mid.c: qla2x00_do_dpc_vp()
> >   - qla_os.c: struct qla2x00_driver_template
> >   - qla_os.c: qla2x00_stop_timer()
> >   - qla_os.c: qla2x00_mem_alloc()
> >   - qla_os.c: qla2x00_mem_free()
> >   - qla_sup.c: qla2x00_lock_nvram_access()
> >   - qla_sup.c: qla2x00_unlock_nvram_access()
> >   - qla_sup.c: qla2x00_get_nvram_word()
> >   - qla_sup.c: qla2x00_write_nvram_word()
> > - #if 0 the following unused global functions:
> >   - qla_dbg.c: qla2x00_dump_pkt()
> >   - qla_mbx.c: qla2x00_system_error()
> >   - qla_mbx.c: qla2x00_get_serdes_params()
> >   - qla_mbx.c: qla2x00_get_idma_speed()
> >   - qla_mbx.c: qla24xx_get_vp_database()
> >   - qla_mbx.c: qla24xx_get_vp_entry()
> > - qla_os.c: remove some unneeded function prototypes
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Andrew,
> 
> Could you drop this patch from your queue.  I'll carry it in my tree
> (along with additional code removals) for 2.6.25 submission.
> 

I'll normally carry patches until they turn up in a subsystem tree or
mainline and will drop them then.  To minimise potential of lossage..

Is your tree publically accessible?

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

[Andrew Vasquez]

On Fri, 14 Dec 2007, Andrew Morton wrote:

> > Could you drop this patch from your queue.  I'll carry it in my tree
> > (along with additional code removals) for 2.6.25 submission.
> > 
> 
> I'll normally carry patches until they turn up in a subsystem tree or
> mainline and will drop them then.  To minimise potential of lossage..
> 
> Is your tree publically accessible?

It is, though, not widely publicized:

	git://avgit01.qlogic.com/qla2xxx-upstream

The repo is torndown and rebased on frequent a basis, and is meant to
provide a snapshot of where qla2xxx is at any given time.  Currently
it's comprised of linux-2.6.git with scsi-misc-2.6.git merged and a
dozen or so patches queued for the next merge window (2.6.25).

As it stands now, qla2xxx updates are still submitted via patches to
linux-scsi, rather than asking for any type of 'merge' to
scsi-misc-2.6.git be performed.

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

[Andrew Morton]

On Fri, 14 Dec 2007 10:20:04 -0800 Andrew Vasquez <andrew.vasquez@qlogic.com> wrote:

> On Fri, 14 Dec 2007, Andrew Morton wrote:
> 
> > > Could you drop this patch from your queue.  I'll carry it in my tree
> > > (along with additional code removals) for 2.6.25 submission.
> > > 
> > 
> > I'll normally carry patches until they turn up in a subsystem tree or
> > mainline and will drop them then.  To minimise potential of lossage..
> > 
> > Is your tree publically accessible?
> 
> It is, though, not widely publicized:
> 
> 	git://avgit01.qlogic.com/qla2xxx-upstream
>
> The repo is torndown and rebased on frequent a basis, and is meant to
> provide a snapshot of where qla2xxx is at any given time.  Currently
> it's comprised of linux-2.6.git with scsi-misc-2.6.git merged and a
> dozen or so patches queued for the next merge window (2.6.25).

That should be OK.  Sometimes ugly things can happen if James syncs with
Linus and you don't: when I ask git to generate the james->you diff, it
will generate a patch which reverts the Linus changes which are in James's
tree but which aren't in yours.  I have an alternative pull-git-trees
script which tries to fix that but not very successfully.

But whatever, we'll see.

One slight problem though:

fatal: Unable to look up avgit01.qlogic.com (port 9418) (Name or service not known)

I think I might need to be akpm@qlogic.com to get at that?

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

[Andrew Vasquez]

On Fri, 21 Dec 2007, Andrew Morton wrote:
> On Fri, 14 Dec 2007 10:20:04 -0800 Andrew Vasquez <andrew.vasquez@qlogic.com> wrote:
> > It is, though, not widely publicized:
> > 
> > 	git://avgit01.qlogic.com/qla2xxx-upstream
> >
> > The repo is torndown and rebased on frequent a basis, and is meant to
> > provide a snapshot of where qla2xxx is at any given time.  Currently
> > it's comprised of linux-2.6.git with scsi-misc-2.6.git merged and a
> > dozen or so patches queued for the next merge window (2.6.25).
> 
> That should be OK.  Sometimes ugly things can happen if James syncs with
> Linus and you don't: when I ask git to generate the james->you diff, it
> will generate a patch which reverts the Linus changes which are in James's
> tree but which aren't in yours.  I have an alternative pull-git-trees
> script which tries to fix that but not very successfully.
> 
> But whatever, we'll see.
> 
> One slight problem though:
> 
> fatal: Unable to look up avgit01.qlogic.com (port 9418) (Name or service not known)
> 
> I think I might need to be akpm@qlogic.com to get at that?

Hmm, my mistake, turns out the external name is git.qlogic.com.  This
worked for me from an external line.

	$ git clone git://git.qlogic.com/qla2xxx-upstream

Thanks,
AV