Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

Andrew Vasquez
2007-12-14T15:37:27Z

On Thu, 13 Dec 2007, akpm@linux-foundation.org wrote:

> From: Adrian Bunk <bunk@kernel.org>
>
> - make the following needlessly global code static:
> - qla_attr.c: qla24xx_vport_delete()
> - qla_attr.c: qla24xx_vport_disable()
> - qla_mid.c: qla24xx_allocate_vp_id()
> - qla_mid.c: qla24xx_find_vhost_by_name()
> - qla_mid.c: qla2x00_do_dpc_vp()
> - qla_os.c: struct qla2x00_driver_template
> - qla_os.c: qla2x00_stop_timer()
> - qla_os.c: qla2x00_mem_alloc()
> - qla_os.c: qla2x00_mem_free()
> - qla_sup.c: qla2x00_lock_nvram_access()
> - qla_sup.c: qla2x00_unlock_nvram_access()
> - qla_sup.c: qla2x00_get_nvram_word()
> - qla_sup.c: qla2x00_write_nvram_word()
> - #if 0 the following unused global functions:
> - qla_dbg.c: qla2x00_dump_pkt()
> - qla_mbx.c: qla2x00_system_error()
> - qla_mbx.c: qla2x00_get_serdes_params()
> - qla_mbx.c: qla2x00_get_idma_speed()
> - qla_mbx.c: qla24xx_get_vp_database()
> - qla_mbx.c: qla24xx_get_vp_entry()
> - qla_os.c: remove some unneeded function prototypes
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Andrew,

Could you drop this patch from your queue. I'll carry it in my tree
(along with additional code removals) for 2.6.25 submission.

Thanks,
Andrew Vasquez