From mboxrd@z Thu Jan 1 00:00:00 1970 From: tsbogend@alpha.franken.de (Thomas Bogendoerfer) Subject: Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd Date: Fri, 21 Dec 2007 17:35:50 +0100 Message-ID: <20071221163550.GA14740@alpha.franken.de> References: <20071221023011.4C4BADDDFA@ozlabs.org> <20071221103326.7ce1bc4f@the-village.bc.nu> <20071221131640.GN29690@parisc-linux.org> <20071221133027.GA11495@alpha.franken.de> <20071221140024.GO29690@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from elvis.franken.de ([193.175.24.41]:35316 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbXLUQgE (ORCPT ); Fri, 21 Dec 2007 11:36:04 -0500 Content-Disposition: inline In-Reply-To: <20071221140024.GO29690@parisc-linux.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Alan Cox , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Andrew Morton , rdreier@cisco.com, linux-scsi@vger.kernel.org, rmk@arm.linux.org.uk, davem@davemloft.net, james.bottomley@steeleye.com, ralf@linux-mips.org On Fri, Dec 21, 2007 at 07:00:25AM -0700, Matthew Wilcox wrote: > On Fri, Dec 21, 2007 at 02:30:28PM +0100, Thomas Bogendoerfer wrote: > > there are SCSI host drivers, which also DMA to the sense buffer like > > sgiwd93.c for example. > > Yes ... and there are others which don't, for example qla2xxx and > sym53c8xx. well I don't care which way to go. I'd prefer a pointer to an allocated sense buffer, but maybe that's just me. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]