Re: [RFC] Implementation of SCSI dynamic power management

Alan Stern
2008-01-08T15:12:53Z

On Tue, 8 Jan 2008, Oliver Neukum wrote:

> Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern:
> >  /**
> > + *     autoresume - perform dynamic (runtime) host resume
> > + *     @shp: host to resume
> > + *
> > + *     Resume (return to an operational power level) the specified host.
> > + *     Return 0 if the resume was successful, otherwise a negative
> > + *     error code.
> > + *
> > + *     Locks: struct Scsi_Host::pm_mutex held throughout the call.
> > + *
> > + *     Calling context: process
> > + *
> > + *     Notes: If the host is not currently suspended, this method does
> > + *     need to do anything.
> > + *
> > + *     Optionally defined in: LLD
> > + **/
> > +    int autoresume(struct Scsi_Host *shp)
> > +
>
> This seems to be a bit misleading. It seems to me that you must cancel
> any outstanding request to autosuspend from other layers.

How about something more like this:

* Resume (return to an operational power level) the specified host,
* and prevent autosuspends from other software layers until the
* template autosuspend method has been called again.
* Return 0 if the resume was successful, otherwise a negative
* error code.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html