From: Pavel Machek <pavel@ucw.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [linux-pm] Re: [RFC] Implementation of SCSI dynamic power management
Date: Tue, 8 Jan 2008 21:24:30 +0000 [thread overview]
Message-ID: <20080108212430.GB5050@ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0801071632180.6739-100000@iolanthe.rowland.org>
> > > When all the devices under a host are suspended, the LLD is informed
> > > (via a new "autosuspend" method in the host template) so that it can
> >
> > That is most certainly a mistake.
>
> Why?
>
> > Is there a good reason to not modify
> > to extend suspend() to take an extra argument for the reason it is called?
>
> In fact suspend methods already do take an argument specifying the
> reason they were called. It wouldn't be hard to add a couple of extra
> PM_EVENT_* values for manual suspend and autosuspend. The problem is
> that resume methods don't take a corresponding argument.
Well, you could store the value in struct device or something.
There's other problem: if autosuspend is != NULL, you know device
supports autosuspend.
If you call existing suspend(PMSG_AUTOSUSPEND), and driver does not
support it, it will crash and burn.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-01-08 21:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 19:42 [RFC] Implementation of SCSI dynamic power management Alan Stern
2008-01-07 20:31 ` Oliver Neukum
2008-01-07 21:34 ` Alan Stern
2008-01-07 22:06 ` Oliver Neukum
2008-01-08 3:56 ` Alan Stern
2008-01-08 13:42 ` Oliver Neukum
2008-01-08 15:06 ` Alan Stern
2008-01-08 15:10 ` Oliver Neukum
2008-01-08 21:24 ` Pavel Machek [this message]
2008-01-09 15:25 ` [linux-pm] " Alan Stern
2008-01-08 14:12 ` Oliver Neukum
2008-01-08 15:12 ` Alan Stern
2008-01-08 15:18 ` Oliver Neukum
2008-01-08 18:06 ` Stefan Richter
2008-01-08 18:51 ` Alan Stern
2008-01-08 15:00 ` Oliver Neukum
2008-01-08 15:16 ` Alan Stern
2008-01-08 15:30 ` Oliver Neukum
2008-01-09 16:11 ` Oliver Neukum
2008-01-09 17:22 ` Alan Stern
2008-01-09 17:31 ` Oliver Neukum
2008-01-09 20:36 ` Alan Stern
2008-01-10 9:26 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108212430.GB5050@ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox