[PATCH] qla2xyz: fix section mismatch

[PATCH] qla2xyz: fix section mismatch

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix section mismatch:  qla2x00_remove_one() should not be __devexit.

WARNING: vmlinux.o(.text+0xb014f5): Section mismatch: reference to .exit.text: (between 'qla2xxx_pci_error_detected' and 'qla2xxx_pci_mmio_enabled')

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/qla2xxx/qla_os.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.24-rc7-git1.orig/drivers/scsi/qla2xxx/qla_os.c
+++ linux-2.6.24-rc7-git1/drivers/scsi/qla2xxx/qla_os.c
@@ -1831,7 +1831,7 @@ probe_out:
 	return ret;
 }
 
-static void __devexit
+static void
 qla2x00_remove_one(struct pci_dev *pdev)
 {
 	scsi_qla_host_t *ha;
@@ -2965,7 +2965,7 @@ static struct pci_driver qla2xxx_pci_dri
 	},
 	.id_table	= qla2xxx_pci_tbl,
 	.probe		= qla2x00_probe_one,
-	.remove		= __devexit_p(qla2x00_remove_one),
+	.remove		= qla2x00_remove_one,
 	.err_handler	= &qla2xxx_err_handler,
 };
 

Re: [PATCH] qla2xyz: fix section mismatch

[Andrew Vasquez]

On Thu, 10 Jan 2008, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix section mismatch:  qla2x00_remove_one() should not be __devexit.
> 
> WARNING: vmlinux.o(.text+0xb014f5): Section mismatch: reference to .exit.text: (between 'qla2xxx_pci_error_detected' and 'qla2xxx_pci_mmio_enabled')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Adriann B. posted this fix already:

	http://article.gmane.org/gmane.linux.scsi/36387

I was expecting it to be carried in the -mm tree since it was acked:

	http://article.gmane.org/gmane.linux.scsi/36516

I can add it to the patch queue if necessary.

Re: [PATCH] qla2xyz: fix section mismatch

[Sam Ravnborg]

On Thu, Jan 10, 2008 at 02:33:09PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix section mismatch:  qla2x00_remove_one() should not be __devexit.
> 
> WARNING: vmlinux.o(.text+0xb014f5): Section mismatch: reference to .exit.text: (between 'qla2xxx_pci_error_detected' and 'qla2xxx_pci_mmio_enabled')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

This could oops under the wrong conditions.

	Sam