From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl Date: Thu, 10 Jan 2008 20:38:39 +0100 Message-ID: <20080110193839.GA2120@one.firstfloor.org> References: <20080110180529.GA32640@skl-net.de> <1199991298.3141.75.camel@localhost.localdomain> <20080110185944.GA1690@one.firstfloor.org> <1199991828.3141.82.camel@localhost.localdomain> <20080110193227.GH747@one.firstfloor.org> <20080110193321.GH18741@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from one.firstfloor.org ([213.235.205.2]:59709 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753978AbYAJTgD (ORCPT ); Thu, 10 Jan 2008 14:36:03 -0500 Content-Disposition: inline In-Reply-To: <20080110193321.GH18741@parisc-linux.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Andi Kleen , James Bottomley , Andre Noll , linux-scsi , linux-kernel , kernel-janitors@vger.kernel.org, Richard Knutsson > If your goal is to get rid of the BKL everywhere, sure. It's not clear > to me this is the most productive way of spending our time though. I believe eventually eliminating ->ioctl (as opposed to ->unlocked_ioctl) would be a productive thing to do. Still having implicit BKL semantics in such an important interface is just wrong. -Andi