From: Matthew Wilcox <matthew@wil.cx>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sym53_8xx_2: fixes two bugs related to chip reset
Date: Fri, 11 Jan 2008 13:52:29 -0700 [thread overview]
Message-ID: <20080111205229.GQ18741@parisc-linux.org> (raw)
In-Reply-To: <20080111215046.6c4a3c80.krzysztof.h1@poczta.fm>
On Fri, Jan 11, 2008 at 09:50:46PM +0100, Krzysztof Helt wrote:
> + BUG_ON(!sym_data->io_reset);
> + sym_data->io_reset = &eh_done;
Isn't that BUG_ON still the wrong sense?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-01-11 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 22:59 [PATCH] sym53_8xx_2: fixes two bugs related to chip reset Krzysztof Helt
2008-01-09 23:51 ` James Bottomley
2008-01-10 22:31 ` Krzysztof Helt
2008-01-10 22:47 ` James Bottomley
2008-01-11 20:50 ` Krzysztof Helt
2008-01-11 20:52 ` Matthew Wilcox [this message]
2008-01-12 4:11 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111205229.GQ18741@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox