* [PATCH] libsas: fix sense_buffer overrun
@ 2008-01-12 17:20 FUJITA Tomonori
2008-01-14 19:29 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: FUJITA Tomonori @ 2008-01-12 17:20 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, fujita.tomonori
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
drivers/scsi/libsas/sas_scsi_host.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index b784089..828fed1 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
break;
case SAM_CHECK_COND:
memcpy(sc->sense_buffer, ts->buf,
- max(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
+ min(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
stat = SAM_CHECK_COND;
break;
default:
--
1.5.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libsas: fix sense_buffer overrun
2008-01-12 17:20 [PATCH] libsas: fix sense_buffer overrun FUJITA Tomonori
@ 2008-01-14 19:29 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2008-01-14 19:29 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: James.Bottomley, linux-scsi, fujita.tomonori
Looks sane to me;
Acked-by: Darrick J. Wong <djwong@us.ibm.com>
--D
On Sun, Jan 13, 2008 at 02:20:18AM +0900, FUJITA Tomonori wrote:
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> drivers/scsi/libsas/sas_scsi_host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index b784089..828fed1 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
> break;
> case SAM_CHECK_COND:
> memcpy(sc->sense_buffer, ts->buf,
> - max(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
> + min(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
> stat = SAM_CHECK_COND;
> break;
> default:
> --
> 1.5.3.4
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-14 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-12 17:20 [PATCH] libsas: fix sense_buffer overrun FUJITA Tomonori
2008-01-14 19:29 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).