linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	fischer@norbit.de, Andy Whitcroft <apw@shadowen.org>,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Samuel Ortiz <samuel@sortiz.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Tejun Heo <htejun@gmail.com>
Subject: Re: 2.6.24-rc8-mm1 Build Failure on scsi driver
Date: Thu, 17 Jan 2008 23:27:27 -0800	[thread overview]
Message-ID: <20080117232727.7ef194af.akpm@linux-foundation.org> (raw)
In-Reply-To: <47904927.1040000@linux.vnet.ibm.com>

On Fri, 18 Jan 2008 12:07:27 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:

> Hi Andrew,
> 
> Patch from Tejun Heo fixes the aha152x.c build failure, and following second part
> of the build failure, is still occurring.
> 
> drivers/scsi/fdomain.o:(.data+0x0): multiple definition of `fdomain_driver_template'
> drivers/scsi/pcmcia/built-in.o:(.data+0x5a0): first defined here
> drivers/scsi/fdomain.o: In function `fdomain_16x0_bus_reset':
> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: multiple definition of `fdomain_16x0_bus_reset'
> drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: first defined here
> drivers/scsi/fdomain.o: In function `__fdomain_16x0_detect':
> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: multiple definition of `__fdomain_16x0_detect'
> drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: first defined here
> ld: Warning: size of symbol `__fdomain_16x0_detect' changed from 1206 in drivers/scsi/pcmcia/built-in.o to 1700 in drivers/scsi/fdomain.o
> drivers/scsi/fdomain.o: In function `fdomain_setup':
> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: multiple definition of `fdomain_setup'
> drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: first defined here

Tejun has more fixing to do, I suspect ;)

I assume a basic allyesconfig will weed out most remaining problems of this
sort.  Problem is, it needs to be done for all architectures (and even that
might not suffice).  So old-fashioned code inspection is also needed.

      parent reply	other threads:[~2008-01-18  7:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080117023514.9df393cf.akpm@linux-foundation.org>
2008-01-17 16:15 ` 2.6.24-rc8-mm1 Build Failure on scsi driver Kamalesh Babulal
2008-01-17 19:11   ` Andrew Morton
2008-01-18  0:53     ` [PATCH] aha152x: fix isa/pcmcia compile problem Tejun Heo
2008-01-18  6:29       ` Kamalesh Babulal
2008-01-18  6:37     ` 2.6.24-rc8-mm1 Build Failure on scsi driver Kamalesh Babulal
2008-01-18  7:20       ` [PATCH] SCSI: fix isa/pcmcia compile problem Tejun Heo
2008-01-18  7:30         ` Kamalesh Babulal
2008-01-18 14:58         ` James Bottomley
2008-01-18 23:27           ` Tejun Heo
2008-01-18 23:28             ` Tejun Heo
2008-01-18 23:32             ` James Bottomley
2008-01-18 23:46               ` Tejun Heo
2008-01-18 23:47               ` James Bottomley
2008-01-18 23:54                 ` Tejun Heo
2008-01-21  9:56         ` Christoph Hellwig
2008-01-21 14:59           ` James Bottomley
2008-01-18  7:27       ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117232727.7ef194af.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=apw@shadowen.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=fischer@norbit.de \
    --cc=htejun@gmail.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).