* [2.6 patch] make __iscsi_complete_pdu() static
@ 2008-01-28 22:11 Adrian Bunk
[not found] ` <20080128221127.GX8767-8VHLPQtsompjxMay5xEomg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-01-28 22:11 UTC (permalink / raw)
To: Olaf Kirch, Mike Christie, James Bottomley
Cc: open-iscsi, linux-scsi, linux-kernel
__iscsi_complete_pdu() can now become static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/scsi/libiscsi.c | 5 ++---
include/scsi/libiscsi.h | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)
4d4f211556f92590bfc32a243f562853c499b314
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 553168a..e794262 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -541,8 +541,8 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
* queuecommand or send generic. session lock must be held and verify
* itt must have been called.
*/
-int __iscsi_complete_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
- char *data, int datalen)
+static int __iscsi_complete_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
+ char *data, int datalen)
{
struct iscsi_session *session = conn->session;
int opcode = hdr->opcode & ISCSI_OPCODE_MASK, rc = 0;
@@ -672,7 +672,6 @@ int __iscsi_complete_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
return rc;
}
-EXPORT_SYMBOL_GPL(__iscsi_complete_pdu);
int iscsi_complete_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
char *data, int datalen)
diff --git a/include/scsi/libiscsi.h b/include/scsi/libiscsi.h
index 889f51f..71eda24 100644
--- a/include/scsi/libiscsi.h
+++ b/include/scsi/libiscsi.h
@@ -349,8 +349,6 @@ extern int iscsi_conn_send_pdu(struct iscsi_cls_conn *, struct iscsi_hdr *,
char *, uint32_t);
extern int iscsi_complete_pdu(struct iscsi_conn *, struct iscsi_hdr *,
char *, int);
-extern int __iscsi_complete_pdu(struct iscsi_conn *, struct iscsi_hdr *,
- char *, int);
extern int iscsi_verify_itt(struct iscsi_conn *, struct iscsi_hdr *,
uint32_t *);
extern void iscsi_requeue_ctask(struct iscsi_cmd_task *ctask);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] make __iscsi_complete_pdu() static
[not found] ` <20080128221127.GX8767-8VHLPQtsompjxMay5xEomg@public.gmane.org>
@ 2008-01-31 20:05 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2008-01-31 20:05 UTC (permalink / raw)
To: Adrian Bunk
Cc: Olaf Kirch, James Bottomley, open-iscsi-/JYPxA39Uh5TLH3MbocFFw,
linux-scsi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Adrian Bunk wrote:
> __iscsi_complete_pdu() can now become static.
>
> Signed-off-by: Adrian Bunk <bunk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
Looks good. Thanks.
Acked-by: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-31 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-28 22:11 [2.6 patch] make __iscsi_complete_pdu() static Adrian Bunk
[not found] ` <20080128221127.GX8767-8VHLPQtsompjxMay5xEomg@public.gmane.org>
2008-01-31 20:05 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).