* Re: [BUG] 2.6.24-git usb reset problems [not found] <20080128204935.GI15220@kernel.dk> @ 2008-01-28 21:21 ` Greg KH 2008-01-29 7:48 ` Jens Axboe 2008-01-29 12:15 ` Boaz Harrosh 0 siblings, 2 replies; 44+ messages in thread From: Greg KH @ 2008-01-28 21:21 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel, linux-usb, linux-scsi On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: > Hi, > > Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and > connecting my cf usb storage device yields and endless stream of: > > Initializing USB Mass Storage driver... > scsi6 : SCSI emulation for USB Mass Storage devices > usb-storage: device found at 2 > usb-storage: waiting for device to settle before scanning > usbcore: registered new interface driver usb-storage > USB Mass Storage support registered. > scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > ANSI: 0 > sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > sd 6:0:0:0: [sdb] Write Protect is off > sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > sd 6:0:0:0: [sdb] Assuming drive cache: write through > sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > sd 6:0:0:0: [sdb] Write Protect is off > sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > sd 6:0:0:0: [sdb] Assuming drive cache: write through > sdb: sdb1 > sd 6:0:0:0: [sdb] Attached SCSI removable disk > sd 6:0:0:0: Attached scsi generic sg1 type 0 > scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > ANSI: 0 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > [...] > > until I disconnect it. The device doesn't work. Worked fine in 2.6.24. > I'm attaching boot messages and my .config. That's a bit wierd, as we haven't added any USB patches to the -git tree yet after 2.6.24 :) Could this be caused by some scsi changes perhaps? thanks, greg k-h ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-28 21:21 ` [BUG] 2.6.24-git usb reset problems Greg KH @ 2008-01-29 7:48 ` Jens Axboe 2008-01-29 12:15 ` Boaz Harrosh 1 sibling, 0 replies; 44+ messages in thread From: Jens Axboe @ 2008-01-29 7:48 UTC (permalink / raw) To: Greg KH; +Cc: linux-kernel, linux-usb, linux-scsi On Mon, Jan 28 2008, Greg KH wrote: > On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: > > Hi, > > > > Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and > > connecting my cf usb storage device yields and endless stream of: > > > > Initializing USB Mass Storage driver... > > scsi6 : SCSI emulation for USB Mass Storage devices > > usb-storage: device found at 2 > > usb-storage: waiting for device to settle before scanning > > usbcore: registered new interface driver usb-storage > > USB Mass Storage support registered. > > scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > > ANSI: 0 > > sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > > sd 6:0:0:0: [sdb] Write Protect is off > > sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > > sd 6:0:0:0: [sdb] Assuming drive cache: write through > > sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > > sd 6:0:0:0: [sdb] Write Protect is off > > sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > > sd 6:0:0:0: [sdb] Assuming drive cache: write through > > sdb: sdb1 > > sd 6:0:0:0: [sdb] Attached SCSI removable disk > > sd 6:0:0:0: Attached scsi generic sg1 type 0 > > scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > > ANSI: 0 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > [...] > > > > until I disconnect it. The device doesn't work. Worked fine in 2.6.24. > > I'm attaching boot messages and my .config. > > That's a bit wierd, as we haven't added any USB patches to the -git tree > yet after 2.6.24 :) > > Could this be caused by some scsi changes perhaps? Heh, I guess it could! I'll double check, I reproduced it with two distinct boots before posting. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-28 21:21 ` [BUG] 2.6.24-git usb reset problems Greg KH 2008-01-29 7:48 ` Jens Axboe @ 2008-01-29 12:15 ` Boaz Harrosh 2008-01-29 15:00 ` Matthew Dharm [not found] ` <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 1 sibling, 2 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 12:15 UTC (permalink / raw) To: Greg KH, Jens Axboe, Matthew Dharm; +Cc: linux-kernel, linux-usb, linux-scsi Greg KH wrote: > On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: >> Hi, >> >> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and >> connecting my cf usb storage device yields and endless stream of: >> >> Initializing USB Mass Storage driver... >> scsi6 : SCSI emulation for USB Mass Storage devices >> usb-storage: device found at 2 >> usb-storage: waiting for device to settle before scanning >> usbcore: registered new interface driver usb-storage >> USB Mass Storage support registered. >> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >> ANSI: 0 >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >> sd 6:0:0:0: [sdb] Write Protect is off >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >> sd 6:0:0:0: [sdb] Assuming drive cache: write through >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >> sd 6:0:0:0: [sdb] Write Protect is off >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >> sd 6:0:0:0: [sdb] Assuming drive cache: write through >> sdb: sdb1 >> sd 6:0:0:0: [sdb] Attached SCSI removable disk >> sd 6:0:0:0: Attached scsi generic sg1 type 0 >> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >> ANSI: 0 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >> [...] >> >> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. >> I'm attaching boot messages and my .config. > > That's a bit wierd, as we haven't added any USB patches to the -git tree > yet after 2.6.24 :) > > Could this be caused by some scsi changes perhaps? > > thanks, > > greg k-h > - Yes it is ;) Jens could you test the patch below? if it works I'll submit a proper patch. Please forgive me for the bug. Matthew, Greg, Is there a way to extract from messages the usb storage transport used? I'm guessing it is freecom do to the fact that I find a bug there. Thanks Boaz --- drivers/usb/storage/freecom.c | 4 ++-- drivers/usb/storage/transport.c | 12 +++++++++--- drivers/usb/storage/transport.h | 3 ++- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c index f5a4e8d..8d77603 100644 --- a/drivers/usb/storage/freecom.c +++ b/drivers/usb/storage/freecom.c @@ -132,7 +132,7 @@ freecom_readdata (struct scsi_cmnd *srb, struct us_data *us, /* Now transfer all of our blocks. */ US_DEBUGP("Start of read\n"); - result = usb_stor_bulk_srb(us, ipipe, srb); + result = usb_stor_bulk_srb_length(us, ipipe, srb, count); US_DEBUGP("freecom_readdata done!\n"); if (result > USB_STOR_XFER_SHORT) @@ -165,7 +165,7 @@ freecom_writedata (struct scsi_cmnd *srb, struct us_data *us, /* Now transfer all of our blocks. */ US_DEBUGP("Start of write\n"); - result = usb_stor_bulk_srb(us, opipe, srb); + result = usb_stor_bulk_srb_length(us, opipe, srb, count); US_DEBUGP("freecom_writedata done!\n"); if (result > USB_STOR_XFER_SHORT) diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c index d9f4912..5072235 100644 --- a/drivers/usb/storage/transport.c +++ b/drivers/usb/storage/transport.c @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, * Common used function. Transfer a complete command * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid */ -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, - struct scsi_cmnd* srb) +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, + struct scsi_cmnd* srb, unsigned length) { unsigned int partial; int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), - scsi_sg_count(srb), scsi_bufflen(srb), + scsi_sg_count(srb), length, &partial); scsi_set_resid(srb, scsi_bufflen(srb) - partial); return result; } +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, + struct scsi_cmnd* srb) +{ + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); +} + /* * Transfer an entire SCSI command's worth of data payload over the bulk * pipe. diff --git a/drivers/usb/storage/transport.h b/drivers/usb/storage/transport.h index ada7c2f..03e395d 100644 --- a/drivers/usb/storage/transport.h +++ b/drivers/usb/storage/transport.h @@ -139,8 +139,9 @@ extern int usb_stor_bulk_transfer_buf(struct us_data *us, unsigned int pipe, void *buf, unsigned int length, unsigned int *act_len); extern int usb_stor_bulk_transfer_sg(struct us_data *us, unsigned int pipe, void *buf, unsigned int length, int use_sg, int *residual); +extern int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, + struct scsi_cmnd* srb, unsigned length); extern int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, struct scsi_cmnd* srb); - extern int usb_stor_port_reset(struct us_data *us); #endif ^ permalink raw reply related [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 12:15 ` Boaz Harrosh @ 2008-01-29 15:00 ` Matthew Dharm [not found] ` <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 1 sibling, 0 replies; 44+ messages in thread From: Matthew Dharm @ 2008-01-29 15:00 UTC (permalink / raw) To: Boaz Harrosh; +Cc: Greg KH, Jens Axboe, linux-kernel, linux-usb, linux-scsi [-- Attachment #1: Type: text/plain, Size: 2878 bytes --] On Tue, Jan 29, 2008 at 02:15:15PM +0200, Boaz Harrosh wrote: > Greg KH wrote: > > On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: > >> Hi, > >> > >> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and > >> connecting my cf usb storage device yields and endless stream of: > >> > >> Initializing USB Mass Storage driver... > >> scsi6 : SCSI emulation for USB Mass Storage devices > >> usb-storage: device found at 2 > >> usb-storage: waiting for device to settle before scanning > >> usbcore: registered new interface driver usb-storage > >> USB Mass Storage support registered. > >> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >> ANSI: 0 > >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >> sd 6:0:0:0: [sdb] Write Protect is off > >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >> sd 6:0:0:0: [sdb] Write Protect is off > >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >> sdb: sdb1 > >> sd 6:0:0:0: [sdb] Attached SCSI removable disk > >> sd 6:0:0:0: Attached scsi generic sg1 type 0 > >> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >> ANSI: 0 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> [...] > >> > >> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. > >> I'm attaching boot messages and my .config. > > > > That's a bit wierd, as we haven't added any USB patches to the -git tree > > yet after 2.6.24 :) > > > > Could this be caused by some scsi changes perhaps? > > > > thanks, > > > > greg k-h > > - > Yes it is ;) > > Jens could you test the patch below? if it works I'll submit a proper > patch. Please forgive me for the bug. > > Matthew, Greg, Is there a way to extract from messages the usb storage transport > used? I'm guessing it is freecom do to the fact that I find a bug there. The freecom transport is exceptionally rare these days. It's primary user was a device made by a company that went out of business. Matt -- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver Way to go, lava boy. -- Stef to Greg User Friendly, 3/26/1998 [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 13:54 ` Jens Axboe [not found] ` <20080129135443.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 15:36 ` Alan Stern 1 sibling, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 13:54 UTC (permalink / raw) To: Boaz Harrosh Cc: Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Boaz Harrosh wrote: > Greg KH wrote: > > On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: > >> Hi, > >> > >> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and > >> connecting my cf usb storage device yields and endless stream of: > >> > >> Initializing USB Mass Storage driver... > >> scsi6 : SCSI emulation for USB Mass Storage devices > >> usb-storage: device found at 2 > >> usb-storage: waiting for device to settle before scanning > >> usbcore: registered new interface driver usb-storage > >> USB Mass Storage support registered. > >> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >> ANSI: 0 > >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >> sd 6:0:0:0: [sdb] Write Protect is off > >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >> sd 6:0:0:0: [sdb] Write Protect is off > >> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >> sdb: sdb1 > >> sd 6:0:0:0: [sdb] Attached SCSI removable disk > >> sd 6:0:0:0: Attached scsi generic sg1 type 0 > >> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >> ANSI: 0 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >> [...] > >> > >> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. > >> I'm attaching boot messages and my .config. > > > > That's a bit wierd, as we haven't added any USB patches to the -git tree > > yet after 2.6.24 :) > > > > Could this be caused by some scsi changes perhaps? > > > > thanks, > > > > greg k-h > > - > Yes it is ;) > > Jens could you test the patch below? if it works I'll submit a proper > patch. Please forgive me for the bug. No difference, still just a lot of resets. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129135443.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129135443.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 14:06 ` Boaz Harrosh [not found] ` <479F32E9.10609-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 2008-01-29 14:13 ` Boaz Harrosh 0 siblings, 2 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 14:06 UTC (permalink / raw) To: Jens Axboe Cc: Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > On Tue, Jan 29 2008, Boaz Harrosh wrote: >> Greg KH wrote: >>> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: >>>> Hi, >>>> >>>> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and >>>> connecting my cf usb storage device yields and endless stream of: >>>> >>>> Initializing USB Mass Storage driver... >>>> scsi6 : SCSI emulation for USB Mass Storage devices >>>> usb-storage: device found at 2 >>>> usb-storage: waiting for device to settle before scanning >>>> usbcore: registered new interface driver usb-storage >>>> USB Mass Storage support registered. >>>> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>> ANSI: 0 >>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>> sd 6:0:0:0: [sdb] Write Protect is off >>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>> sd 6:0:0:0: [sdb] Write Protect is off >>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>> sdb: sdb1 >>>> sd 6:0:0:0: [sdb] Attached SCSI removable disk >>>> sd 6:0:0:0: Attached scsi generic sg1 type 0 >>>> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>> ANSI: 0 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>> [...] >>>> >>>> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. >>>> I'm attaching boot messages and my .config. >>> That's a bit wierd, as we haven't added any USB patches to the -git tree >>> yet after 2.6.24 :) >>> >>> Could this be caused by some scsi changes perhaps? >>> >>> thanks, >>> >>> greg k-h >>> - >> Yes it is ;) >> >> Jens could you test the patch below? if it works I'll submit a proper >> patch. Please forgive me for the bug. > > No difference, still just a lot of resets. > Where you able to figure out which usb storage transport is used? in drivers/usb/storage/usb.c you have get_protocol() and get_transport() functions. I'm not sure if these get stored in sysfs perhaps. This will pinpoint better where to look. Let me research a bit. Thanks for testing Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F32E9.10609-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F32E9.10609-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 14:11 ` Jens Axboe [not found] ` <20080129141108.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 14:31 ` Oliver Neukum 0 siblings, 2 replies; 44+ messages in thread From: Jens Axboe @ 2008-01-29 14:11 UTC (permalink / raw) To: Boaz Harrosh Cc: Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Boaz Harrosh wrote: > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > >> Greg KH wrote: > >>> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: > >>>> Hi, > >>>> > >>>> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and > >>>> connecting my cf usb storage device yields and endless stream of: > >>>> > >>>> Initializing USB Mass Storage driver... > >>>> scsi6 : SCSI emulation for USB Mass Storage devices > >>>> usb-storage: device found at 2 > >>>> usb-storage: waiting for device to settle before scanning > >>>> usbcore: registered new interface driver usb-storage > >>>> USB Mass Storage support registered. > >>>> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >>>> ANSI: 0 > >>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >>>> sd 6:0:0:0: [sdb] Write Protect is off > >>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) > >>>> sd 6:0:0:0: [sdb] Write Protect is off > >>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 > >>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through > >>>> sdb: sdb1 > >>>> sd 6:0:0:0: [sdb] Attached SCSI removable disk > >>>> sd 6:0:0:0: Attached scsi generic sg1 type 0 > >>>> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 > >>>> ANSI: 0 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>> [...] > >>>> > >>>> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. > >>>> I'm attaching boot messages and my .config. > >>> That's a bit wierd, as we haven't added any USB patches to the -git tree > >>> yet after 2.6.24 :) > >>> > >>> Could this be caused by some scsi changes perhaps? > >>> > >>> thanks, > >>> > >>> greg k-h > >>> - > >> Yes it is ;) > >> > >> Jens could you test the patch below? if it works I'll submit a proper > >> patch. Please forgive me for the bug. > > > > No difference, still just a lot of resets. > > > Where you able to figure out which usb storage transport is used? > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > functions. I'm not sure if these get stored in sysfs perhaps. This will > pinpoint better where to look. Let me research a bit. Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and transport is 'Bulk' -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129141108.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129141108.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 14:14 ` Boaz Harrosh 0 siblings, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 14:14 UTC (permalink / raw) To: Jens Axboe Cc: Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 16:11 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > On Tue, Jan 29 2008, Boaz Harrosh wrote: >> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: >>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>> Greg KH wrote: >>>>> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: >>>>>> Hi, >>>>>> >>>>>> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and >>>>>> connecting my cf usb storage device yields and endless stream of: >>>>>> >>>>>> Initializing USB Mass Storage driver... >>>>>> scsi6 : SCSI emulation for USB Mass Storage devices >>>>>> usb-storage: device found at 2 >>>>>> usb-storage: waiting for device to settle before scanning >>>>>> usbcore: registered new interface driver usb-storage >>>>>> USB Mass Storage support registered. >>>>>> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>>>> ANSI: 0 >>>>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>>>> sd 6:0:0:0: [sdb] Write Protect is off >>>>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>>>> sd 6:0:0:0: [sdb] Write Protect is off >>>>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>>>> sdb: sdb1 >>>>>> sd 6:0:0:0: [sdb] Attached SCSI removable disk >>>>>> sd 6:0:0:0: Attached scsi generic sg1 type 0 >>>>>> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>>>> ANSI: 0 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>>> [...] >>>>>> >>>>>> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. >>>>>> I'm attaching boot messages and my .config. >>>>> That's a bit wierd, as we haven't added any USB patches to the -git tree >>>>> yet after 2.6.24 :) >>>>> >>>>> Could this be caused by some scsi changes perhaps? >>>>> >>>>> thanks, >>>>> >>>>> greg k-h >>>>> - >>>> Yes it is ;) >>>> >>>> Jens could you test the patch below? if it works I'll submit a proper >>>> patch. Please forgive me for the bug. >>> No difference, still just a lot of resets. >>> >> Where you able to figure out which usb storage transport is used? >> >> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() >> functions. I'm not sure if these get stored in sysfs perhaps. This will >> pinpoint better where to look. Let me research a bit. > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > transport is 'Bulk' > Sorry for the other noise. Thanks I'll have a look. ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 14:11 ` Jens Axboe [not found] ` <20080129141108.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 14:31 ` Oliver Neukum [not found] ` <200801291531.39825.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> 2008-01-29 15:50 ` Boaz Harrosh 1 sibling, 2 replies; 44+ messages in thread From: Oliver Neukum @ 2008-01-29 14:31 UTC (permalink / raw) To: Jens Axboe Cc: Boaz Harrosh, Greg KH, Matthew Dharm, linux-kernel, linux-usb, linux-scsi Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > >> Greg KH wrote: > > > No difference, still just a lot of resets. > > > > > Where you able to figure out which usb storage transport is used? > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > pinpoint better where to look. Let me research a bit. > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > transport is 'Bulk' You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG That should tell the reason for the resets. Regards Oliver ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <200801291531.39825.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <200801291531.39825.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> @ 2008-01-29 14:31 ` Jens Axboe 2008-01-29 18:39 ` Jens Axboe 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 14:31 UTC (permalink / raw) To: Oliver Neukum Cc: Boaz Harrosh, Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Oliver Neukum wrote: > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > >> Greg KH wrote: > > > > > No difference, still just a lot of resets. > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > pinpoint better where to look. Let me research a bit. > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > transport is 'Bulk' > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > That should tell the reason for the resets. Sure, I'll do that. Will post the results tonight. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 14:31 ` Jens Axboe @ 2008-01-29 18:39 ` Jens Axboe [not found] ` <20080129183910.GI15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 18:39 UTC (permalink / raw) To: Oliver Neukum Cc: Boaz Harrosh, Greg KH, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Oliver Neukum wrote: > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > >> Greg KH wrote: > > > > > > > No difference, still just a lot of resets. > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > pinpoint better where to look. Let me research a bit. > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > transport is 'Bulk' > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > That should tell the reason for the resets. > > Sure, I'll do that. Will post the results tonight. OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged in the device, waited 10 seconds or so and pulled it out. These are the messages. It all looks good until the MODE_SENSE command, where it only transfers 4 of 192 bytes. usb usb5: usb resume ehci_hcd 0000:00:1d.7: resume root hub hub 5-0:1.0: hub_resume hub 5-0:1.0: state 7 ports 8 chg 0000 evt 0000 ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001803 POWER sig=j CSC CONNECT hub 5-0:1.0: port 1, status 0501, change 0001, 480 Mb/s hub 5-0:1.0: debounce: port 1: total 100ms stable 100ms status 0x501 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: new high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: default language 0x0409 usb 5-1: uevent usb 5-1: usb_probe_device usb 5-1: configuration #1 chosen from 1 choice usb 5-1: adding 5-1:1.0 (config #1, interface 0) usb 5-1:1.0: uevent drivers/usb/core/inode.c: creating file '002' usb 5-1: new device strings: Mfr=0, Product=3, SerialNumber=4 usb 5-1: Product: Flash Reader usb 5-1: SerialNumber: 02206 Initializing USB Mass Storage driver... usb-storage 5-1:1.0: usb_probe_interface usb-storage 5-1:1.0: usb_probe_interface - got id usb-storage: USB Mass Storage device detected usb-storage: -- associate_dev usb-storage: Vendor: 0x05e3, Product: 0x0760, Revision: 0x0125 usb-storage: Interface Subclass: 0x06, Protocol: 0x50 usb trans Bulk usb-storage: Transport: Bulk usb proto Transparent SCSI usb-storage: Protocol: Transparent SCSI scsi6 : SCSI emulation for USB Mass Storage devices usb-storage: *** thread sleeping. usb-storage: device found at 2 usb-storage: waiting for device to settle before scanning usbcore: registered new interface driver usb-storage USB Mass Storage support registered. usb-storage: usb_stor_control_msg: rq=fe rqtype=a1 value=0000 index=00 len=1 usb-storage: GetMaxLUN command result is 1, data is 3 usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command INQUIRY (6 bytes) usb-storage: 12 00 00 00 24 00 usb-storage: Bulk Command S 0x43425355 T 0x1 L 36 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 36 bytes, 1 entries usb-storage: Status code 0; transferred 36/36 usb-storage: -- transfer complete usb-storage: Bulk data transfer result 0x0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x1 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 ANSI: 0 usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x2 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x2 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x3 L 8 F 128 Trg 0 LUN 0 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code 0; transferred 8/8 usb-storage: -- transfer complete usb-storage: Bulk data transfer result 0x0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x3 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command MODE_SENSE (6 bytes) usb-storage: 1a 00 3f 00 c0 00 usb-storage: Bulk Command S 0x43425355 T 0x4 L 192 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries usb-storage: Status code -121; transferred 4/192 usb-storage: -- short read transfer usb-storage: Bulk data transfer result 0x1 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -32; transferred 0/13 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Attempting to get CSW (2nd try)... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x4 R 188 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sd 6:0:0:0: [sdb] Write Protect is off sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 sd 6:0:0:0: [sdb] Assuming drive cache: write through usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x5 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x5 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command ALLOW_MEDIUM_REMOVAL (6 bytes) usb-storage: 1e 00 00 00 01 00 usb-storage: Bulk Command S 0x43425355 T 0x6 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x6 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x7 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x7 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x8 L 8 F 128 Trg 0 LUN 0 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code 0; transferred 8/8 usb-storage: -- transfer complete usb-storage: Bulk data transfer result 0x0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x8 R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command MODE_SENSE (6 bytes) usb-storage: 1a 00 3f 00 c0 00 usb-storage: Bulk Command S 0x43425355 T 0x9 L 192 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries usb-storage: Status code -121; transferred 4/192 usb-storage: -- short read transfer usb-storage: Bulk data transfer result 0x1 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -32; transferred 0/13 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Attempting to get CSW (2nd try)... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x9 R 188 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sd 6:0:0:0: [sdb] Write Protect is off sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 sd 6:0:0:0: [sdb] Assuming drive cache: write through sdb:<7>usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_10 (10 bytes) usb-storage: 28 00 00 00 00 00 00 00 08 00 usb-storage: Bulk Command S 0x43425355 T 0xa L 4096 F 128 Trg 0 LUN 0 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 4096 bytes, 1 entries usb-storage: Status code 0; transferred 4096/4096 usb-storage: -- transfer complete usb-storage: Bulk data transfer result 0x0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0xa R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sdb1 usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command ALLOW_MEDIUM_REMOVAL (6 bytes) usb-storage: 1e 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0xb L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0xb R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. sd 6:0:0:0: [sdb] Attached SCSI removable disk sd 6:0:0:0: Attached scsi generic sg1 type 0 usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command INQUIRY (6 bytes) usb-storage: 12 00 00 00 24 00 usb-storage: Bulk Command S 0x43425355 T 0xc L 36 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 36 bytes, 1 entries usb-storage: Status code 0; transferred 36/36 usb-storage: -- transfer complete usb-storage: Bulk data transfer result 0x0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0xc R 0 Stat 0x0 usb-storage: scsi cmd done, result=0x0 usb-storage: *** thread sleeping. scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 ANSI: 0 usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0xf L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0xf R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x10 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x11 L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x11 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x12 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x13 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x13 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x14 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x15 L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x15 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x16 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x17 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x17 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x18 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x19 L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x19 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x1a L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x1b L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x1b R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x1c L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x1d L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x1d R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x1e L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x1f L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x1f R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x20 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x21 L 0 F 0 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x21 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x22 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x23 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x23 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x24 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x25 L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x25 R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x26 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x27 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x27 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x28 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x29 L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x29 R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x2a L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x2b L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x2b R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x2c L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x2d L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x2d R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x2e L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x2f L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x2f R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x30 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x31 L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x31 R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x32 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x33 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x33 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x34 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x35 L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x35 R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x36 L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x37 L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x37 R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x38 L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command READ_CAPACITY (10 bytes) usb-storage: 25 00 00 00 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x39 L 8 F 128 Trg 0 LUN 1 CL 10 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 8 bytes, 1 entries usb-storage: Status code -32; transferred 0/8 usb-storage: clearing endpoint halt for pipe 0xc0008280 usb-storage: usb_stor_control_msg: rq=01 rqtype=02 value=0000 index=81 len=0 usb-storage: usb_stor_clear_halt: result = 0 usb-storage: Bulk data transfer result 0x2 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x39 R 8 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: -- unexpectedly short transfer usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x3a L 18 F 128 Trg 0 LUN 1 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: Status code -75; transferred 0/18 usb-storage: -- babble usb-storage: Bulk data transfer result 0x3 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code -75; transferred 0/13 usb-storage: -- babble usb-storage: Bulk status result = 3 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns 0 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called usb-storage: *** thread awakened. usb-storage: Command TEST_UNIT_READY (6 bytes) usb-storage: 00 00 00 00 00 00 usb-storage: Bulk Command S 0x43425355 T 0x3b L 0 F 0 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: Attempting to get CSW... usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes usb-storage: Status code 0; transferred 13/13 usb-storage: -- transfer complete usb-storage: Bulk status result = 0 usb-storage: Bulk Status S 0x53425355 T 0x3b R 0 Stat 0x1 usb-storage: -- transport indicates command failure usb-storage: Issuing auto-REQUEST_SENSE usb-storage: Bulk Command S 0x43425355 T 0x3c L 18 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries usb-storage: usb_sg_init returned -22 usb-storage: Bulk data transfer result 0x4 usb-storage: -- auto-sense failure usb-storage: storage_pre_reset ehci_hcd 0000:00:1d.7: port 1 high speed ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT hub 5-0:1.0: state 7 ports 8 chg 0000 evt 0002 usb 5-1: reset high speed USB device using ehci_hcd and address 2 ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: devpath 1 ep0in 3strikes ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001002 POWER sig=se0 CSC hub 5-0:1.0: logical disconnect on port 1 usb-storage: storage_post_reset usb-storage: usb_reset_composite_device returns -19 usb-storage: usb_stor_Bulk_reset called usb-storage: usb_stor_control_msg: rq=ff rqtype=21 value=0000 index=00 len=0 usb-storage: Soft reset failed: -19 usb-storage: scsi cmd done, result=0x70000 usb-storage: *** thread sleeping. usb-storage: queuecommand called hub 5-0:1.0: state 7 ports 8 chg 0002 evt 0002 hub 5-0:1.0: port 1, status 0100, change 0000, 12 Mb/s usb 5-1: USB disconnect, address 2 usb 5-1: unregistering device usb 5-1: usb_disable_device nuking all URBs usb 5-1: unregistering interface 5-1:1.0 usb-storage: storage_disconnect() called usb-storage: usb_stor_stop_transport called usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect sd 6:0:0:1: [sdc] READ CAPACITY failed sd 6:0:0:1: [sdc] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK sd 6:0:0:1: [sdc] Sense not available. usb-storage: queuecommand called usb-storage: Fail command during disconnect sd 6:0:0:1: [sdc] Write Protect is off sd 6:0:0:1: [sdc] Mode Sense: 00 00 00 00 sd 6:0:0:1: [sdc] Assuming drive cache: write through sd 6:0:0:1: [sdc] Attached SCSI removable disk sd 6:0:0:1: Attached scsi generic sg2 type 0 usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect sd 6:0:0:0: [sdb] READ CAPACITY failed sd 6:0:0:0: [sdb] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK sd 6:0:0:0: [sdb] Sense not available. usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: *** thread awakened. usb-storage: -- exiting usb-storage: queuecommand called usb-storage: Fail command during disconnect sd 6:0:0:0: [sdb] Write Protect is off sd 6:0:0:0: [sdb] Mode Sense: 00 00 00 00 sd 6:0:0:0: [sdb] Assuming drive cache: write through usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: queuecommand called usb-storage: Fail command during disconnect usb-storage: device scan complete usb-storage: -- usb_stor_release_resources usb-storage: -- sending exit command to thread scsi 6:0:0:0: [sdb] READ CAPACITY failed scsi 6:0:0:0: [sdb] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK scsi 6:0:0:0: [sdb] Sense not available. scsi 6:0:0:0: rejecting I/O to dead device scsi 6:0:0:0: [sdb] Write Protect is off scsi 6:0:0:0: [sdb] Mode Sense: 00 00 00 00 scsi 6:0:0:0: [sdb] Assuming drive cache: write through scsi 6:0:0:0: rejecting I/O to dead device usb-storage: -- dissociate_dev usb 5-1:1.0: uevent usb 5-1: uevent hub 5-0:1.0: hub_suspend usb usb5: bus auto-suspend ehci_hcd 0000:00:1d.7: suspend root hub -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129183910.GI15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129183910.GI15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 19:09 ` Boaz Harrosh 2008-01-29 19:10 ` Matthew Dharm 1 sibling, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 19:09 UTC (permalink / raw) To: Jens Axboe Cc: Oliver Neukum, Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 20:39 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > On Tue, Jan 29 2008, Jens Axboe wrote: >> On Tue, Jan 29 2008, Oliver Neukum wrote: >>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: >>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: >>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>>>>> Greg KH wrote: >>> >>>>>> No difference, still just a lot of resets. >>>>>> >>>>> Where you able to figure out which usb storage transport is used? >>>>> >>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() >>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will >>>>> pinpoint better where to look. Let me research a bit. >>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and >>>> transport is 'Bulk' >>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG >>> That should tell the reason for the resets. >> Sure, I'll do that. Will post the results tonight. > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > in the device, waited 10 seconds or so and pulled it out. These are the > messages. > > It all looks good until the MODE_SENSE command, where it only transfers > 4 of 192 bytes. > <snip> > usb-storage: Command MODE_SENSE (6 bytes) > usb-storage: 1a 00 3f 00 c0 00 > usb-storage: Bulk Command S 0x43425355 T 0x4 L 192 F 128 Trg 0 LUN 0 CL 6 > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > usb-storage: Status code 0; transferred 31/31 > usb-storage: -- transfer complete > usb-storage: Bulk command transfer result=0 > usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries > usb-storage: Status code -121; transferred 4/192 > usb-storage: -- short read transfer > usb-storage: Bulk data transfer result 0x1 > usb-storage: Attempting to get CSW... <snip> I get something similar but better: usb-storage: Command MODE_SENSE (6 bytes) usb-storage: 1a 00 3f 00 c0 00 usb-storage: Bulk Command S 0x43425355 T 0x6 L 192 F 128 Trg 0 LUN 0 CL 6 usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes usb-storage: Status code 0; transferred 31/31 usb-storage: -- transfer complete usb-storage: Bulk command transfer result=0 usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries usb-storage: Status code -121; transferred 36/192 usb-storage: -- short read transfer usb-storage: Bulk data transfer result 0x1 usb-storage: Attempting to get CSW... So I get 36 bytes, then code goes on into one reset, and every thing is then fine. Could you put us out of our mesery and revert that patch: [SCSI] usb: transport - convert to accessors and !use_sg code path removal (6d416e6173394defda5933e419e805b696681b7e) to make sure this is it. I hate to do this to you, but I cannot reproduce the failure down here. If it works please send a log with the debugs on perhaps we can compare. You will need to configure out the CONFIG_USB_STORAG_* they will not compile you should have only have CONFIG_USB_STORAGE & CONFIG_USB_STORAGE_DEBUG. it should support your HW. Thanks Jens Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129183910.GI15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 19:09 ` Boaz Harrosh @ 2008-01-29 19:10 ` Matthew Dharm [not found] ` <20080129191024.GO14375-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org> 2008-01-29 19:33 ` James Bottomley 1 sibling, 2 replies; 44+ messages in thread From: Matthew Dharm @ 2008-01-29 19:10 UTC (permalink / raw) To: Jens Axboe Cc: Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 3508 bytes --] On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > On Tue, Jan 29 2008, Jens Axboe wrote: > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > >> Greg KH wrote: > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > transport is 'Bulk' > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > That should tell the reason for the resets. > > > > Sure, I'll do that. Will post the results tonight. > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > in the device, waited 10 seconds or so and pulled it out. These are the > messages. > > It all looks good until the MODE_SENSE command, where it only transfers > 4 of 192 bytes. No, that's not the problem. This is the problem: > usb-storage: *** thread awakened. > usb-storage: Command TEST_UNIT_READY (6 bytes) > usb-storage: 00 00 00 00 00 00 > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > usb-storage: Status code 0; transferred 31/31 > usb-storage: -- transfer complete > usb-storage: Bulk command transfer result=0 > usb-storage: Attempting to get CSW... > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > usb-storage: Status code 0; transferred 13/13 > usb-storage: -- transfer complete > usb-storage: Bulk status result = 0 > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > usb-storage: -- transport indicates command failure > usb-storage: Issuing auto-REQUEST_SENSE > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > usb-storage: Status code 0; transferred 31/31 > usb-storage: -- transfer complete > usb-storage: Bulk command transfer result=0 > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > usb-storage: usb_sg_init returned -22 > usb-storage: Bulk data transfer result 0x4 > usb-storage: -- auto-sense failure > usb-storage: storage_pre_reset > ehci_hcd 0000:00:1d.7: port 1 high speed > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > ehci_hcd 0000:00:1d.7: port 1 high speed > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > usb-storage: storage_post_reset > usb-storage: usb_reset_composite_device returns 0 > usb-storage: scsi cmd done, result=0x70000 > usb-storage: *** thread sleeping. For some reason, usb_sg_init is boned during auto-sense. Matt -- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver It was a new hope. -- Dust Puppy User Friendly, 12/25/1998 [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129191024.GO14375-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129191024.GO14375-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org> @ 2008-01-29 19:15 ` Jens Axboe [not found] ` <20080129191504.GO15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 19:37 ` Matthew Dharm 0 siblings, 2 replies; 44+ messages in thread From: Jens Axboe @ 2008-01-29 19:15 UTC (permalink / raw) To: Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Matthew Dharm wrote: > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > >> Greg KH wrote: > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > transport is 'Bulk' > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > That should tell the reason for the resets. > > > > > > Sure, I'll do that. Will post the results tonight. > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > in the device, waited 10 seconds or so and pulled it out. These are the > > messages. > > > > It all looks good until the MODE_SENSE command, where it only transfers > > 4 of 192 bytes. > > No, that's not the problem. This is the problem: It's where the problem starts, otherwise there would not be a need to sense :-) > > usb-storage: *** thread awakened. > > usb-storage: Command TEST_UNIT_READY (6 bytes) > > usb-storage: 00 00 00 00 00 00 > > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > usb-storage: Status code 0; transferred 31/31 > > usb-storage: -- transfer complete > > usb-storage: Bulk command transfer result=0 > > usb-storage: Attempting to get CSW... > > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > usb-storage: Status code 0; transferred 13/13 > > usb-storage: -- transfer complete > > usb-storage: Bulk status result = 0 > > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > usb-storage: -- transport indicates command failure > > usb-storage: Issuing auto-REQUEST_SENSE > > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > usb-storage: Status code 0; transferred 31/31 > > usb-storage: -- transfer complete > > usb-storage: Bulk command transfer result=0 > > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > usb-storage: usb_sg_init returned -22 > > usb-storage: Bulk data transfer result 0x4 > > usb-storage: -- auto-sense failure > > usb-storage: storage_pre_reset > > ehci_hcd 0000:00:1d.7: port 1 high speed > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > ehci_hcd 0000:00:1d.7: port 1 high speed > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > usb-storage: storage_post_reset > > usb-storage: usb_reset_composite_device returns 0 > > usb-storage: scsi cmd done, result=0x70000 > > usb-storage: *** thread sleeping. > > For some reason, usb_sg_init is boned during auto-sense. My guess would be that sg == NULL, hence the -EINVAL. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129191504.GO15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129191504.GO15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 19:26 ` Jens Axboe 0 siblings, 0 replies; 44+ messages in thread From: Jens Axboe @ 2008-01-29 19:26 UTC (permalink / raw) To: Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Matthew Dharm wrote: > > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > >> Greg KH wrote: > > > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > > transport is 'Bulk' > > > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > > That should tell the reason for the resets. > > > > > > > > Sure, I'll do that. Will post the results tonight. > > > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > > in the device, waited 10 seconds or so and pulled it out. These are the > > > messages. > > > > > > It all looks good until the MODE_SENSE command, where it only transfers > > > 4 of 192 bytes. > > > > No, that's not the problem. This is the problem: > > It's where the problem starts, otherwise there would not be a need to > sense :-) > > > > usb-storage: *** thread awakened. > > > usb-storage: Command TEST_UNIT_READY (6 bytes) > > > usb-storage: 00 00 00 00 00 00 > > > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > usb-storage: Status code 0; transferred 31/31 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk command transfer result=0 > > > usb-storage: Attempting to get CSW... > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > > usb-storage: Status code 0; transferred 13/13 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk status result = 0 > > > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > > usb-storage: -- transport indicates command failure > > > usb-storage: Issuing auto-REQUEST_SENSE > > > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > usb-storage: Status code 0; transferred 31/31 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk command transfer result=0 > > > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > > usb-storage: usb_sg_init returned -22 > > > usb-storage: Bulk data transfer result 0x4 > > > usb-storage: -- auto-sense failure > > > usb-storage: storage_pre_reset > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > usb-storage: storage_post_reset > > > usb-storage: usb_reset_composite_device returns 0 > > > usb-storage: scsi cmd done, result=0x70000 > > > usb-storage: *** thread sleeping. > > > > For some reason, usb_sg_init is boned during auto-sense. > > My guess would be that sg == NULL, hence the -EINVAL. Yep, trace below: WARNING: at drivers/usb/storage/transport.c:426 usb_stor_bulk_transfer_sglist() Pid: 12536, comm: usb-storage Not tainted 2.6.24 #74 [<7810541a>] show_trace_log_lvl+0x1a/0x30 [<78105e82>] show_trace+0x12/0x20 [<7810689c>] dump_stack+0x6c/0x80 [<f83e267e>] usb_stor_bulk_transfer_sglist+0x14e/0x160 [usb_storage] [<f83e2730>] usb_stor_bulk_srb_length+0x30/0x50 [usb_storage] [<f83e2762>] usb_stor_bulk_srb+0x12/0x20 [usb_storage] [<f83e2ce0>] usb_stor_Bulk_transport+0x190/0x3d0 [usb_storage] [<f83e30d6>] usb_stor_invoke_transport+0x1b6/0x320 [usb_storage] [<f83e1a38>] usb_stor_transparent_scsi_command+0x8/0x10 [usb_storage] [<f83e3813>] usb_stor_control_thread+0x143/0x2c0 [usb_storage] [<7813bc02>] kthread+0x42/0x70 [<78104fab>] kernel_thread_helper+0x7/0x1c ======================= usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries, sg 00000000 usb-storage: usb_sg_init returned -22 -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 19:15 ` Jens Axboe [not found] ` <20080129191504.GO15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 19:37 ` Matthew Dharm 1 sibling, 0 replies; 44+ messages in thread From: Matthew Dharm @ 2008-01-29 19:37 UTC (permalink / raw) To: Jens Axboe Cc: Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi [-- Attachment #1: Type: text/plain, Size: 2311 bytes --] On Tue, Jan 29, 2008 at 08:15:04PM +0100, Jens Axboe wrote: > On Tue, Jan 29 2008, Matthew Dharm wrote: > > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > >> Greg KH wrote: > > > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > > transport is 'Bulk' > > > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > > That should tell the reason for the resets. > > > > > > > > Sure, I'll do that. Will post the results tonight. > > > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > > in the device, waited 10 seconds or so and pulled it out. These are the > > > messages. > > > > > > It all looks good until the MODE_SENSE command, where it only transfers > > > 4 of 192 bytes. > > > > No, that's not the problem. This is the problem: > > It's where the problem starts, otherwise there would not be a need to > sense :-) MODE_SENSE has nothing to do with it. A short MODE_SENSE response is perfectly valid, and the log shows it was handled correctly and subsequent commands worked just fine. It's not until the TUR fails that we get the problem. Matt -- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver P: Nine more messages in admin.policy. M: I know, I'm typing as fast as I can! -- Pitr and Mike User Friendly, 11/27/97 [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 19:10 ` Matthew Dharm [not found] ` <20080129191024.GO14375-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org> @ 2008-01-29 19:33 ` James Bottomley 2008-01-29 19:35 ` Jens Axboe 1 sibling, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 19:33 UTC (permalink / raw) To: Matthew Dharm Cc: Jens Axboe, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > >> Greg KH wrote: > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > transport is 'Bulk' > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > That should tell the reason for the resets. > > > > > > Sure, I'll do that. Will post the results tonight. > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > in the device, waited 10 seconds or so and pulled it out. These are the > > messages. > > > > It all looks good until the MODE_SENSE command, where it only transfers > > 4 of 192 bytes. > > No, that's not the problem. This is the problem: > > > usb-storage: *** thread awakened. > > usb-storage: Command TEST_UNIT_READY (6 bytes) > > usb-storage: 00 00 00 00 00 00 > > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > usb-storage: Status code 0; transferred 31/31 > > usb-storage: -- transfer complete > > usb-storage: Bulk command transfer result=0 > > usb-storage: Attempting to get CSW... > > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > usb-storage: Status code 0; transferred 13/13 > > usb-storage: -- transfer complete > > usb-storage: Bulk status result = 0 > > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > usb-storage: -- transport indicates command failure > > usb-storage: Issuing auto-REQUEST_SENSE > > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > usb-storage: Status code 0; transferred 31/31 > > usb-storage: -- transfer complete > > usb-storage: Bulk command transfer result=0 > > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > usb-storage: usb_sg_init returned -22 > > usb-storage: Bulk data transfer result 0x4 > > usb-storage: -- auto-sense failure > > usb-storage: storage_pre_reset > > ehci_hcd 0000:00:1d.7: port 1 high speed > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > ehci_hcd 0000:00:1d.7: port 1 high speed > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > usb-storage: storage_post_reset > > usb-storage: usb_reset_composite_device returns 0 > > usb-storage: scsi cmd done, result=0x70000 > > usb-storage: *** thread sleeping. > > For some reason, usb_sg_init is boned during auto-sense. OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense code ... that was also an update in 2.6.24 James ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 19:33 ` James Bottomley @ 2008-01-29 19:35 ` Jens Axboe 2008-01-29 19:45 ` Jens Axboe 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 19:35 UTC (permalink / raw) To: James Bottomley Cc: Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008, James Bottomley wrote: > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > >> Greg KH wrote: > > > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > > transport is 'Bulk' > > > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > > That should tell the reason for the resets. > > > > > > > > Sure, I'll do that. Will post the results tonight. > > > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > > in the device, waited 10 seconds or so and pulled it out. These are the > > > messages. > > > > > > It all looks good until the MODE_SENSE command, where it only transfers > > > 4 of 192 bytes. > > > > No, that's not the problem. This is the problem: > > > > > usb-storage: *** thread awakened. > > > usb-storage: Command TEST_UNIT_READY (6 bytes) > > > usb-storage: 00 00 00 00 00 00 > > > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > usb-storage: Status code 0; transferred 31/31 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk command transfer result=0 > > > usb-storage: Attempting to get CSW... > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > > usb-storage: Status code 0; transferred 13/13 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk status result = 0 > > > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > > usb-storage: -- transport indicates command failure > > > usb-storage: Issuing auto-REQUEST_SENSE > > > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > usb-storage: Status code 0; transferred 31/31 > > > usb-storage: -- transfer complete > > > usb-storage: Bulk command transfer result=0 > > > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > > usb-storage: usb_sg_init returned -22 > > > usb-storage: Bulk data transfer result 0x4 > > > usb-storage: -- auto-sense failure > > > usb-storage: storage_pre_reset > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > usb-storage: storage_post_reset > > > usb-storage: usb_reset_composite_device returns 0 > > > usb-storage: scsi cmd done, result=0x70000 > > > usb-storage: *** thread sleeping. > > > > For some reason, usb_sg_init is boned during auto-sense. > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > code ... that was also an update in 2.6.24 yeah, already found the bug - it's assuming ->request_buffer holds the sglist, oops. Preparing a fix. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 19:35 ` Jens Axboe @ 2008-01-29 19:45 ` Jens Axboe [not found] ` <20080129194543.GR15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 19:45 UTC (permalink / raw) To: James Bottomley Cc: Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, James Bottomley wrote: > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > > On Tue, Jan 29 2008, Oliver Neukum wrote: > > > > > > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > > > > > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > > > > > > >> Greg KH wrote: > > > > > > > > > > > > > > > No difference, still just a lot of resets. > > > > > > > > > > > > > > > > > Where you able to figure out which usb storage transport is used? > > > > > > > > > > > > > > > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > > > > > > functions. I'm not sure if these get stored in sysfs perhaps. This will > > > > > > > > pinpoint better where to look. Let me research a bit. > > > > > > > > > > > > > > Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > > > > > transport is 'Bulk' > > > > > > > > > > > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > > > > That should tell the reason for the resets. > > > > > > > > > > Sure, I'll do that. Will post the results tonight. > > > > > > > > OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > > > in the device, waited 10 seconds or so and pulled it out. These are the > > > > messages. > > > > > > > > It all looks good until the MODE_SENSE command, where it only transfers > > > > 4 of 192 bytes. > > > > > > No, that's not the problem. This is the problem: > > > > > > > usb-storage: *** thread awakened. > > > > usb-storage: Command TEST_UNIT_READY (6 bytes) > > > > usb-storage: 00 00 00 00 00 00 > > > > usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > > usb-storage: Status code 0; transferred 31/31 > > > > usb-storage: -- transfer complete > > > > usb-storage: Bulk command transfer result=0 > > > > usb-storage: Attempting to get CSW... > > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > > > usb-storage: Status code 0; transferred 13/13 > > > > usb-storage: -- transfer complete > > > > usb-storage: Bulk status result = 0 > > > > usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > > > usb-storage: -- transport indicates command failure > > > > usb-storage: Issuing auto-REQUEST_SENSE > > > > usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > > > usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > > usb-storage: Status code 0; transferred 31/31 > > > > usb-storage: -- transfer complete > > > > usb-storage: Bulk command transfer result=0 > > > > usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > > > usb-storage: usb_sg_init returned -22 > > > > usb-storage: Bulk data transfer result 0x4 > > > > usb-storage: -- auto-sense failure > > > > usb-storage: storage_pre_reset > > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > > usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > > > ehci_hcd 0000:00:1d.7: port 1 high speed > > > > ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > > usb-storage: storage_post_reset > > > > usb-storage: usb_reset_composite_device returns 0 > > > > usb-storage: scsi cmd done, result=0x70000 > > > > usb-storage: *** thread sleeping. > > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > code ... that was also an update in 2.6.24 > > yeah, already found the bug - it's assuming ->request_buffer holds the > sglist, oops. Preparing a fix. ok here goes, this saves and restores the sg table correctly. it also fixes the usb bug for me. diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 547e85a..12770ef 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, ses->use_sg = scmd->use_sg; ses->resid = scmd->resid; ses->result = scmd->result; + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); if (sense_bytes) { scmd->request_bufflen = min_t(unsigned, SCSI_SENSE_BUFFERSIZE, sense_bytes); sg_init_one(&ses->sense_sgl, scmd->sense_buffer, scmd->request_bufflen); - scmd->request_buffer = &ses->sense_sgl; + scmd->sg_table.sgl = &ses->sense_sgl; + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; scmd->sc_data_direction = DMA_FROM_DEVICE; scmd->use_sg = 1; memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) scmd->request_bufflen = ses->bufflen; scmd->request_buffer = ses->buffer; scmd->use_sg = ses->use_sg; + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); scmd->resid = ses->resid; scmd->result = ses->result; } diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h index d21b891..d43dc83 100644 --- a/include/scsi/scsi_eh.h +++ b/include/scsi/scsi_eh.h @@ -75,6 +75,7 @@ struct scsi_eh_save { void *buffer; unsigned bufflen; + struct sg_table sg_table; unsigned short use_sg; int resid; -- Jens Axboe ^ permalink raw reply related [flat|nested] 44+ messages in thread
[parent not found: <20080129194543.GR15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129194543.GR15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 19:58 ` Boaz Harrosh [not found] ` <479F856C.4090900-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 2008-01-30 10:27 ` Geert Uytterhoeven 1 sibling, 1 reply; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 19:58 UTC (permalink / raw) To: Jens Axboe Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 21:45 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > On Tue, Jan 29 2008, Jens Axboe wrote: >> On Tue, Jan 29 2008, James Bottomley wrote: >>> On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: >>>> On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: >>>>> On Tue, Jan 29 2008, Jens Axboe wrote: >>>>>> On Tue, Jan 29 2008, Oliver Neukum wrote: >>>>>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: >>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>>>>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: >>>>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>>>>>>>>> Greg KH wrote: >>>>>>> >>>>>>>>>> No difference, still just a lot of resets. >>>>>>>>>> >>>>>>>>> Where you able to figure out which usb storage transport is used? >>>>>>>>> >>>>>>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() >>>>>>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will >>>>>>>>> pinpoint better where to look. Let me research a bit. >>>>>>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and >>>>>>>> transport is 'Bulk' >>>>>>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG >>>>>>> That should tell the reason for the resets. >>>>>> Sure, I'll do that. Will post the results tonight. >>>>> OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged >>>>> in the device, waited 10 seconds or so and pulled it out. These are the >>>>> messages. >>>>> >>>>> It all looks good until the MODE_SENSE command, where it only transfers >>>>> 4 of 192 bytes. >>>> No, that's not the problem. This is the problem: >>>> >>>>> usb-storage: *** thread awakened. >>>>> usb-storage: Command TEST_UNIT_READY (6 bytes) >>>>> usb-storage: 00 00 00 00 00 00 >>>>> usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes >>>>> usb-storage: Status code 0; transferred 31/31 >>>>> usb-storage: -- transfer complete >>>>> usb-storage: Bulk command transfer result=0 >>>>> usb-storage: Attempting to get CSW... >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes >>>>> usb-storage: Status code 0; transferred 13/13 >>>>> usb-storage: -- transfer complete >>>>> usb-storage: Bulk status result = 0 >>>>> usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 >>>>> usb-storage: -- transport indicates command failure >>>>> usb-storage: Issuing auto-REQUEST_SENSE >>>>> usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes >>>>> usb-storage: Status code 0; transferred 31/31 >>>>> usb-storage: -- transfer complete >>>>> usb-storage: Bulk command transfer result=0 >>>>> usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries >>>>> usb-storage: usb_sg_init returned -22 >>>>> usb-storage: Bulk data transfer result 0x4 >>>>> usb-storage: -- auto-sense failure >>>>> usb-storage: storage_pre_reset >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT >>>>> usb-storage: storage_post_reset >>>>> usb-storage: usb_reset_composite_device returns 0 >>>>> usb-storage: scsi cmd done, result=0x70000 >>>>> usb-storage: *** thread sleeping. >>>> For some reason, usb_sg_init is boned during auto-sense. >>> OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense >>> code ... that was also an update in 2.6.24 >> yeah, already found the bug - it's assuming ->request_buffer holds the >> sglist, oops. Preparing a fix. > > ok here goes, this saves and restores the sg table correctly. it also > fixes the usb bug for me. > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index 547e85a..12770ef 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > ses->use_sg = scmd->use_sg; > ses->resid = scmd->resid; > ses->result = scmd->result; > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > if (sense_bytes) { > scmd->request_bufflen = min_t(unsigned, > SCSI_SENSE_BUFFERSIZE, sense_bytes); > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > scmd->request_bufflen); > - scmd->request_buffer = &ses->sense_sgl; > + scmd->sg_table.sgl = &ses->sense_sgl; > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > scmd->sc_data_direction = DMA_FROM_DEVICE; > scmd->use_sg = 1; > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > scmd->request_bufflen = ses->bufflen; > scmd->request_buffer = ses->buffer; > scmd->use_sg = ses->use_sg; > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > scmd->resid = ses->resid; > scmd->result = ses->result; > } > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > index d21b891..d43dc83 100644 > --- a/include/scsi/scsi_eh.h > +++ b/include/scsi/scsi_eh.h > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > void *buffer; > unsigned bufflen; > + struct sg_table sg_table; > unsigned short use_sg; > int resid; > > Ok this is not in Linus tree is it? Hence I did not have that failure. Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F856C.4090900-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F856C.4090900-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 20:03 ` Jens Axboe [not found] ` <20080129200311.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 20:09 ` Boaz Harrosh 1 sibling, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 20:03 UTC (permalink / raw) To: Boaz Harrosh Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Boaz Harrosh wrote: > On Tue, Jan 29 2008 at 21:45 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > On Tue, Jan 29 2008, Jens Axboe wrote: > >> On Tue, Jan 29 2008, James Bottomley wrote: > >>> On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > >>>> On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > >>>>> On Tue, Jan 29 2008, Jens Axboe wrote: > >>>>>> On Tue, Jan 29 2008, Oliver Neukum wrote: > >>>>>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > >>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > >>>>>>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > >>>>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > >>>>>>>>>>> Greg KH wrote: > >>>>>>> > >>>>>>>>>> No difference, still just a lot of resets. > >>>>>>>>>> > >>>>>>>>> Where you able to figure out which usb storage transport is used? > >>>>>>>>> > >>>>>>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > >>>>>>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will > >>>>>>>>> pinpoint better where to look. Let me research a bit. > >>>>>>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > >>>>>>>> transport is 'Bulk' > >>>>>>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > >>>>>>> That should tell the reason for the resets. > >>>>>> Sure, I'll do that. Will post the results tonight. > >>>>> OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > >>>>> in the device, waited 10 seconds or so and pulled it out. These are the > >>>>> messages. > >>>>> > >>>>> It all looks good until the MODE_SENSE command, where it only transfers > >>>>> 4 of 192 bytes. > >>>> No, that's not the problem. This is the problem: > >>>> > >>>>> usb-storage: *** thread awakened. > >>>>> usb-storage: Command TEST_UNIT_READY (6 bytes) > >>>>> usb-storage: 00 00 00 00 00 00 > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > >>>>> usb-storage: Status code 0; transferred 31/31 > >>>>> usb-storage: -- transfer complete > >>>>> usb-storage: Bulk command transfer result=0 > >>>>> usb-storage: Attempting to get CSW... > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > >>>>> usb-storage: Status code 0; transferred 13/13 > >>>>> usb-storage: -- transfer complete > >>>>> usb-storage: Bulk status result = 0 > >>>>> usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > >>>>> usb-storage: -- transport indicates command failure > >>>>> usb-storage: Issuing auto-REQUEST_SENSE > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > >>>>> usb-storage: Status code 0; transferred 31/31 > >>>>> usb-storage: -- transfer complete > >>>>> usb-storage: Bulk command transfer result=0 > >>>>> usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > >>>>> usb-storage: usb_sg_init returned -22 > >>>>> usb-storage: Bulk data transfer result 0x4 > >>>>> usb-storage: -- auto-sense failure > >>>>> usb-storage: storage_pre_reset > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > >>>>> usb-storage: storage_post_reset > >>>>> usb-storage: usb_reset_composite_device returns 0 > >>>>> usb-storage: scsi cmd done, result=0x70000 > >>>>> usb-storage: *** thread sleeping. > >>>> For some reason, usb_sg_init is boned during auto-sense. > >>> OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > >>> code ... that was also an update in 2.6.24 > >> yeah, already found the bug - it's assuming ->request_buffer holds the > >> sglist, oops. Preparing a fix. > > > > ok here goes, this saves and restores the sg table correctly. it also > > fixes the usb bug for me. > > > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > index 547e85a..12770ef 100644 > > --- a/drivers/scsi/scsi_error.c > > +++ b/drivers/scsi/scsi_error.c > > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > > ses->use_sg = scmd->use_sg; > > ses->resid = scmd->resid; > > ses->result = scmd->result; > > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > > > if (sense_bytes) { > > scmd->request_bufflen = min_t(unsigned, > > SCSI_SENSE_BUFFERSIZE, sense_bytes); > > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > > scmd->request_bufflen); > > - scmd->request_buffer = &ses->sense_sgl; > > + scmd->sg_table.sgl = &ses->sense_sgl; > > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > > scmd->sc_data_direction = DMA_FROM_DEVICE; > > scmd->use_sg = 1; > > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > > scmd->request_bufflen = ses->bufflen; > > scmd->request_buffer = ses->buffer; > > scmd->use_sg = ses->use_sg; > > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > > scmd->resid = ses->resid; > > scmd->result = ses->result; > > } > > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > > index d21b891..d43dc83 100644 > > --- a/include/scsi/scsi_eh.h > > +++ b/include/scsi/scsi_eh.h > > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > > > void *buffer; > > unsigned bufflen; > > + struct sg_table sg_table; > > unsigned short use_sg; > > int resid; > > > > > Ok this is not in Linus tree is it? Hence I did not have that failure. Yes it is, it's in current -git! James, comments on the patch? Will you push it or shall I? -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129200311.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129200311.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 20:04 ` James Bottomley 2008-01-29 20:06 ` Jens Axboe 0 siblings, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 20:04 UTC (permalink / raw) To: Jens Axboe Cc: Boaz Harrosh, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, 2008-01-29 at 21:03 +0100, Jens Axboe wrote: > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > On Tue, Jan 29 2008 at 21:45 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > >> On Tue, Jan 29 2008, James Bottomley wrote: > > >>> On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > >>>> On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > >>>>> On Tue, Jan 29 2008, Jens Axboe wrote: > > >>>>>> On Tue, Jan 29 2008, Oliver Neukum wrote: > > >>>>>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > >>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > > >>>>>>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > >>>>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > > >>>>>>>>>>> Greg KH wrote: > > >>>>>>> > > >>>>>>>>>> No difference, still just a lot of resets. > > >>>>>>>>>> > > >>>>>>>>> Where you able to figure out which usb storage transport is used? > > >>>>>>>>> > > >>>>>>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > >>>>>>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will > > >>>>>>>>> pinpoint better where to look. Let me research a bit. > > >>>>>>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > >>>>>>>> transport is 'Bulk' > > >>>>>>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > >>>>>>> That should tell the reason for the resets. > > >>>>>> Sure, I'll do that. Will post the results tonight. > > >>>>> OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > >>>>> in the device, waited 10 seconds or so and pulled it out. These are the > > >>>>> messages. > > >>>>> > > >>>>> It all looks good until the MODE_SENSE command, where it only transfers > > >>>>> 4 of 192 bytes. > > >>>> No, that's not the problem. This is the problem: > > >>>> > > >>>>> usb-storage: *** thread awakened. > > >>>>> usb-storage: Command TEST_UNIT_READY (6 bytes) > > >>>>> usb-storage: 00 00 00 00 00 00 > > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > >>>>> usb-storage: Status code 0; transferred 31/31 > > >>>>> usb-storage: -- transfer complete > > >>>>> usb-storage: Bulk command transfer result=0 > > >>>>> usb-storage: Attempting to get CSW... > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > >>>>> usb-storage: Status code 0; transferred 13/13 > > >>>>> usb-storage: -- transfer complete > > >>>>> usb-storage: Bulk status result = 0 > > >>>>> usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > >>>>> usb-storage: -- transport indicates command failure > > >>>>> usb-storage: Issuing auto-REQUEST_SENSE > > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > >>>>> usb-storage: Status code 0; transferred 31/31 > > >>>>> usb-storage: -- transfer complete > > >>>>> usb-storage: Bulk command transfer result=0 > > >>>>> usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > >>>>> usb-storage: usb_sg_init returned -22 > > >>>>> usb-storage: Bulk data transfer result 0x4 > > >>>>> usb-storage: -- auto-sense failure > > >>>>> usb-storage: storage_pre_reset > > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > >>>>> usb-storage: storage_post_reset > > >>>>> usb-storage: usb_reset_composite_device returns 0 > > >>>>> usb-storage: scsi cmd done, result=0x70000 > > >>>>> usb-storage: *** thread sleeping. > > >>>> For some reason, usb_sg_init is boned during auto-sense. > > >>> OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > >>> code ... that was also an update in 2.6.24 > > >> yeah, already found the bug - it's assuming ->request_buffer holds the > > >> sglist, oops. Preparing a fix. > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > fixes the usb bug for me. > > > > > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > > index 547e85a..12770ef 100644 > > > --- a/drivers/scsi/scsi_error.c > > > +++ b/drivers/scsi/scsi_error.c > > > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > > > ses->use_sg = scmd->use_sg; > > > ses->resid = scmd->resid; > > > ses->result = scmd->result; > > > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > > > > > if (sense_bytes) { > > > scmd->request_bufflen = min_t(unsigned, > > > SCSI_SENSE_BUFFERSIZE, sense_bytes); > > > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > > > scmd->request_bufflen); > > > - scmd->request_buffer = &ses->sense_sgl; > > > + scmd->sg_table.sgl = &ses->sense_sgl; > > > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > > > scmd->sc_data_direction = DMA_FROM_DEVICE; > > > scmd->use_sg = 1; > > > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > > > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > > > scmd->request_bufflen = ses->bufflen; > > > scmd->request_buffer = ses->buffer; > > > scmd->use_sg = ses->use_sg; > > > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > > > scmd->resid = ses->resid; > > > scmd->result = ses->result; > > > } > > > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > > > index d21b891..d43dc83 100644 > > > --- a/include/scsi/scsi_eh.h > > > +++ b/include/scsi/scsi_eh.h > > > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > > > > > void *buffer; > > > unsigned bufflen; > > > + struct sg_table sg_table; > > > unsigned short use_sg; > > > int resid; > > > > > > > > Ok this is not in Linus tree is it? Hence I did not have that failure. > > Yes it is, it's in current -git! James, comments on the patch? Will you > push it or shall I? I will ... but it will cause an explosion in the bidirectional tree again. I think the bidi updates also fix this. However, give me time to rebase and verify. James ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 20:04 ` James Bottomley @ 2008-01-29 20:06 ` Jens Axboe [not found] ` <20080129200651.GW15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 20:06 UTC (permalink / raw) To: James Bottomley Cc: Boaz Harrosh, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008, James Bottomley wrote: > On Tue, 2008-01-29 at 21:03 +0100, Jens Axboe wrote: > > On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > On Tue, Jan 29 2008 at 21:45 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > >> On Tue, Jan 29 2008, James Bottomley wrote: > > > >>> On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > >>>> On Tue, Jan 29, 2008 at 07:39:11PM +0100, Jens Axboe wrote: > > > >>>>> On Tue, Jan 29 2008, Jens Axboe wrote: > > > >>>>>> On Tue, Jan 29 2008, Oliver Neukum wrote: > > > >>>>>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: > > > >>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > >>>>>>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: > > > >>>>>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: > > > >>>>>>>>>>> Greg KH wrote: > > > >>>>>>> > > > >>>>>>>>>> No difference, still just a lot of resets. > > > >>>>>>>>>> > > > >>>>>>>>> Where you able to figure out which usb storage transport is used? > > > >>>>>>>>> > > > >>>>>>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > > > >>>>>>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will > > > >>>>>>>>> pinpoint better where to look. Let me research a bit. > > > >>>>>>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and > > > >>>>>>>> transport is 'Bulk' > > > >>>>>>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > > > >>>>>>> That should tell the reason for the resets. > > > >>>>>> Sure, I'll do that. Will post the results tonight. > > > >>>>> OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged > > > >>>>> in the device, waited 10 seconds or so and pulled it out. These are the > > > >>>>> messages. > > > >>>>> > > > >>>>> It all looks good until the MODE_SENSE command, where it only transfers > > > >>>>> 4 of 192 bytes. > > > >>>> No, that's not the problem. This is the problem: > > > >>>> > > > >>>>> usb-storage: *** thread awakened. > > > >>>>> usb-storage: Command TEST_UNIT_READY (6 bytes) > > > >>>>> usb-storage: 00 00 00 00 00 00 > > > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xd L 0 F 0 Trg 0 LUN 1 CL 6 > > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > >>>>> usb-storage: Status code 0; transferred 31/31 > > > >>>>> usb-storage: -- transfer complete > > > >>>>> usb-storage: Bulk command transfer result=0 > > > >>>>> usb-storage: Attempting to get CSW... > > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 13 bytes > > > >>>>> usb-storage: Status code 0; transferred 13/13 > > > >>>>> usb-storage: -- transfer complete > > > >>>>> usb-storage: Bulk status result = 0 > > > >>>>> usb-storage: Bulk Status S 0x53425355 T 0xd R 0 Stat 0x1 > > > >>>>> usb-storage: -- transport indicates command failure > > > >>>>> usb-storage: Issuing auto-REQUEST_SENSE > > > >>>>> usb-storage: Bulk Command S 0x43425355 T 0xe L 18 F 128 Trg 0 LUN 1 CL 6 > > > >>>>> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes > > > >>>>> usb-storage: Status code 0; transferred 31/31 > > > >>>>> usb-storage: -- transfer complete > > > >>>>> usb-storage: Bulk command transfer result=0 > > > >>>>> usb-storage: usb_stor_bulk_transfer_sglist: xfer 18 bytes, 1 entries > > > >>>>> usb-storage: usb_sg_init returned -22 > > > >>>>> usb-storage: Bulk data transfer result 0x4 > > > >>>>> usb-storage: -- auto-sense failure > > > >>>>> usb-storage: storage_pre_reset > > > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > > > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 > > > >>>>> ehci_hcd 0000:00:1d.7: port 1 high speed > > > >>>>> ehci_hcd 0000:00:1d.7: GetStatus port 1 status 001005 POWER sig=se0 PE CONNECT > > > >>>>> usb-storage: storage_post_reset > > > >>>>> usb-storage: usb_reset_composite_device returns 0 > > > >>>>> usb-storage: scsi cmd done, result=0x70000 > > > >>>>> usb-storage: *** thread sleeping. > > > >>>> For some reason, usb_sg_init is boned during auto-sense. > > > >>> OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > >>> code ... that was also an update in 2.6.24 > > > >> yeah, already found the bug - it's assuming ->request_buffer holds the > > > >> sglist, oops. Preparing a fix. > > > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > > fixes the usb bug for me. > > > > > > > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > > > index 547e85a..12770ef 100644 > > > > --- a/drivers/scsi/scsi_error.c > > > > +++ b/drivers/scsi/scsi_error.c > > > > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > > > > ses->use_sg = scmd->use_sg; > > > > ses->resid = scmd->resid; > > > > ses->result = scmd->result; > > > > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > > > > > > > if (sense_bytes) { > > > > scmd->request_bufflen = min_t(unsigned, > > > > SCSI_SENSE_BUFFERSIZE, sense_bytes); > > > > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > > > > scmd->request_bufflen); > > > > - scmd->request_buffer = &ses->sense_sgl; > > > > + scmd->sg_table.sgl = &ses->sense_sgl; > > > > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > > > > scmd->sc_data_direction = DMA_FROM_DEVICE; > > > > scmd->use_sg = 1; > > > > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > > > > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > > > > scmd->request_bufflen = ses->bufflen; > > > > scmd->request_buffer = ses->buffer; > > > > scmd->use_sg = ses->use_sg; > > > > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > > > > scmd->resid = ses->resid; > > > > scmd->result = ses->result; > > > > } > > > > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > > > > index d21b891..d43dc83 100644 > > > > --- a/include/scsi/scsi_eh.h > > > > +++ b/include/scsi/scsi_eh.h > > > > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > > > > > > > void *buffer; > > > > unsigned bufflen; > > > > + struct sg_table sg_table; > > > > unsigned short use_sg; > > > > int resid; > > > > > > > > > > > Ok this is not in Linus tree is it? Hence I did not have that failure. > > > > Yes it is, it's in current -git! James, comments on the patch? Will you > > push it or shall I? > > I will ... but it will cause an explosion in the bidirectional tree > again. I think the bidi updates also fix this. However, give me time > to rebase and verify. OK thanks, just wanted to make sure that we didn't both expect each other to handle it :-) -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129200651.GW15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129200651.GW15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 20:24 ` James Bottomley 2008-01-29 20:53 ` Boaz Harrosh 0 siblings, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 20:24 UTC (permalink / raw) To: Jens Axboe Cc: Boaz Harrosh, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, 2008-01-29 at 21:06 +0100, Jens Axboe wrote: > > I will ... but it will cause an explosion in the bidirectional tree > > again. I think the bidi updates also fix this. However, give me time > > to rebase and verify. > > OK thanks, just wanted to make sure that we didn't both expect each > other to handle it :-) Yes, confirm that; I think this is already fixed in scsi-misc-2.6. Could you pull from master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git and verify with your device? Thanks, James ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 20:24 ` James Bottomley @ 2008-01-29 20:53 ` Boaz Harrosh 0 siblings, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 20:53 UTC (permalink / raw) To: James Bottomley Cc: Jens Axboe, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008 at 22:24 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > On Tue, 2008-01-29 at 21:06 +0100, Jens Axboe wrote: >>> I will ... but it will cause an explosion in the bidirectional tree >>> again. I think the bidi updates also fix this. However, give me time >>> to rebase and verify. >> OK thanks, just wanted to make sure that we didn't both expect each >> other to handle it :-) > > Yes, confirm that; I think this is already fixed in scsi-misc-2.6. > Could you pull from > > master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git > > and verify with your device? > > Thanks, > > James > > I still don't see these changes, I wanted to check, make sure... Are there mirrors on the way to here? James I would like to remind you that one small piece is missing from the bidi tree, as I saw it from here, it's the few patches from scsi-pending. Mainly arm will break which is a grate loss. I'm going home now, I'll review all the patches tomorrow and compare to what I have, to make sure nothing was forgotten. What a waste of a day I pulled from Linus this morning apparently minutes before the merge, and chased a none existent bug in my tree. Sigh Bye Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F856C.4090900-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 2008-01-29 20:03 ` Jens Axboe @ 2008-01-29 20:09 ` Boaz Harrosh [not found] ` <479F880F.20709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 1 sibling, 1 reply; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 20:09 UTC (permalink / raw) To: Jens Axboe Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA >> > Ok this is not in Linus tree is it? Hence I did not have that failure. > > Boaz > > actually James bidi tree has a fix for this in the scsi_data_buffer patch. what you sent is not enough there are other places. look at this patch I sent to the list. http://www.spinics.net/lists/linux-scsi/msg21938.html Could we take the 2 SG patches and submit them through the scsi bidi tree? It is much more natural to have them in one tree as one patchset then try coordinate with git-merge. Actually if you look at it, the biggest change is to SCSI. So I think it is more natural this way Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F880F.20709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F880F.20709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 20:13 ` Jens Axboe [not found] ` <20080129201328.GZ15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-29 20:13 UTC (permalink / raw) To: Boaz Harrosh Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008, Boaz Harrosh wrote: > >> > > Ok this is not in Linus tree is it? Hence I did not have that failure. > > > > Boaz > > > > > > actually James bidi tree has a fix for this in the scsi_data_buffer patch. > > what you sent is not enough there are other places. look at this patch I > sent to the list. > > http://www.spinics.net/lists/linux-scsi/msg21938.html Hard to compare, since its on different bases. > Could we take the 2 SG patches and submit them through the scsi > bidi tree? It is much more natural to have them in one tree as one > patchset then try coordinate with git-merge. Actually if you look at it, > the biggest change is to SCSI. So I think it is more natural this way What 2 sg patches do you mean? -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080129201328.GZ15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129201328.GZ15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-29 20:26 ` Boaz Harrosh 0 siblings, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 20:26 UTC (permalink / raw) To: Jens Axboe Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 22:13 +0200, Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > On Tue, Jan 29 2008, Boaz Harrosh wrote: >>> Ok this is not in Linus tree is it? Hence I did not have that failure. >>> >>> Boaz >>> >>> >> actually James bidi tree has a fix for this in the scsi_data_buffer patch. >> >> what you sent is not enough there are other places. look at this patch I >> sent to the list. >> >> http://www.spinics.net/lists/linux-scsi/msg21938.html > > Hard to compare, since its on different bases. Yes in this patchset I have taken your sg branch at the time, and rebased it ontop of scsi_data_buffer patch. Because I felt that it is more natural for this patch to come after the scsi total cleanup that is scsi_data_buffer. Then the extraction to sg_table is simple and trivial. What I meant to point out with this patch is that all the exact same places that are touched there should be fixed when moving to sg_table. Look at it. It is a revised version of your patch. > >> Could we take the 2 SG patches and submit them through the scsi >> bidi tree? It is much more natural to have them in one tree as one >> patchset then try coordinate with git-merge. Actually if you look at it, >> the biggest change is to SCSI. So I think it is more natural this way > > What 2 sg patches do you mean? > I mean the patches that where in sg branch of the linux-block tree, But I see that it is now to late, and that they are in Linus already James the most simple is to submit the scsi_data_buff patch that fixes all these places. If not do you want that I send in fixes? Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080129194543.GR15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 2008-01-29 19:58 ` Boaz Harrosh @ 2008-01-30 10:27 ` Geert Uytterhoeven [not found] ` <Pine.LNX.4.64.0801301125350.26562-DVqXPGhgXSn9uFGNBm7GzQ@public.gmane.org> 1 sibling, 1 reply; 44+ messages in thread From: Geert Uytterhoeven @ 2008-01-30 10:27 UTC (permalink / raw) To: Jens Axboe Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: TEXT/PLAIN, Size: 2991 bytes --] On Tue, 29 Jan 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Jens Axboe wrote: > > On Tue, Jan 29 2008, James Bottomley wrote: > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > code ... that was also an update in 2.6.24 > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > sglist, oops. Preparing a fix. > > ok here goes, this saves and restores the sg table correctly. it also > fixes the usb bug for me. I can confirm this patch fixes the errors I was seeing with current linux-2.6.git for the USB memory card readers in a Dell TFT connected to a PS3. > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index 547e85a..12770ef 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > ses->use_sg = scmd->use_sg; > ses->resid = scmd->resid; > ses->result = scmd->result; > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > if (sense_bytes) { > scmd->request_bufflen = min_t(unsigned, > SCSI_SENSE_BUFFERSIZE, sense_bytes); > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > scmd->request_bufflen); > - scmd->request_buffer = &ses->sense_sgl; > + scmd->sg_table.sgl = &ses->sense_sgl; > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > scmd->sc_data_direction = DMA_FROM_DEVICE; > scmd->use_sg = 1; > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > scmd->request_bufflen = ses->bufflen; > scmd->request_buffer = ses->buffer; > scmd->use_sg = ses->use_sg; > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > scmd->resid = ses->resid; > scmd->result = ses->result; > } > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > index d21b891..d43dc83 100644 > --- a/include/scsi/scsi_eh.h > +++ b/include/scsi/scsi_eh.h > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > void *buffer; > unsigned bufflen; > + struct sg_table sg_table; > unsigned short use_sg; > int resid; > With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven-osDt5Q4Chk1BDgjK7y7TUQ@public.gmane.org Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <Pine.LNX.4.64.0801301125350.26562-DVqXPGhgXSn9uFGNBm7GzQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <Pine.LNX.4.64.0801301125350.26562-DVqXPGhgXSn9uFGNBm7GzQ@public.gmane.org> @ 2008-01-30 10:38 ` Jens Axboe 2008-01-30 14:38 ` James Bottomley 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-30 10:38 UTC (permalink / raw) To: Geert Uytterhoeven Cc: James Bottomley, Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Wed, Jan 30 2008, Geert Uytterhoeven wrote: > On Tue, 29 Jan 2008, Jens Axboe wrote: > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > On Tue, Jan 29 2008, James Bottomley wrote: > > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > > code ... that was also an update in 2.6.24 > > > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > > sglist, oops. Preparing a fix. > > > > ok here goes, this saves and restores the sg table correctly. it also > > fixes the usb bug for me. > > I can confirm this patch fixes the errors I was seeing with current > linux-2.6.git for the USB memory card readers in a Dell TFT connected > to a PS3. James, we need a fix for this pushed asap. So either we should merge the below now, or push the bidi patchset that also fixes this. It all depends on when you want to merge the bidi patches... > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > index 547e85a..12770ef 100644 > > --- a/drivers/scsi/scsi_error.c > > +++ b/drivers/scsi/scsi_error.c > > @@ -622,13 +622,15 @@ void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd, struct scsi_eh_save *ses, > > ses->use_sg = scmd->use_sg; > > ses->resid = scmd->resid; > > ses->result = scmd->result; > > + memcpy(&ses->sense_sgl, &scmd->sg_table, sizeof(ses->sense_sgl)); > > > > if (sense_bytes) { > > scmd->request_bufflen = min_t(unsigned, > > SCSI_SENSE_BUFFERSIZE, sense_bytes); > > sg_init_one(&ses->sense_sgl, scmd->sense_buffer, > > scmd->request_bufflen); > > - scmd->request_buffer = &ses->sense_sgl; > > + scmd->sg_table.sgl = &ses->sense_sgl; > > + scmd->sg_table.nents = scmd->sg_table.orig_nents = 1; > > scmd->sc_data_direction = DMA_FROM_DEVICE; > > scmd->use_sg = 1; > > memset(scmd->cmnd, 0, sizeof(scmd->cmnd)); > > @@ -679,6 +681,7 @@ void scsi_eh_restore_cmnd(struct scsi_cmnd* scmd, struct scsi_eh_save *ses) > > scmd->request_bufflen = ses->bufflen; > > scmd->request_buffer = ses->buffer; > > scmd->use_sg = ses->use_sg; > > + memcpy(&scmd->sg_table, &ses->sg_table, sizeof(scmd->sg_table)); > > scmd->resid = ses->resid; > > scmd->result = ses->result; > > } > > diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h > > index d21b891..d43dc83 100644 > > --- a/include/scsi/scsi_eh.h > > +++ b/include/scsi/scsi_eh.h > > @@ -75,6 +75,7 @@ struct scsi_eh_save { > > > > void *buffer; > > unsigned bufflen; > > + struct sg_table sg_table; > > unsigned short use_sg; > > int resid; > > -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-30 10:38 ` Jens Axboe @ 2008-01-30 14:38 ` James Bottomley 2008-01-30 18:06 ` Jens Axboe 0 siblings, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-30 14:38 UTC (permalink / raw) To: Jens Axboe Cc: Geert Uytterhoeven, Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi On Wed, 2008-01-30 at 11:38 +0100, Jens Axboe wrote: > On Wed, Jan 30 2008, Geert Uytterhoeven wrote: > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, James Bottomley wrote: > > > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > > > code ... that was also an update in 2.6.24 > > > > > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > > > sglist, oops. Preparing a fix. > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > fixes the usb bug for me. > > > > I can confirm this patch fixes the errors I was seeing with current > > linux-2.6.git for the USB memory card readers in a Dell TFT connected > > to a PS3. > > James, we need a fix for this pushed asap. So either we should merge the > below now, or push the bidi patchset that also fixes this. It all > depends on when you want to merge the bidi patches... The SCSI patch set (including the bidirectional pieces) is waiting in scsi-misc ... just for forms sake, could you confirm that it actually fixes the problem and I'll push it. James ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-30 14:38 ` James Bottomley @ 2008-01-30 18:06 ` Jens Axboe [not found] ` <20080130180613.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Jens Axboe @ 2008-01-30 18:06 UTC (permalink / raw) To: James Bottomley Cc: Geert Uytterhoeven, Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel, linux-usb, linux-scsi On Wed, Jan 30 2008, James Bottomley wrote: > On Wed, 2008-01-30 at 11:38 +0100, Jens Axboe wrote: > > On Wed, Jan 30 2008, Geert Uytterhoeven wrote: > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > > On Tue, Jan 29 2008, James Bottomley wrote: > > > > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > > > > code ... that was also an update in 2.6.24 > > > > > > > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > > > > sglist, oops. Preparing a fix. > > > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > > fixes the usb bug for me. > > > > > > I can confirm this patch fixes the errors I was seeing with current > > > linux-2.6.git for the USB memory card readers in a Dell TFT connected > > > to a PS3. > > > > James, we need a fix for this pushed asap. So either we should merge the > > below now, or push the bidi patchset that also fixes this. It all > > depends on when you want to merge the bidi patches... > > The SCSI patch set (including the bidirectional pieces) is waiting in > scsi-misc ... just for forms sake, could you confirm that it actually > fixes the problem and I'll push it. Certainly, I'll give it a spin tonight. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <20080130180613.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <20080130180613.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> @ 2008-01-30 19:07 ` Jens Axboe 0 siblings, 0 replies; 44+ messages in thread From: Jens Axboe @ 2008-01-30 19:07 UTC (permalink / raw) To: James Bottomley Cc: Geert Uytterhoeven, Matthew Dharm, Oliver Neukum, Boaz Harrosh, Greg KH, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Wed, Jan 30 2008, Jens Axboe wrote: > On Wed, Jan 30 2008, James Bottomley wrote: > > On Wed, 2008-01-30 at 11:38 +0100, Jens Axboe wrote: > > > On Wed, Jan 30 2008, Geert Uytterhoeven wrote: > > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > On Tue, Jan 29 2008, Jens Axboe wrote: > > > > > > On Tue, Jan 29 2008, James Bottomley wrote: > > > > > > > On Tue, 2008-01-29 at 11:10 -0800, Matthew Dharm wrote: > > > > > > > > For some reason, usb_sg_init is boned during auto-sense. > > > > > > > > > > > > > > OK, that's implicating the scsi_eh_prep_cmnd() in the auto sense > > > > > > > code ... that was also an update in 2.6.24 > > > > > > > > > > > > yeah, already found the bug - it's assuming ->request_buffer holds the > > > > > > sglist, oops. Preparing a fix. > > > > > > > > > > ok here goes, this saves and restores the sg table correctly. it also > > > > > fixes the usb bug for me. > > > > > > > > I can confirm this patch fixes the errors I was seeing with current > > > > linux-2.6.git for the USB memory card readers in a Dell TFT connected > > > > to a PS3. > > > > > > James, we need a fix for this pushed asap. So either we should merge the > > > below now, or push the bidi patchset that also fixes this. It all > > > depends on when you want to merge the bidi patches... > > > > The SCSI patch set (including the bidirectional pieces) is waiting in > > scsi-misc ... just for forms sake, could you confirm that it actually > > fixes the problem and I'll push it. > > Certainly, I'll give it a spin tonight. Confirmed, pulling your scsi-misc branch into current -git makes the problem go away as well. -- Jens Axboe ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 14:31 ` Oliver Neukum [not found] ` <200801291531.39825.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> @ 2008-01-29 15:50 ` Boaz Harrosh [not found] ` <479F4B4B.2020000-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 1 sibling, 1 reply; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 15:50 UTC (permalink / raw) To: Oliver Neukum Cc: Jens Axboe, Greg KH, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008 at 16:31 +0200, Oliver Neukum <oliver@neukum.org> wrote: > Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe: >> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: >>>> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>>>> Greg KH wrote: > >>>> No difference, still just a lot of resets. >>>> >>> Where you able to figure out which usb storage transport is used? >>> >>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport() >>> functions. I'm not sure if these get stored in sysfs perhaps. This will >>> pinpoint better where to look. Let me research a bit. >> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and >> transport is 'Bulk' > > You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG > That should tell the reason for the resets. > > Regards > Oliver > - I can not see what it is. Yes CONFIG_USB_STORAGE_DEBUG will help. I have a device here that uses the same trasport/protocol I'll try to reproduce the failure here. Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F4B4B.2020000-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F4B4B.2020000-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 17:42 ` Oliver Neukum 0 siblings, 0 replies; 44+ messages in thread From: Oliver Neukum @ 2008-01-29 17:42 UTC (permalink / raw) To: Boaz Harrosh Cc: Jens Axboe, Greg KH, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA Am Dienstag, 29. Januar 2008 16:50:35 schrieb Boaz Harrosh: > On Tue, Jan 29 2008 at 16:31 +0200, Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> wrote: > I can not see what it is. Yes CONFIG_USB_STORAGE_DEBUG will help. > I have a device here that uses the same trasport/protocol I'll > try to reproduce the failure here. This is the most common combination of transport and protocol. If it were broken in a larger number of cases, we'd hear more reports. You'll probably need the debug output to figure out what's wrong. Regards Oliver ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 14:06 ` Boaz Harrosh [not found] ` <479F32E9.10609-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 14:13 ` Boaz Harrosh 1 sibling, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 14:13 UTC (permalink / raw) To: Jens Axboe; +Cc: Greg KH, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008 at 16:06 +0200, Boaz Harrosh <bharrosh@panasas.com> wrote: > On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote: >> On Tue, Jan 29 2008, Boaz Harrosh wrote: >>> Greg KH wrote: >>>> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote: >>>>> Hi, >>>>> >>>>> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and >>>>> connecting my cf usb storage device yields and endless stream of: >>>>> >>>>> Initializing USB Mass Storage driver... >>>>> scsi6 : SCSI emulation for USB Mass Storage devices >>>>> usb-storage: device found at 2 >>>>> usb-storage: waiting for device to settle before scanning >>>>> usbcore: registered new interface driver usb-storage >>>>> USB Mass Storage support registered. >>>>> scsi 6:0:0:0: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>>> ANSI: 0 >>>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>>> sd 6:0:0:0: [sdb] Write Protect is off >>>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>>> sd 6:0:0:0: [sdb] 4001760 512-byte hardware sectors (2049 MB) >>>>> sd 6:0:0:0: [sdb] Write Protect is off >>>>> sd 6:0:0:0: [sdb] Mode Sense: 02 00 00 00 >>>>> sd 6:0:0:0: [sdb] Assuming drive cache: write through >>>>> sdb: sdb1 >>>>> sd 6:0:0:0: [sdb] Attached SCSI removable disk >>>>> sd 6:0:0:0: Attached scsi generic sg1 type 0 >>>>> scsi 6:0:0:1: Direct-Access Generic STORAGE DEVICE 0125 PQ: 0 >>>>> ANSI: 0 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> usb 5-1: reset high speed USB device using ehci_hcd and address 2 >>>>> [...] >>>>> >>>>> until I disconnect it. The device doesn't work. Worked fine in 2.6.24. >>>>> I'm attaching boot messages and my .config. >>>> That's a bit wierd, as we haven't added any USB patches to the -git tree >>>> yet after 2.6.24 :) >>>> >>>> Could this be caused by some scsi changes perhaps? >>>> >>>> thanks, >>>> >>>> greg k-h >>>> - >>> Yes it is ;) >>> >>> Jens could you test the patch below? if it works I'll submit a proper >>> patch. Please forgive me for the bug. >> No difference, still just a lot of resets. >> > Where you able to figure out which usb storage transport is used? > > in drivers/usb/storage/usb.c you have get_protocol() and get_transport() > functions. I'm not sure if these get stored in sysfs perhaps. This will > pinpoint better where to look. Let me research a bit. > >From inspection of code it should be in /proc/scsi somewhere look for: SPRINTF(" Protocol: %s\n", us->protocol_name); SPRINTF(" Transport: %s\n", us->transport_name); (it's proc_info() in drivers/usb/storage/scsiglue.c) Thanks Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 2008-01-29 13:54 ` Jens Axboe @ 2008-01-29 15:36 ` Alan Stern [not found] ` <Pine.LNX.4.44L0.0801291032210.4229-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> 2008-01-29 16:34 ` James Bottomley 1 sibling, 2 replies; 44+ messages in thread From: Alan Stern @ 2008-01-29 15:36 UTC (permalink / raw) To: Boaz Harrosh Cc: Greg KH, Jens Axboe, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, 29 Jan 2008, Boaz Harrosh wrote: > --- a/drivers/usb/storage/transport.c > +++ b/drivers/usb/storage/transport.c > @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, > * Common used function. Transfer a complete command > * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid > */ > -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > - struct scsi_cmnd* srb) > +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, > + struct scsi_cmnd* srb, unsigned length) > { > unsigned int partial; > int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), > - scsi_sg_count(srb), scsi_bufflen(srb), > + scsi_sg_count(srb), length, > &partial); > > scsi_set_resid(srb, scsi_bufflen(srb) - partial); > return result; > } > > +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > + struct scsi_cmnd* srb) > +{ > + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); > +} > + I don't like this patch very much. Why add another layer of indirection when the two subroutines do hardly any work? Leave usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() as a separate routine that simply calls usb_stor_bulk_transfer_sglist() and scsi_set_resid(). BTW, the standard coding style calls for a blank line after the list of local variables at the start of a function or block. Alan Stern ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <Pine.LNX.4.44L0.0801291032210.4229-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <Pine.LNX.4.44L0.0801291032210.4229-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> @ 2008-01-29 15:54 ` Boaz Harrosh 0 siblings, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 15:54 UTC (permalink / raw) To: Alan Stern Cc: Greg KH, Jens Axboe, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 17:36 +0200, Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> wrote: > On Tue, 29 Jan 2008, Boaz Harrosh wrote: > >> --- a/drivers/usb/storage/transport.c >> +++ b/drivers/usb/storage/transport.c >> @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, >> * Common used function. Transfer a complete command >> * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid >> */ >> -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >> - struct scsi_cmnd* srb) >> +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, >> + struct scsi_cmnd* srb, unsigned length) >> { >> unsigned int partial; >> int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), >> - scsi_sg_count(srb), scsi_bufflen(srb), >> + scsi_sg_count(srb), length, >> &partial); >> >> scsi_set_resid(srb, scsi_bufflen(srb) - partial); >> return result; >> } >> >> +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >> + struct scsi_cmnd* srb) >> +{ >> + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); >> +} >> + > > I don't like this patch very much. Why add another layer of > indirection when the two subroutines do hardly any work? Leave > usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() > as a separate routine that simply calls usb_stor_bulk_transfer_sglist() > and scsi_set_resid(). > > BTW, the standard coding style calls for a blank line after the list of > local variables at the start of a function or block. > > Alan Stern > > - Me neither, it's not a proper patch just a shut to try and find the reported bug. I will submit a proper bug later. Thanks for the review, you are right on all accounts Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 15:36 ` Alan Stern [not found] ` <Pine.LNX.4.44L0.0801291032210.4229-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> @ 2008-01-29 16:34 ` James Bottomley 2008-01-29 18:27 ` Boaz Harrosh 1 sibling, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 16:34 UTC (permalink / raw) To: Alan Stern Cc: Boaz Harrosh, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, 2008-01-29 at 10:36 -0500, Alan Stern wrote: > On Tue, 29 Jan 2008, Boaz Harrosh wrote: > > > --- a/drivers/usb/storage/transport.c > > +++ b/drivers/usb/storage/transport.c > > @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, > > * Common used function. Transfer a complete command > > * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid > > */ > > -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > > - struct scsi_cmnd* srb) > > +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, > > + struct scsi_cmnd* srb, unsigned length) > > { > > unsigned int partial; > > int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), > > - scsi_sg_count(srb), scsi_bufflen(srb), > > + scsi_sg_count(srb), length, > > &partial); > > > > scsi_set_resid(srb, scsi_bufflen(srb) - partial); > > return result; > > } > > > > +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > > + struct scsi_cmnd* srb) > > +{ > > + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); > > +} > > + > > I don't like this patch very much. Why add another layer of > indirection when the two subroutines do hardly any work? Leave > usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() > as a separate routine that simply calls usb_stor_bulk_transfer_sglist() > and scsi_set_resid(). > > BTW, the standard coding style calls for a blank line after the list of > local variables at the start of a function or block. There's another bug in the transport.c conversion in that the residuals are updated with bogus data in several error cases, since usb_stor_bulk_transfer_sglist() only sets the actual length if the urb is actually sent. I'm not sure if this is is the solution to the problem at hand, but it definitely fixes another bug in the code. James diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c index d9f4912..bab0858 100644 --- a/drivers/usb/storage/transport.c +++ b/drivers/usb/storage/transport.c @@ -465,7 +465,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, struct scsi_cmnd* srb) { - unsigned int partial; + unsigned int partial = scsi_get_resid(srb); int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), scsi_sg_count(srb), scsi_bufflen(srb), &partial); ^ permalink raw reply related [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 16:34 ` James Bottomley @ 2008-01-29 18:27 ` Boaz Harrosh [not found] ` <479F7009.3020306-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 18:27 UTC (permalink / raw) To: James Bottomley Cc: Alan Stern, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008 at 18:34 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > On Tue, 2008-01-29 at 10:36 -0500, Alan Stern wrote: >> On Tue, 29 Jan 2008, Boaz Harrosh wrote: >> >>> --- a/drivers/usb/storage/transport.c >>> +++ b/drivers/usb/storage/transport.c >>> @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, >>> * Common used function. Transfer a complete command >>> * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid >>> */ >>> -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >>> - struct scsi_cmnd* srb) >>> +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, >>> + struct scsi_cmnd* srb, unsigned length) >>> { >>> unsigned int partial; >>> int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), >>> - scsi_sg_count(srb), scsi_bufflen(srb), >>> + scsi_sg_count(srb), length, >>> &partial); >>> >>> scsi_set_resid(srb, scsi_bufflen(srb) - partial); >>> return result; >>> } >>> >>> +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >>> + struct scsi_cmnd* srb) >>> +{ >>> + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); >>> +} >>> + >> I don't like this patch very much. Why add another layer of >> indirection when the two subroutines do hardly any work? Leave >> usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() >> as a separate routine that simply calls usb_stor_bulk_transfer_sglist() >> and scsi_set_resid(). >> >> BTW, the standard coding style calls for a blank line after the list of >> local variables at the start of a function or block. > > There's another bug in the transport.c conversion in that the residuals > are updated with bogus data in several error cases, since > usb_stor_bulk_transfer_sglist() only sets the actual length if the urb > is actually sent. > > I'm not sure if this is is the solution to the problem at hand, but it > definitely fixes another bug in the code. > > James > > diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c > index d9f4912..bab0858 100644 > --- a/drivers/usb/storage/transport.c > +++ b/drivers/usb/storage/transport.c > @@ -465,7 +465,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, > int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > struct scsi_cmnd* srb) > { > - unsigned int partial; > + unsigned int partial = scsi_get_resid(srb); > int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), > scsi_sg_count(srb), scsi_bufflen(srb), > &partial); > > > - But then this is weird because it is not what usb_stor_bulk_transfer_sg() is doing which was the one called before. I have such a device and I get one reset but then every thing works nice. This is with debug on. I'll try to make it fail. Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F7009.3020306-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F7009.3020306-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 18:48 ` James Bottomley 2008-01-29 18:58 ` Boaz Harrosh 0 siblings, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 18:48 UTC (permalink / raw) To: Boaz Harrosh Cc: Alan Stern, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, 2008-01-29 at 20:27 +0200, Boaz Harrosh wrote: > On Tue, Jan 29 2008 at 18:34 +0200, James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > > On Tue, 2008-01-29 at 10:36 -0500, Alan Stern wrote: > >> On Tue, 29 Jan 2008, Boaz Harrosh wrote: > >> > >>> --- a/drivers/usb/storage/transport.c > >>> +++ b/drivers/usb/storage/transport.c > >>> @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, > >>> * Common used function. Transfer a complete command > >>> * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid > >>> */ > >>> -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > >>> - struct scsi_cmnd* srb) > >>> +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, > >>> + struct scsi_cmnd* srb, unsigned length) > >>> { > >>> unsigned int partial; > >>> int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), > >>> - scsi_sg_count(srb), scsi_bufflen(srb), > >>> + scsi_sg_count(srb), length, > >>> &partial); > >>> > >>> scsi_set_resid(srb, scsi_bufflen(srb) - partial); > >>> return result; > >>> } > >>> > >>> +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > >>> + struct scsi_cmnd* srb) > >>> +{ > >>> + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); > >>> +} > >>> + > >> I don't like this patch very much. Why add another layer of > >> indirection when the two subroutines do hardly any work? Leave > >> usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() > >> as a separate routine that simply calls usb_stor_bulk_transfer_sglist() > >> and scsi_set_resid(). > >> > >> BTW, the standard coding style calls for a blank line after the list of > >> local variables at the start of a function or block. > > > > There's another bug in the transport.c conversion in that the residuals > > are updated with bogus data in several error cases, since > > usb_stor_bulk_transfer_sglist() only sets the actual length if the urb > > is actually sent. > > > > I'm not sure if this is is the solution to the problem at hand, but it > > definitely fixes another bug in the code. > > > > James > > > > diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c > > index d9f4912..bab0858 100644 > > --- a/drivers/usb/storage/transport.c > > +++ b/drivers/usb/storage/transport.c > > @@ -465,7 +465,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, > > int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, > > struct scsi_cmnd* srb) > > { > > - unsigned int partial; > > + unsigned int partial = scsi_get_resid(srb); > > int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), > > scsi_sg_count(srb), scsi_bufflen(srb), > > &partial); > > > > > > - > But then this is weird because it is not what usb_stor_bulk_transfer_sg() is doing > which was the one called before. Um, yes it was. The original code did this sb_stor_bulk_transfer_sg(..., &srp->resid, ...) Which was at liberty not to touch resid, which it chose not to do in the error legs. Your new code does int partial; <- stack uninitialised sb_stor_bulk_transfer_sglist(..., &partial, ...); scsi_set_resid(srb, scsi_bufflen(srb) - partial); If the function doesn't touch partial, as it doesn't in the error legs, resid now gets set with rubbish. Actually, my code is still wrong .. we have to set it to scsi_bufflen(srb) - scsi_resid(srb) so that it comes back the same if left untouched. > I have such a device and I get one reset but then every thing works nice. > This is with debug on. I'll try to make it fail. James ^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [BUG] 2.6.24-git usb reset problems 2008-01-29 18:48 ` James Bottomley @ 2008-01-29 18:58 ` Boaz Harrosh [not found] ` <479F774B.60303-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 18:58 UTC (permalink / raw) To: James Bottomley Cc: Alan Stern, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel, linux-usb, linux-scsi On Tue, Jan 29 2008 at 20:48 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > On Tue, 2008-01-29 at 20:27 +0200, Boaz Harrosh wrote: >> On Tue, Jan 29 2008 at 18:34 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote: >>> On Tue, 2008-01-29 at 10:36 -0500, Alan Stern wrote: >>>> On Tue, 29 Jan 2008, Boaz Harrosh wrote: >>>> >>>>> --- a/drivers/usb/storage/transport.c >>>>> +++ b/drivers/usb/storage/transport.c >>>>> @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, >>>>> * Common used function. Transfer a complete command >>>>> * via usb_stor_bulk_transfer_sglist() above. Set cmnd resid >>>>> */ >>>>> -int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >>>>> - struct scsi_cmnd* srb) >>>>> +int usb_stor_bulk_srb_length(struct us_data* us, unsigned int pipe, >>>>> + struct scsi_cmnd* srb, unsigned length) >>>>> { >>>>> unsigned int partial; >>>>> int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), >>>>> - scsi_sg_count(srb), scsi_bufflen(srb), >>>>> + scsi_sg_count(srb), length, >>>>> &partial); >>>>> >>>>> scsi_set_resid(srb, scsi_bufflen(srb) - partial); >>>>> return result; >>>>> } >>>>> >>>>> +int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >>>>> + struct scsi_cmnd* srb) >>>>> +{ >>>>> + return usb_stor_bulk_srb_length(us, pipe, srb, scsi_bufflen(srb)); >>>>> +} >>>>> + >>>> I don't like this patch very much. Why add another layer of >>>> indirection when the two subroutines do hardly any work? Leave >>>> usb_stor_bulk_srb() the way it was, and add usb_stor_bulk_srb_length() >>>> as a separate routine that simply calls usb_stor_bulk_transfer_sglist() >>>> and scsi_set_resid(). >>>> >>>> BTW, the standard coding style calls for a blank line after the list of >>>> local variables at the start of a function or block. >>> There's another bug in the transport.c conversion in that the residuals >>> are updated with bogus data in several error cases, since >>> usb_stor_bulk_transfer_sglist() only sets the actual length if the urb >>> is actually sent. >>> >>> I'm not sure if this is is the solution to the problem at hand, but it >>> definitely fixes another bug in the code. >>> >>> James >>> >>> diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c >>> index d9f4912..bab0858 100644 >>> --- a/drivers/usb/storage/transport.c >>> +++ b/drivers/usb/storage/transport.c >>> @@ -465,7 +465,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, >>> int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, >>> struct scsi_cmnd* srb) >>> { >>> - unsigned int partial; >>> + unsigned int partial = scsi_get_resid(srb); >>> int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), >>> scsi_sg_count(srb), scsi_bufflen(srb), >>> &partial); >>> >>> >>> - >> But then this is weird because it is not what usb_stor_bulk_transfer_sg() is doing >> which was the one called before. > > Um, yes it was. The original code did this > > sb_stor_bulk_transfer_sg(..., &srp->resid, ...) > > Which was at liberty not to touch resid, which it chose not to do in the > error legs. > > Your new code does > > int partial; <- stack uninitialised > sb_stor_bulk_transfer_sglist(..., &partial, ...); > scsi_set_resid(srb, scsi_bufflen(srb) - partial); > > If the function doesn't touch partial, as it doesn't in the error legs, > resid now gets set with rubbish. > > Actually, my code is still wrong .. we have to set it to > scsi_bufflen(srb) - scsi_resid(srb) so that it comes back the same if > left untouched. > >> I have such a device and I get one reset but then every thing works nice. >> This is with debug on. I'll try to make it fail. > > James > > Sorry I still don't see it. original code did sb_stor_bulk_transfer_sg(..., &srp->resid, ...) but sb_stor_bulk_transfer_sg does the: int partial; <- stack uninitialised sb_stor_bulk_transfer_sglist(..., &partial, ...); and then unconditionally sets *residual = length_left; I do not see an "error legs" case in sb_stor_bulk_transfer_sg(). I have just cut and pasted the !use_sg from sb_stor_bulk_transfer_sg names and all Boaz ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <479F774B.60303-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <479F774B.60303-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> @ 2008-01-29 19:17 ` James Bottomley [not found] ` <1201634240.3069.33.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 0 siblings, 1 reply; 44+ messages in thread From: James Bottomley @ 2008-01-29 19:17 UTC (permalink / raw) To: Boaz Harrosh Cc: Alan Stern, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, 2008-01-29 at 20:58 +0200, Boaz Harrosh wrote: > > Your new code does > > > > int partial; <- stack uninitialised > > sb_stor_bulk_transfer_sglist(..., &partial, ...); > > scsi_set_resid(srb, scsi_bufflen(srb) - partial); > > > > If the function doesn't touch partial, as it doesn't in the error legs, > > resid now gets set with rubbish. > > > > Actually, my code is still wrong .. we have to set it to > > scsi_bufflen(srb) - scsi_resid(srb) so that it comes back the same if > > left untouched. > > > >> I have such a device and I get one reset but then every thing works nice. > >> This is with debug on. I'll try to make it fail. > > > > James > > > > > Sorry I still don't see it. > > original code did sb_stor_bulk_transfer_sg(..., &srp->resid, ...) > > but sb_stor_bulk_transfer_sg does the: > int partial; <- stack uninitialised > sb_stor_bulk_transfer_sglist(..., &partial, ...); > > and then unconditionally sets *residual = length_left; > I do not see an "error legs" case in sb_stor_bulk_transfer_sg(). This is really programming 101. This: static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, struct scatterlist *sg, int num_sg, unsigned int length, unsigned int *act_len) { int result; /* don't submit s-g requests during abort/disconnect processing */ if (us->flags & ABORTING_OR_DISCONNECTING) return USB_STOR_XFER_ERROR; The return USB_STOR_XFER_ERROR; is called an error leg. It returns without updating *act_len thus leaving &partial uninitialised. James ^ permalink raw reply [flat|nested] 44+ messages in thread
[parent not found: <1201634240.3069.33.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [BUG] 2.6.24-git usb reset problems [not found] ` <1201634240.3069.33.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2008-01-29 19:28 ` Boaz Harrosh 0 siblings, 0 replies; 44+ messages in thread From: Boaz Harrosh @ 2008-01-29 19:28 UTC (permalink / raw) To: James Bottomley Cc: Alan Stern, Greg KH, Jens Axboe, Matthew Dharm, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-scsi-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 29 2008 at 21:17 +0200, James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> wrote: > On Tue, 2008-01-29 at 20:58 +0200, Boaz Harrosh wrote: >>> Your new code does >>> >>> int partial; <- stack uninitialised >>> sb_stor_bulk_transfer_sglist(..., &partial, ...); >>> scsi_set_resid(srb, scsi_bufflen(srb) - partial); >>> >>> If the function doesn't touch partial, as it doesn't in the error legs, >>> resid now gets set with rubbish. >>> >>> Actually, my code is still wrong .. we have to set it to >>> scsi_bufflen(srb) - scsi_resid(srb) so that it comes back the same if >>> left untouched. >>> >>>> I have such a device and I get one reset but then every thing works nice. >>>> This is with debug on. I'll try to make it fail. >>> James >>> >>> >> Sorry I still don't see it. >> >> original code did sb_stor_bulk_transfer_sg(..., &srp->resid, ...) >> >> but sb_stor_bulk_transfer_sg does the: >> int partial; <- stack uninitialised >> sb_stor_bulk_transfer_sglist(..., &partial, ...); >> >> and then unconditionally sets *residual = length_left; >> I do not see an "error legs" case in sb_stor_bulk_transfer_sg(). > > This is really programming 101. This: > > static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned > int pipe, > struct scatterlist *sg, int num_sg, unsigned int length, > unsigned int *act_len) > { > int result; > > /* don't submit s-g requests during abort/disconnect processing */ > if (us->flags & ABORTING_OR_DISCONNECTING) > return USB_STOR_XFER_ERROR; > > The return USB_STOR_XFER_ERROR; is called an error leg. It returns > without updating *act_len thus leaving &partial uninitialised. > > James > Yes you are right this is a bug, but it is a bug that was there before. perhaps the stack is just different now then what it used to be. Jens could you please try that: diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c index d9f4912..b18a5e6 100644 --- a/drivers/usb/storage/transport.c +++ b/drivers/usb/storage/transport.c @@ -465,7 +465,7 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe, int usb_stor_bulk_srb(struct us_data* us, unsigned int pipe, struct scsi_cmnd* srb) { - unsigned int partial; + unsigned int partial = 0; int result = usb_stor_bulk_transfer_sglist(us, pipe, scsi_sglist(srb), scsi_sg_count(srb), scsi_bufflen(srb), &partial); ^ permalink raw reply related [flat|nested] 44+ messages in thread
end of thread, other threads:[~2008-01-30 19:07 UTC | newest]
Thread overview: 44+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080128204935.GI15220@kernel.dk>
2008-01-28 21:21 ` [BUG] 2.6.24-git usb reset problems Greg KH
2008-01-29 7:48 ` Jens Axboe
2008-01-29 12:15 ` Boaz Harrosh
2008-01-29 15:00 ` Matthew Dharm
[not found] ` <479F18D3.9030709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 13:54 ` Jens Axboe
[not found] ` <20080129135443.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 14:06 ` Boaz Harrosh
[not found] ` <479F32E9.10609-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 14:11 ` Jens Axboe
[not found] ` <20080129141108.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 14:14 ` Boaz Harrosh
2008-01-29 14:31 ` Oliver Neukum
[not found] ` <200801291531.39825.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-01-29 14:31 ` Jens Axboe
2008-01-29 18:39 ` Jens Axboe
[not found] ` <20080129183910.GI15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 19:09 ` Boaz Harrosh
2008-01-29 19:10 ` Matthew Dharm
[not found] ` <20080129191024.GO14375-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>
2008-01-29 19:15 ` Jens Axboe
[not found] ` <20080129191504.GO15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 19:26 ` Jens Axboe
2008-01-29 19:37 ` Matthew Dharm
2008-01-29 19:33 ` James Bottomley
2008-01-29 19:35 ` Jens Axboe
2008-01-29 19:45 ` Jens Axboe
[not found] ` <20080129194543.GR15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 19:58 ` Boaz Harrosh
[not found] ` <479F856C.4090900-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 20:03 ` Jens Axboe
[not found] ` <20080129200311.GV15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 20:04 ` James Bottomley
2008-01-29 20:06 ` Jens Axboe
[not found] ` <20080129200651.GW15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 20:24 ` James Bottomley
2008-01-29 20:53 ` Boaz Harrosh
2008-01-29 20:09 ` Boaz Harrosh
[not found] ` <479F880F.20709-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 20:13 ` Jens Axboe
[not found] ` <20080129201328.GZ15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-29 20:26 ` Boaz Harrosh
2008-01-30 10:27 ` Geert Uytterhoeven
[not found] ` <Pine.LNX.4.64.0801301125350.26562-DVqXPGhgXSn9uFGNBm7GzQ@public.gmane.org>
2008-01-30 10:38 ` Jens Axboe
2008-01-30 14:38 ` James Bottomley
2008-01-30 18:06 ` Jens Axboe
[not found] ` <20080130180613.GU15220-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-01-30 19:07 ` Jens Axboe
2008-01-29 15:50 ` Boaz Harrosh
[not found] ` <479F4B4B.2020000-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 17:42 ` Oliver Neukum
2008-01-29 14:13 ` Boaz Harrosh
2008-01-29 15:36 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0801291032210.4229-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-01-29 15:54 ` Boaz Harrosh
2008-01-29 16:34 ` James Bottomley
2008-01-29 18:27 ` Boaz Harrosh
[not found] ` <479F7009.3020306-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 18:48 ` James Bottomley
2008-01-29 18:58 ` Boaz Harrosh
[not found] ` <479F774B.60303-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2008-01-29 19:17 ` James Bottomley
[not found] ` <1201634240.3069.33.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-01-29 19:28 ` Boaz Harrosh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).