From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: aic7xxx build failure
Date: Tue, 5 Feb 2008 21:06:23 +0100 [thread overview]
Message-ID: <20080205200623.GA26798@uranus.ravnborg.org> (raw)
In-Reply-To: <20080205184735.GA26270@uranus.ravnborg.org>
On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote:
> On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote:
> > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx
> > compilation:
> >
> > <-- snip -->
> >
> > $ make O=../out/x86-full
> > ...
> > SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h
> > SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h
> > CC drivers/scsi/aic7xxx/aic79xx_core.o
> > gcc: drivers/scsi/aic7xxx/aic79xx_core.c: No such file or directory
> > gcc: no input files
> > make[4]: *** [drivers/scsi/aic7xxx/aic79xx_core.o] Error 1
> >
> > <-- snip -->
> >
> > Next "make" run brings the same failure in
> > drivers/scsi/aic7xxx/aic7xxx_core.c.
> >
> > With the third "make" it works.
> >
> > It might compile for people with SMP systems using -j?
>
> I can reproduce it and will fix it.
Seems I was sidetracked by some wrong assumptions.
Could you please test this fix.
Works for me but this time I will do more testing....
Sam
diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx/Makefile
index 4c54954..6aa49e7 100644
--- a/drivers/scsi/aic7xxx/Makefile
+++ b/drivers/scsi/aic7xxx/Makefile
@@ -44,8 +44,8 @@ clean-files += aic79xx_seq.h aic79xx_reg.h aic79xx_reg_print.c
# Dependencies for generated files need to be listed explicitly
-$(addprefix $(src)/,$(aic7xxx-y:.o=.c)): $(obj)/aic7xxx_seq.h $(obj)/aic7xxx_reg.h
-$(addprefix $(src)/,$(aic79xx-y:.o=.c)): $(obj)/aic79xx_seq.h $(obj)/aic79xx_reg.h
+$(addprefix $(src)/,$(aic7xxx-y)): $(obj)/aic7xxx_seq.h $(obj)/aic7xxx_reg.h
+$(addprefix $(src)/,$(aic79xx-y)): $(obj)/aic79xx_seq.h $(obj)/aic79xx_reg.h
aic7xxx-gen-$(CONFIG_AIC7XXX_BUILD_FIRMWARE) := $(obj)/aic7xxx_reg.h
aic7xxx-gen-$(CONFIG_AIC7XXX_REG_PRETTY_PRINT) += $(obj)/aic7xxx_reg_print.c
next prev parent reply other threads:[~2008-02-05 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 17:40 aic7xxx build failure Adrian Bunk
2008-02-05 18:08 ` James Bottomley
2008-02-05 18:18 ` James Bottomley
2008-02-05 18:24 ` Adrian Bunk
2008-02-05 18:30 ` James Bottomley
2008-02-05 18:35 ` Adrian Bunk
2008-02-05 18:37 ` Arjan van de Ven
2008-02-05 18:47 ` Sam Ravnborg
2008-02-05 20:06 ` Sam Ravnborg [this message]
2008-02-05 20:27 ` James Bottomley
2008-02-05 20:56 ` Sam Ravnborg
2008-02-05 20:52 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205200623.GA26798@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox