Advansys regression between 2.6.23.8 and 2.6.24.2

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

Hi,

I just upgraded my system from 2.6.23.8 to 2.6.24.2, and when loading
the advansys module, it paniced, with "Kernel BUG at advansys.c:6335".
The issue is that the overrun buffer is not aligned on 8 bytes.

The patch 7d5d408c77cee95d1380511de46b7a4c8dc2211d [1], by FUJITA
Tomonori, which has been committed a few days ago, fixes the issue. The
commit log says that the structure should be 8-byte aligned on 2.6.23
and 2.6.24, but it doesn't seem to be the case in 2.6.24. I have not
identified which commit broke the driver, but I confirm that Tomonori's
patch fixes the problem.

I've added Greg and Chris as Cc: because such a patch should probably
be included in the next -stable of 2.6.24, but of course Tomonori and
Matthew are best placed to say what should be done.

Thanks,

Thomas

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7d5d408c77cee95d1380511de46b7a4c8dc2211d
-- 
Thomas Petazzoni, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]