From: FUJITA Tomonori <tomof@acm.org>
To: Geert.Uytterhoeven@sonycom.com
Cc: fujita.tomonori@lab.ntt.co.jp, linux-scsi@vger.kernel.org,
tomof@acm.org, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH 2/2] ps3rom: Simplify fill_from_dev_buffer()
Date: Tue, 26 Feb 2008 00:39:34 +0900 [thread overview]
Message-ID: <20080224235154E.tomof@acm.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802251423470.31208@vixen.sonytel.be>
On Mon, 25 Feb 2008 14:24:31 +0100 (CET)
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> Subject: [PATCH] ps3rom: Simplify fill_from_dev_buffer()
>
> As we no longer need to calculate the data length of the whole scatterlist,
> we can abort the loop earlier and coalesce req_len and act_len into one
> variable, making fill_from_dev_buffer() more similar to fetch_to_dev_buffer().
I'll add new APIs to copy data between a sg list and a buffer soon
after cleaning up (and fixing) some drivers on this area. I plan to
remove fill_from_dev_buffer and fetch_to_dev_buffer in ps3rom. As you
know, they are same functions that scsi_debug uses. There are other
drivers that need similar functions. I expect my ps3rom patch to be
applied to the scsi-fixes tree so I didn't change much as you did in
this patch.
next prev parent reply other threads:[~2008-02-25 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 23:25 [PATCH] ps3rom: fix wrong resid calculation bug FUJITA Tomonori
2008-02-25 13:22 ` Geert Uytterhoeven
2008-02-25 13:23 ` [PATCH 1/2] " Geert Uytterhoeven
2008-02-25 13:24 ` [PATCH 2/2] ps3rom: Simplify fill_from_dev_buffer() Geert Uytterhoeven
2008-02-25 15:39 ` FUJITA Tomonori [this message]
2008-02-25 16:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224235154E.tomof@acm.org \
--to=tomof@acm.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox