Re: [Patch] plug async scan race at 1st node scan

[Matthew Wilcox <matthew@wil.cx>]

On Sat, Mar 01, 2008 at 05:44:29AM -0600, Mike Christie wrote:
> >Possibly we should be less forgiving, and require drivers to have a
> >scan_start, otherwise they can't avoid this race.
> 
> I am hitting this problem with qla4xxx (added async scanning to 
> 2.6.25-rc). Was the final decision that we have to add a scan_start? I 
> did not see scan_start be made mandatory and I did not see James's patch 
> go in.

You can't really make it mandatory ... it's only mandatory *if* you have
a scan_finished.

The documentation should be updated though.  Possibly the function
prototype should be changed from returning void to returning int, to
allow drivers to say "Oh no, I can't start after all".

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."