Re: + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 05 Mar 2008 18:27:27 -0600
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> > 
> > diff -puN drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes drivers/scsi/ch.c
> > --- a/drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
> > +++ a/drivers/scsi/ch.c
> > @@ -739,11 +739,11 @@ static long ch_ioctl(struct file *file,
> >  		mutex_lock(&ch->lock);
> >  
> >  	voltag_retry:
> > -		memset(ch_cmd,0,sizeof(ch_cmd));
> > +		memset(ch_cmd, 0, sizeof(ch_cmd));
> >  		ch_cmd[0] = READ_ELEMENT_STATUS;
> >  		ch_cmd[1] = (ch->device->lun << 5) |
> >  			    (ch->voltags ? 0x10 : 0) |
> > -			    ch_elem_to_typecode(ch,elem);
> > +			    ch_elem_to_typecode(ch, elem);
> >  		ch_cmd[2] = (elem >> 8) & 0xff;
> >  		ch_cmd[3] = elem        & 0xff;
> >  		ch_cmd[5] = 1;
> 
> Please stop.  I'm not taking whitespace patches ... one per file no
> less.

This gets folded into the base patch - there is no incremental effect.

>  I take whitespace and other cleanups as part of real driver
> updates only.

That's what this does.