From: Greg KH <greg@kroah.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-next@vger.kernel.org, scsi <linux-scsi@vger.kernel.org>,
jejb <James.Bottomley@HansenPartnership.com>
Subject: Re: next-2008-0306 scsi/libsas build failure
Date: Thu, 6 Mar 2008 10:16:45 -0800 [thread overview]
Message-ID: <20080306181645.GA6046@kroah.com> (raw)
In-Reply-To: <20080306090904.258f92eb.randy.dunlap@oracle.com>
On Thu, Mar 06, 2008 at 09:09:04AM -0800, Randy Dunlap wrote:
> drivers/built-in.o: In function `sas_request_addr':
> (.text+0x598fb): undefined reference to `request_firmware'
> drivers/built-in.o: In function `sas_request_addr':
> (.text+0x5998e): undefined reference to `release_firmware'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
>
> drivers/scsi/libsas/sas_scsi_host.c calls request_firmware() and
> release_firmware() without checking to see if CONFIG_FW_LOADER=y.
Sounds like a bug in the firmware code, it should provide stubs if this
config option is not present, right?
thanks,
greg k-h
next prev parent reply other threads:[~2008-03-06 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 17:09 next-2008-0306 scsi/libsas build failure Randy Dunlap
2008-03-06 18:16 ` Greg KH [this message]
2008-03-06 18:22 ` Randy Dunlap
2008-03-06 21:01 ` Darrick J. Wong
2008-03-06 21:02 ` [PATCH] libsas: Check that the firmware loader is present in sas_request_addr Darrick J. Wong
2008-03-06 21:17 ` James Bottomley
2008-03-06 21:20 ` Randy Dunlap
2008-03-06 22:04 ` Randy Dunlap
2008-03-06 22:16 ` James Bottomley
2008-03-07 4:54 ` Greg KH
2008-03-07 14:57 ` [PATCH] firmware: provide stubs for the FW_LOADER=n case James Bottomley
2008-03-07 17:08 ` patch firmware-provide-stubs-for-the-fw_loader-n-case.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306181645.GA6046@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).