From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Greg KH <greg@kroah.com>,
linux-next@vger.kernel.org, scsi <linux-scsi@vger.kernel.org>,
jejb <James.Bottomley@HansenPartnership.com>
Subject: Re: next-2008-0306 scsi/libsas build failure
Date: Thu, 6 Mar 2008 13:01:00 -0800 [thread overview]
Message-ID: <20080306210059.GB7430@tree.beaverton.ibm.com> (raw)
In-Reply-To: <47D03666.9080000@oracle.com>
>> Sounds like a bug in the firmware code, it should provide stubs if this
>> config option is not present, right?
>
> That would be one (good) solution.
>
> I'll wait to see if James or Darrick have other ideas...
sas_request_addr should only be called in the (possibly) exceptional
case that a SAS controller forgot its address and wants a sysadmin to
provide one. However, it's not critical to the operation of libsas, so
in this particular case we can just return an error code if
CONFIG_FW_LOADER=n.
--D
next prev parent reply other threads:[~2008-03-06 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 17:09 next-2008-0306 scsi/libsas build failure Randy Dunlap
2008-03-06 18:16 ` Greg KH
2008-03-06 18:22 ` Randy Dunlap
2008-03-06 21:01 ` Darrick J. Wong [this message]
2008-03-06 21:02 ` [PATCH] libsas: Check that the firmware loader is present in sas_request_addr Darrick J. Wong
2008-03-06 21:17 ` James Bottomley
2008-03-06 21:20 ` Randy Dunlap
2008-03-06 22:04 ` Randy Dunlap
2008-03-06 22:16 ` James Bottomley
2008-03-07 4:54 ` Greg KH
2008-03-07 14:57 ` [PATCH] firmware: provide stubs for the FW_LOADER=n case James Bottomley
2008-03-07 17:08 ` patch firmware-provide-stubs-for-the-fw_loader-n-case.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306210059.GB7430@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=greg@kroah.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).