Re: [Bugme-new] [Bug 10226] New: BusLogic Flashpoint SCSI Adapter not working with x86_64 kernels

Boaz Harrosh
2008-03-12T18:50:59Z

On Wed, Mar 12 2008 at 20:36 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Wed, 2008-03-12 at 19:20 +0100, Ulrich Schweitzer wrote:
>> On Wednesday March 12 2008, Boaz Harrosh wrote:
>>
>>> An attached config file could help.
>>> It looks like you need ISA_DMA_API && VIRT_TO_BUS enabled are they?
>> They are both enabled, but consider that I didn't customize the kernel in any
>> way besides changing the processor type to K8 and setting CONFIG_IKCONFIG and
>> CONFIG_IKCONFIG_PROC. I don't know if I need the options you mentioned.
>>
>> I first noticed the problem with a Fedora kernel and compiled this one only to
>> confirm that the problem exists in the vanilla kernel as well.
>>
>> Here is the complete .config:
>
> Actually, this is the problem in BusLogic.h:
>
> /*
> FlashPoint support is only available for the Intel x86 Architecture with
> CONFIG_PCI set.
> */
>
> #ifndef __i386__
> #undef CONFIG_SCSI_OMIT_FLASHPOINT
> #define CONFIG_SCSI_OMIT_FLASHPOINT
> #endif
>
> #ifndef CONFIG_PCI
> #undef CONFIG_SCSI_OMIT_FLASHPOINT
> #define CONFIG_SCSI_OMIT_FLASHPOINT
> #define BusLogic_InitializeProbeInfoListISA BusLogic_InitializeProbeInfoList
> #endif
>
> Having this dependency logic done in the header file is not very user
> friendly, but the comment is pretty clear. I can move it to Kconfig,
> but it will still not work on x86_64 if that comment is accurate.
>
> James
>

I think the all thing is total bullshit and should be removed. First
it says x86 but that's not what is checked. Second if it is LE bad
then it should be possible to be compiled on other ARCHs and problems
reported and fixed. There is never a point in not letting it compile.

At most a | BROKEN logic in Kconfig.

The all thing stinks of Windowism with the capitalized file names and all
that stuff.

My mailer crashed in the middle of last post so a repost just in case:

---
BusLogic: Remove total bullshit.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>

git-diff --stat -p
drivers/scsi/BusLogic.h | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/BusLogic.h b/drivers/scsi/BusLogic.h
index bfbfb5c..0f0d7f3 100644
--- a/drivers/scsi/BusLogic.h
+++ b/drivers/scsi/BusLogic.h
@@ -38,11 +38,6 @@
CONFIG_PCI set.
*/

-#ifndef __i386__
-#undef CONFIG_SCSI_OMIT_FLASHPOINT
-#define CONFIG_SCSI_OMIT_FLASHPOINT
-#endif
-
#ifndef CONFIG_PCI
#undef CONFIG_SCSI_OMIT_FLASHPOINT
#define CONFIG_SCSI_OMIT_FLASHPOINT