public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Ulrich Schweitzer <us-@gmx.de>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	bugme-daemon@bugzilla.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 10226] New: BusLogic Flashpoint SCSI Adapter not working with x86_64 kernels
Date: Wed, 12 Mar 2008 21:25:49 +0100	[thread overview]
Message-ID: <200803122125.50161.us-@gmx.de> (raw)
In-Reply-To: <1205348570.2941.140.camel@localhost.localdomain>

On Wednesday March 12 2008, James Bottomley wrote:
> On Wed, 2008-03-12 at 20:49 +0200, Boaz Harrosh wrote:
> > On Wed, Mar 12 2008 at 20:36 +0200, James Bottomley 
<James.Bottomley@HansenPartnership.com> wrote:
> > > Actually, this is the problem in BusLogic.h:
> > >
> > > /*
> > >   FlashPoint support is only available for the Intel x86 Architecture
> > > with CONFIG_PCI set.
> > > */
> > >
> > > #ifndef __i386__
> > > #undef CONFIG_SCSI_OMIT_FLASHPOINT
> > > #define CONFIG_SCSI_OMIT_FLASHPOINT
> > > #endif
> > >
> > > #ifndef CONFIG_PCI
> > > #undef CONFIG_SCSI_OMIT_FLASHPOINT
> > > #define CONFIG_SCSI_OMIT_FLASHPOINT
> > > #define BusLogic_InitializeProbeInfoListISA
> > > BusLogic_InitializeProbeInfoList #endif
> > >
> > > Having this dependency logic done in the header file is not very user
> > > friendly, but the comment is pretty clear.  I can move it to Kconfig,
> > > but it will still not work on x86_64 if that comment is accurate.
> > >
> > > James
> >
> > I think the all thing is total bullshit and should be removed. First
> > it says x86 but that's not what is checked.
>
> Yes it is ... when this driver was written, i386 and x86 were
> synonymous.
>
> >  Second if it is LE bad
> > then it should be possible to be compiled on other ARCHs and problems
> > reported and fixed. There is never a point in not letting it compile.
>
> This is just a guess ...
>
> Flashpoint is 7,700 lines long; be my guest and look in it to see what
> the problem is.  Unfortunately, the original author isn't around to
> explain the reasoning.
>
> However, it seems obvious to me that the packed sccb format will
> immediately fail on a 64 bit system, so I don't think it's at all safe
> to blindly enable it.  The driver also doesn't look to be big endian
> safe.

You are right. I removed those lines and recompiled the module.  Now I get 

BusLogic: FlashPoint Host Adapter detected at PCI Bus 4 Device 8
BusLogic: I/O Address 0xCC00 PCI Address 0xFDBFE000, but FlashPoint
BusLogic: Probe Function failed to validate it.

when I try to insert it.

Sorry for straying off topic, but this has to be the right crowd to ask:
I assume that the driver won't be ported to x86_64 soon (if ever), so I'll 
need a different SCSI adapter. Is the Adaptec AHA-2940 supported on x86_64 
(those are cheap on ebay)? If not, what other, preferably cheap, SE SCSI 
adapter would you recommend?

Ulrich

  reply	other threads:[~2008-03-12 20:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-10226-10286@http.bugzilla.kernel.org/>
2008-03-11 20:44 ` [Bugme-new] [Bug 10226] New: BusLogic Flashpoint SCSI Adapter not working with x86_64 kernels Andrew Morton
2008-03-12 11:03   ` Boaz Harrosh
2008-03-12 18:20     ` Ulrich Schweitzer
2008-03-12 18:36       ` James Bottomley
2008-03-12 18:49         ` Boaz Harrosh
2008-03-12 19:02           ` James Bottomley
2008-03-12 20:25             ` Ulrich Schweitzer [this message]
2008-03-12 21:35               ` James Bottomley
2008-03-13  6:09                 ` Ulrich Schweitzer
2008-03-13 12:55                   ` [Bug 10226] " Matthew Wilcox
2008-03-13 16:45                     ` Christoph Hellwig
2008-03-13 17:11                       ` Matthew Wilcox
2008-03-13 17:15                         ` Christoph Hellwig
2008-03-12 11:29   ` [Bugme-new] [Bug 10226] New: " James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803122125.50161.us-@gmx.de \
    --to=us-@gmx.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=bharrosh@panasas.com \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox