Re: [patch] convert the scsi layer to use struct device

Greg KH
2008-03-17T05:30:16Z

On Mon, Mar 17, 2008 at 12:15:25AM -0400, James Smart wrote:
>
>
> Kay Sievers wrote:
>>> Well, the <classname> prefix came about because there was namespace
>>> overlap
>>> between different classes (e.g. scsi_host and fc_host classes use the
>>> same name,
>>> and I think where we originally saw this was in the way serial ports were
>>> enumerated
>>> for some base systems as well).
>>>
>>> So I don't see how you can kill the <classname>:<devname> names by
>>> SYSFS_DEPRECATED.
>> With SYSFS_DEPRECATED, nothing will change. But these links don't exist
>> with !SYSFS_DEPRECATED, because the class devices live in
>> subdirectories, named after the class they come from, there is no
>> namespace problem, or any problem to find these devices, you don't even
>> need readdir() to look them up.
>
> Ok, it should have read :
> I don't see how you can kill the <classname>:<devname> names w/
> !SYSFS_DEPRECATED.
>
> You still haven't answered my question about namespace overlap. What
> happens when the
> device belongs to multiple classes, and the classes have the same name for
> the class
> device ? I don't believe we ever want to be in the case where the classes
> have to
> understand a global namespace.

I take it you haven't even looked at how !SYSFS_DEPRECATED works today,
have you? Try it and you will see that the namespace issue has been
taken care of a long time ago :)

thanks,

greg k-h