From: Greg KH <greg@kroah.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Hannes Reinecke <hare@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API
Date: Fri, 21 Mar 2008 15:26:35 -0700 [thread overview]
Message-ID: <20080321222635.GA2674@kroah.com> (raw)
In-Reply-To: <1206134832.2961.64.camel@localhost.localdomain>
On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote:
> We have a problem in scsi_transport_spi in that we need to customise
> not only the visibility of the attributes, but also their mode. Fix
> this by making the is_visible() callback return a mode, with 0
> indicating is not visible.
>
> Also add a sysfs_update_group() API to allow us to change either the
> visibility or mode of the files at any time on the fly.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> ---
>
> Greg, can I take this through SCSI, please ... assuming it's OK? We
> need this to fix up the SPI transport class.
Sure. But can you document that "update" field a bit more so we can
remember what it means in the future?
thanks,
greg k-h
next prev parent reply other threads:[~2008-03-21 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 21:27 [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API James Bottomley
2008-03-21 22:26 ` Greg KH [this message]
2008-03-22 18:02 ` James Bottomley
2008-03-30 16:54 ` James Bottomley
2008-03-31 13:42 ` Kay Sievers
2008-04-02 6:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321222635.GA2674@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox