From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API Date: Fri, 21 Mar 2008 15:26:35 -0700 Message-ID: <20080321222635.GA2674@kroah.com> References: <1206134832.2961.64.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:38255 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717AbYCUW0r (ORCPT ); Fri, 21 Mar 2008 18:26:47 -0400 Content-Disposition: inline In-Reply-To: <1206134832.2961.64.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Hannes Reinecke , Kay Sievers , linux-scsi , linux-kernel On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote: > We have a problem in scsi_transport_spi in that we need to customise > not only the visibility of the attributes, but also their mode. Fix > this by making the is_visible() callback return a mode, with 0 > indicating is not visible. > > Also add a sysfs_update_group() API to allow us to change either the > visibility or mode of the files at any time on the fly. > > Signed-off-by: James Bottomley > --- > > Greg, can I take this through SCSI, please ... assuming it's OK? We > need this to fix up the SPI transport class. Sure. But can you document that "update" field a bit more so we can remember what it means in the future? thanks, greg k-h