From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, harvey.harrison@gmail.com
Subject: Re: [patch 08/17] scsi: replace remaining __FUNCTION__ occurrences
Date: Fri, 28 Mar 2008 15:45:18 -0700 [thread overview]
Message-ID: <20080328154518.1a178afa.akpm@linux-foundation.org> (raw)
In-Reply-To: <1206743704.3662.61.camel@localhost.localdomain>
On Fri, 28 Mar 2008 17:35:04 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Fri, 2008-03-28 at 14:48 -0700, akpm@linux-foundation.org wrote:
> > From: Harvey Harrison <harvey.harrison@gmail.com>
> >
> > __FUNCTION__ is gcc-specific, use __func__
>
> I thought we basically agreed
No.
> there was no point to this since if it
> ever became an issue you can do
>
> #define __FUNCTION__ __func__
>
> inside the include/compiler-xxx.h file
>
It's better to get things right at the original code site, rather than
adding crufty back-compatibility macros.
The patches are easy to prepare, easy to review and easy to merge. There's
no reason to not do so.
next prev parent reply other threads:[~2008-03-28 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:48 [patch 08/17] scsi: replace remaining __FUNCTION__ occurrences akpm
2008-03-28 22:35 ` James Bottomley
2008-03-28 22:45 ` Andrew Morton [this message]
2008-03-28 22:48 ` Harvey Harrison
2008-03-30 14:08 ` James Bottomley
2008-03-30 15:07 ` Andrew Morton
2008-03-30 15:36 ` James Bottomley
2008-03-30 18:45 ` Harvey Harrison
2008-03-31 19:34 ` Mike Christie
2008-03-31 19:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328154518.1a178afa.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox