From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: htejun@gmail.com
Cc: fujita.tomonori@lab.ntt.co.jp, linux-scsi@vger.kernel.org,
tomof@acm.org, James.Bottomley@HansenPartnership.com,
jens.axboe@oracle.com
Subject: Re: [PATCH 1/2] block: move the padding adjustment to blk_rq_map_sg
Date: Mon, 7 Apr 2008 22:11:05 +0900 [thread overview]
Message-ID: <20080407221103Y.tomof@acm.org> (raw)
In-Reply-To: <47FA061A.8000107@gmail.com>
On Mon, 07 Apr 2008 20:31:38 +0900
Tejun Heo <htejun@gmail.com> wrote:
> FUJITA Tomonori wrote:
> >> Maybe we need yet another flag indicating padding space
> >> availability?
> >
> > How about doing the exact same thing that the drain buffer does? We
> > can put pre-allocated buffer to a queue and save one sg entry for it.
>
> Each sg entry should be aligned so extra sg doesn't really help or am I
> missing something?
Sorry, please scratch the previous mail. I think that I misunderstood
what you meant.
The current code does padding only for requests that we call
__blk_rq_map_user (bio_copy_user) for. You meant that if we create a
new flag like REQ_NEED_PADDING and set it in blk_rq_map_user,
blk_rq_map_sg can do padding only when it was set.
Right?
next prev parent reply other threads:[~2008-04-07 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 16:52 [PATCH 0/2] block: blk_rq_map/unamp patches FUJITA Tomonori
2008-04-02 16:52 ` [PATCH 1/2] block: move the padding adjustment to blk_rq_map_sg FUJITA Tomonori
2008-04-02 16:53 ` [PATCH 2/2] block: change blk_rq_unmap_user to take a request instead of a bio FUJITA Tomonori
2008-04-03 3:34 ` [PATCH 1/2] block: move the padding adjustment to blk_rq_map_sg Tejun Heo
2008-04-07 11:07 ` FUJITA Tomonori
2008-04-07 11:31 ` Tejun Heo
2008-04-07 13:11 ` FUJITA Tomonori [this message]
2008-04-07 13:24 ` Tejun Heo
2008-04-07 23:35 ` FUJITA Tomonori
2008-04-08 1:49 ` Tejun Heo
2008-04-08 2:37 ` FUJITA Tomonori
2008-04-10 1:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407221103Y.tomof@acm.org \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=James.Bottomley@HansenPartnership.com \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox