From: Denys Vlasenko <vda.linux@googlemail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] debloat aic7xxx and aic79xx drivers
Date: Mon, 14 Apr 2008 20:46:31 +0200 [thread overview]
Message-ID: <200804142046.31080.vda.linux@googlemail.com> (raw)
In-Reply-To: <200804081608.43248.vda.linux@googlemail.com>
Hi Hannes,
On Tuesday 08 April 2008 16:08, Denys Vlasenko wrote:
> > > #if 0 / #endif block ends up containing definitions of 290 functions/macros,
> > > none of which is EVER used. I used this script (below) and verified that
> > > they are never mentioned anywhere outside of *_shipped files.
> > > I also did test builds with and without debug enabled and they build
> > > with no problems. No undefined references!
> > >
> > Well, still not quite. The point here is that all of the functions in the
> > *_shipped files are in fact auto-generated by aicasm, based on the definitions
> > in aic79xx.seq and aic79xx.reg. So the *_reg_print.c files contains
> > functions for all _defined_ registers, not the actually used ones.
> > What we have to do here is to modify aicasm to not print out the
> > unused definitions, and copy those (autogenerated) files over to
> > the *_shipped files to have them synced properly.
> > Hand-patching the *_shipped files is not a good idea.
>
> I do understand this, and I do understnad then _shipped files
> are generated. But I failed to find out HOW they are generated.
> I don't want to _only_ patch aicasm/* files and skip checking
> that my changes work (or at least compile).
>
> Please let me know how to regenerate these _shipped files,
> and I will fix it "correctly" by modifying aicasm/* files.
I didn't get any reply. Perhaps you were busy with more important stuff.
Ping! :)
--
vda
next prev parent reply other threads:[~2008-04-14 18:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 3:40 [PATCH 0/3] debloat aic7xxx and aic79xx drivers Denys Vlasenko
2008-03-23 3:41 ` [PATCH 1/3] " Denys Vlasenko
2008-03-23 3:42 ` [PATCH 2/3] " Denys Vlasenko
2008-03-23 3:42 ` [PATCH 3/3] " Denys Vlasenko
2008-04-07 10:36 ` Hannes Reinecke
2008-04-07 10:34 ` [PATCH 2/3] " Hannes Reinecke
2008-04-07 18:00 ` Denys Vlasenko
2008-04-08 12:23 ` Hannes Reinecke
2008-04-08 14:08 ` Denys Vlasenko
2008-04-08 14:54 ` Hannes Reinecke
2008-04-08 15:08 ` Denys Vlasenko
2008-04-14 18:47 ` Denys Vlasenko
[not found] ` <4804BE68.4000704@suse.de>
2008-04-15 20:10 ` Denys Vlasenko
2008-04-21 5:10 ` Denys Vlasenko
2008-04-14 18:46 ` Denys Vlasenko [this message]
2008-04-15 14:44 ` Hannes Reinecke
2008-04-07 10:31 ` [PATCH 1/3] " Hannes Reinecke
2008-04-07 18:01 ` Denys Vlasenko
-- strict thread matches above, loose matches on Subject: below --
2007-10-14 14:58 [PATCH 0/3] " Denys Vlasenko
2007-10-14 15:00 ` [PATCH 1/3] " Denys Vlasenko
2007-10-14 15:01 ` [PATCH 2/3] " Denys Vlasenko
2007-08-31 15:13 [PATCH 0/3] " Denys Vlasenko
2007-08-31 15:15 ` [PATCH 1/3] " Denys Vlasenko
2007-08-31 15:16 ` [PATCH 2/3] " Denys Vlasenko
2007-09-24 10:23 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804142046.31080.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).