From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denys Vlasenko Subject: Re: [PATCH 2/3] debloat aic7xxx and aic79xx drivers Date: Mon, 14 Apr 2008 20:46:31 +0200 Message-ID: <200804142046.31080.vda.linux@googlemail.com> References: <200803230440.40685.vda.linux@googlemail.com> <47FB63C2.4030006@suse.de> <200804081608.43248.vda.linux@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from fg-out-1718.google.com ([72.14.220.157]:50878 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964930AbYDNSqo (ORCPT ); Mon, 14 Apr 2008 14:46:44 -0400 Received: by fg-out-1718.google.com with SMTP id l27so1664229fgb.17 for ; Mon, 14 Apr 2008 11:46:42 -0700 (PDT) In-Reply-To: <200804081608.43248.vda.linux@googlemail.com> Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke Cc: Andrew Morton , linux-scsi@vger.kernel.org Hi Hannes, On Tuesday 08 April 2008 16:08, Denys Vlasenko wrote: > > > #if 0 / #endif block ends up containing definitions of 290 functions/macros, > > > none of which is EVER used. I used this script (below) and verified that > > > they are never mentioned anywhere outside of *_shipped files. > > > I also did test builds with and without debug enabled and they build > > > with no problems. No undefined references! > > > > > Well, still not quite. The point here is that all of the functions in the > > *_shipped files are in fact auto-generated by aicasm, based on the definitions > > in aic79xx.seq and aic79xx.reg. So the *_reg_print.c files contains > > functions for all _defined_ registers, not the actually used ones. > > What we have to do here is to modify aicasm to not print out the > > unused definitions, and copy those (autogenerated) files over to > > the *_shipped files to have them synced properly. > > Hand-patching the *_shipped files is not a good idea. > > I do understand this, and I do understnad then _shipped files > are generated. But I failed to find out HOW they are generated. > I don't want to _only_ patch aicasm/* files and skip checking > that my changes work (or at least compile). > > Please let me know how to regenerate these _shipped files, > and I will fix it "correctly" by modifying aicasm/* files. I didn't get any reply. Perhaps you were busy with more important stuff. Ping! :) -- vda