Re: [GIT PATCH] SCSI updates for 2.6.25

[Matthew Wilcox <matthew@wil.cx>]

On Sat, Apr 19, 2008 at 01:14:23PM -0700, Linus Torvalds wrote:
> So people: stop this total *idiocy* with "select is bad". It's not. The 
> lack of select is *much* worse.

Could we consider applying this patch then?

----

'select' not Considered Evil

While select should be used with care, it is not actually evil.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

diff --git a/Documentation/kbuild/kconfig-language.txt b/Documentation/kbuild/kconfig-language.txt
index 649cb87..dacfcf2 100644
--- a/Documentation/kbuild/kconfig-language.txt
+++ b/Documentation/kbuild/kconfig-language.txt
@@ -104,9 +104,9 @@ applicable everywhere (see syntax).
   Reverse dependencies can only be used with boolean or tristate
   symbols.
   Note:
-	select is evil.... select will by brute force set a symbol
-	equal to 'y' without visiting the dependencies. So abusing
-	select you are able to select a symbol FOO even if FOO depends
+	select should be used with care.  It can set a symbol
+	without visiting the dependencies.  By abusing select you are
+	able to select a symbol FOO even if FOO depends
 	on BAR that is not set. In general use select only for
 	non-visible symbols (no prompts anywhere) and for symbols with
 	no dependencies. That will limit the usefulness but on the

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."