From: Daniel Walker <dwalker@mvista.com>
To: James.Bottomley@HansenPartnership.com
Cc: mingo@elte.hu, matthew@wil.cx, linux-driver@qlogic.com,
linux-scsi@vger.kernel.org
Subject: [PATCH] qla2xxx: firmware semaphore to mutex
Date: Mon, 28 Apr 2008 10:47:42 -0700 [thread overview]
Message-ID: <20080428174742.163523860@mvista.com> (raw)
Signed-off-by: Daniel Walker <dwalker@mvista.com>
---
drivers/scsi/qla2xxx/qla_os.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
Index: linux-2.6.23/drivers/scsi/qla2xxx/qla_os.c
===================================================================
--- linux-2.6.23.orig/drivers/scsi/qla2xxx/qla_os.c
+++ linux-2.6.23/drivers/scsi/qla2xxx/qla_os.c
@@ -10,6 +10,7 @@
#include <linux/vmalloc.h>
#include <linux/delay.h>
#include <linux/kthread.h>
+#include <linux/mutex.h>
#include <scsi/scsi_tcq.h>
#include <scsi/scsicam.h>
@@ -2782,7 +2783,7 @@ qla2x00_down_timeout(struct semaphore *s
#define FW_FILE_ISP24XX "ql2400_fw.bin"
#define FW_FILE_ISP25XX "ql2500_fw.bin"
-static DECLARE_MUTEX(qla_fw_lock);
+static DEFINE_MUTEX(qla_fw_lock);
static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
{ .name = FW_FILE_ISP21XX, .segs = { 0x1000, 0 }, },
@@ -2813,7 +2814,7 @@ qla2x00_request_firmware(scsi_qla_host_t
blob = &qla_fw_blobs[FW_ISP25XX];
}
- down(&qla_fw_lock);
+ mutex_lock(&qla_fw_lock);
if (blob->fw)
goto out;
@@ -2826,7 +2827,7 @@ qla2x00_request_firmware(scsi_qla_host_t
}
out:
- up(&qla_fw_lock);
+ mutex_unlock(&qla_fw_lock);
return blob;
}
@@ -2835,11 +2836,11 @@ qla2x00_release_firmware(void)
{
int idx;
- down(&qla_fw_lock);
+ mutex_lock(&qla_fw_lock);
for (idx = 0; idx < FW_BLOBS; idx++)
if (qla_fw_blobs[idx].fw)
release_firmware(qla_fw_blobs[idx].fw);
- up(&qla_fw_lock);
+ mutex_unlock(&qla_fw_lock);
}
static pci_ers_result_t
--
--
next reply other threads:[~2008-04-28 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:47 Daniel Walker [this message]
2008-04-28 18:08 ` [PATCH] qla2xxx: firmware semaphore to mutex Matthew Wilcox
2008-04-28 18:57 ` Daniel Walker
2008-04-28 19:04 ` Matthew Wilcox
2008-04-28 19:21 ` Daniel Walker
2008-04-28 19:24 ` Matthew Wilcox
2008-04-28 19:33 ` Ingo Molnar
2008-04-28 19:54 ` Daniel Walker
2008-04-28 20:55 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428174742.163523860@mvista.com \
--to=dwalker@mvista.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox