From: Matthew Wilcox <matthew@wil.cx>
To: Daniel Walker <dwalker@mvista.com>
Cc: James.Bottomley@HansenPartnership.com, mingo@elte.hu,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] qla2xxx: firmware semaphore to mutex
Date: Mon, 28 Apr 2008 12:08:46 -0600 [thread overview]
Message-ID: <20080428180846.GX14990@parisc-linux.org> (raw)
In-Reply-To: <20080428174742.163523860@mvista.com>
On Mon, Apr 28, 2008 at 10:47:42AM -0700, Daniel Walker wrote:
> Signed-off-by: Daniel Walker <dwalker@mvista.com>
I did this one too ... my version had a nice little twist.
> @@ -2813,7 +2814,7 @@ qla2x00_request_firmware(scsi_qla_host_t
> blob = &qla_fw_blobs[FW_ISP25XX];
> }
>
> - down(&qla_fw_lock);
> + mutex_lock(&qla_fw_lock);
> if (blob->fw)
> goto out;
>
This one we can do as:
- down(&qla_fw_lock);
+ if (mutex_lock_killable(&qla_fw_lock))
+ return NULL;
+
Otherwise, I think our patches are bit-for-bit identical.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-04-28 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:47 [PATCH] qla2xxx: firmware semaphore to mutex Daniel Walker
2008-04-28 18:08 ` Matthew Wilcox [this message]
2008-04-28 18:57 ` Daniel Walker
2008-04-28 19:04 ` Matthew Wilcox
2008-04-28 19:21 ` Daniel Walker
2008-04-28 19:24 ` Matthew Wilcox
2008-04-28 19:33 ` Ingo Molnar
2008-04-28 19:54 ` Daniel Walker
2008-04-28 20:55 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428180846.GX14990@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwalker@mvista.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox