From: Matthew Wilcox <matthew@wil.cx>
To: Daniel Walker <dwalker@mvista.com>
Cc: James.Bottomley@HansenPartnership.com, mingo@elte.hu,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] qla2xxx: firmware semaphore to mutex
Date: Mon, 28 Apr 2008 13:24:16 -0600 [thread overview]
Message-ID: <20080428192416.GZ14990@parisc-linux.org> (raw)
In-Reply-To: <1209410518.12461.71.camel@localhost.localdomain>
On Mon, Apr 28, 2008 at 12:21:58PM -0700, Daniel Walker wrote:
> Don't you need to return the -EINTR so the caller knows the nature of
> the failure? You might also need to re-factor the caller of this
> function so it properly reports the failure to userspace .. In this case
> your just returning NULL ..
The signal is _fatal_. Userspace doesn't get to check the return value.
It's dead.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-04-28 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:47 [PATCH] qla2xxx: firmware semaphore to mutex Daniel Walker
2008-04-28 18:08 ` Matthew Wilcox
2008-04-28 18:57 ` Daniel Walker
2008-04-28 19:04 ` Matthew Wilcox
2008-04-28 19:21 ` Daniel Walker
2008-04-28 19:24 ` Matthew Wilcox [this message]
2008-04-28 19:33 ` Ingo Molnar
2008-04-28 19:54 ` Daniel Walker
2008-04-28 20:55 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428192416.GZ14990@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox