Re: [PATCH] qla2xxx: firmware semaphore to mutex

Ingo Molnar
2008-04-28T19:34:28Z

* Matthew Wilcox <matthew@wil.cx> wrote:

> On Mon, Apr 28, 2008 at 12:21:58PM -0700, Daniel Walker wrote:
> > Don't you need to return the -EINTR so the caller knows the nature of
> > the failure? You might also need to re-factor the caller of this
> > function so it properly reports the failure to userspace .. In this case
> > your just returning NULL ..
>
> The signal is _fatal_. Userspace doesn't get to check the return
> value. It's dead.

i agree with your change, nevertheless Daniel is right in that the
change should be in a separate patch. "sem2mutex" patches are supposed
to be NOP-ish patches, with nothing else mixed in.

Ingo