Re: [PATCH] qla2xxx: firmware semaphore to mutex

Matthew Wilcox
2008-04-28T19:24:18Z

On Mon, Apr 28, 2008 at 12:21:58PM -0700, Daniel Walker wrote:
> Don't you need to return the -EINTR so the caller knows the nature of
> the failure? You might also need to re-factor the caller of this
> function so it properly reports the failure to userspace .. In this case
> your just returning NULL ..

The signal is _fatal_. Userspace doesn't get to check the return value.
It's dead.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."