Re: [PATCH] qla2xxx: firmware semaphore to mutex

Daniel Walker
2008-04-28T18:57:17Z

On Mon, 2008-04-28 at 12:08 -0600, Matthew Wilcox wrote:
> On Mon, Apr 28, 2008 at 10:47:42AM -0700, Daniel Walker wrote:
> > Signed-off-by: Daniel Walker <dwalker@mvista.com>
>
> I did this one too ... my version had a nice little twist.
>
> > @@ -2813,7 +2814,7 @@ qla2x00_request_firmware(scsi_qla_host_t
> > blob = &qla_fw_blobs[FW_ISP25XX];
> > }
> >
> > - down(&qla_fw_lock);
> > + mutex_lock(&qla_fw_lock);
> > if (blob->fw)
> > goto out;
> >
>
> This one we can do as:
>
> - down(&qla_fw_lock);
> + if (mutex_lock_killable(&qla_fw_lock))
> + return NULL;

I'm not sure what mutex_lock_killable() does, so I would imagine that
should be in it's own patch .. I don't like doubling up on changes
because I feel it's harder to review, and harder on git bisect once it's
in mainline.. That's why I was saying "one lock per patch." ..

Daniel