From: Chandra Seetharaman <sekharan@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: dm-devel@redhat.com, andmike@us.ibm.com, michaelc@cs.wisc.edu,
agk@redhat.com, James.Bottomley@HansenPartnership.com,
jens.axboe@oracle.com, dwysocha@redhat.com,
Benoit_Arthur@emc.com, asson_ronald@emc.com,
Chandra Seetharaman <sekharan@us.ibm.com>
Subject: [PATCH 08/10] scsi_dh: Remove dm_pg_init_complete
Date: Thu, 01 May 2008 14:50:28 -0700 [thread overview]
Message-ID: <20080501215028.27759.23808.sendpatchset@chandra-ubuntu> (raw)
In-Reply-To: <20080501214941.27759.95121.sendpatchset@chandra-ubuntu>
Subject: [PATCH 08/10] scsi_dh: Remove dm_pg_init_complete
From: Chandra Seetharaman <sekharan@us.ibm.com>
This patch just removes the dm layer's path initialization completion
routine. This is separated from the other patch(scsi_dh: Use SCSI
device handler in dm-multipath) Just to make that patch more readable.
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
---
Index: linux-2.6.25/drivers/md/dm-mpath.c
===================================================================
--- linux-2.6.25.orig/drivers/md/dm-mpath.c
+++ linux-2.6.25/drivers/md/dm-mpath.c
@@ -7,7 +7,6 @@
#include "dm.h"
#include "dm-path-selector.h"
-#include "dm-hw-handler.h"
#include "dm-bio-list.h"
#include "dm-bio-record.h"
#include "dm-uevent.h"
@@ -1012,44 +1011,6 @@ static int pg_init_limit_reached(struct
return limit_reached;
}
-/*
- * pg_init must call this when it has completed its initialisation
- */
-void dm_pg_init_complete(struct dm_path *path, unsigned err_flags)
-{
- struct pgpath *pgpath = path_to_pgpath(path);
- struct priority_group *pg = pgpath->pg;
- struct multipath *m = pg->m;
- unsigned long flags;
-
- /*
- * If requested, retry pg_init until maximum number of retries exceeded.
- * If retry not requested and PG already bypassed, always fail the path.
- */
- if (err_flags & MP_RETRY) {
- if (pg_init_limit_reached(m, pgpath))
- err_flags |= MP_FAIL_PATH;
- } else if (err_flags && pg->bypassed)
- err_flags |= MP_FAIL_PATH;
-
- if (err_flags & MP_FAIL_PATH)
- fail_path(pgpath);
-
- if (err_flags & MP_BYPASS_PG)
- bypass_pg(m, pg, 1);
-
- spin_lock_irqsave(&m->lock, flags);
- if (err_flags & ~MP_RETRY) {
- m->current_pgpath = NULL;
- m->current_pg = NULL;
- } else if (!m->pg_init_required)
- m->queue_io = 0;
-
- m->pg_init_in_progress = 0;
- queue_work(kmultipathd, &m->process_queued_ios);
- spin_unlock_irqrestore(&m->lock, flags);
-}
-
static void pg_init_done(struct dm_path *path, int errors)
{
struct pgpath *pgpath = path_to_pgpath(path);
@@ -1501,8 +1462,6 @@ static void __exit dm_multipath_exit(voi
kmem_cache_destroy(_mpio_cache);
}
-EXPORT_SYMBOL_GPL(dm_pg_init_complete);
-
module_init(dm_multipath_init);
module_exit(dm_multipath_exit);
next prev parent reply other threads:[~2008-05-01 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 21:49 [PATCH 00/10] scsi_dh: Move hardware handlers from dm to SCSI Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 01/10] scsi_dh: add infrastructure for SCSI Device Handlers Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 02/10] scsi_dh: add lsi rdac device handler Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 03/10] scsi_dh: add hp sw " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 04/10] scsi_dh: add EMC Clariion " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 05/10] scsi_dh: Use SCSI device handler in dm-multipath Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 06/10] scsi_dh: Do not allow arguments for hardware handlers Chandra Seetharaman
2008-05-02 22:47 ` Alasdair G Kergon
2008-05-03 0:01 ` [dm-devel] " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 07/10] scsi_dh: Add a single threaded workqueue for initializing paths Chandra Seetharaman
2008-05-01 21:50 ` Chandra Seetharaman [this message]
2008-05-01 21:50 ` [PATCH 09/10] scsi_dh: Remove hardware handlers from dm Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 10/10] scsi_dh: Remove hardware handler infrastructure " Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501215028.27759.23808.sendpatchset@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=Benoit_Arthur@emc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agk@redhat.com \
--cc=andmike@us.ibm.com \
--cc=asson_ronald@emc.com \
--cc=dm-devel@redhat.com \
--cc=dwysocha@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox