From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Miquel van Smoorenburg <miquels@cistron.nl>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/4] dpt_i2o: 64 bit support
Date: Fri, 2 May 2008 13:32:12 +0200 [thread overview]
Message-ID: <200805021332.13252.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20080501230724.GA19844@xs4all.net>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
Miquel van Smoorenburg wrote:
> [PATCH 3/4] dpt_i2o: 64 bit support
>
> This is the code to actually support 64 bit platforms. 64 bit
> DMA is enabled on both x86_32 PAE and 64 bit platforms.
>
> This code is based in part on the unofficial adaptec 64-bit
> dpt_i2o driver update that I got from Mark Salyzyn at Adaptec.
> +static inline int dpt_dma64(adpt_hba *pHba)
> +{
> + return (sizeof(dma_addr_t) > 4 && (pHba)->dma64);
> +}
> +
Just a note: you never set dma64 if sizeof(dma_addr_t) == 4. Doing it this way
has the advantage that the compiler can optimize that away completely.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]
next prev parent reply other threads:[~2008-05-02 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 23:02 [PATCH 0/4] dpt_i2o: 64 bit support (take 5) Miquel van Smoorenburg
2008-05-01 23:05 ` [PATCH 1/4] dpt_i2o: use standard __init / __exit code Miquel van Smoorenburg
2008-05-02 13:18 ` Mark Salyzyn
2008-05-01 23:06 ` [PATCH 2/4] dpt_i2o: move from virt_to_bus/bus_to_virt to dma_alloc_coherent Miquel van Smoorenburg
2008-05-02 11:25 ` Rolf Eike Beer
2008-05-02 12:15 ` Miquel van Smoorenburg
2008-05-01 23:07 ` [PATCH 3/4] dpt_i2o: 64 bit support Miquel van Smoorenburg
2008-05-02 11:32 ` Rolf Eike Beer [this message]
2008-05-01 23:08 ` [PATCH 4/4] dpt_i2o: sysfs code Miquel van Smoorenburg
2008-05-02 13:28 ` Mark Salyzyn
2008-05-07 3:10 ` [PATCH 0/4] dpt_i2o: 64 bit support (take 5) Andrew Morton
2008-05-13 5:42 ` Andrew Morton
2008-05-13 16:51 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805021332.13252.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
--cc=miquels@cistron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox