Re: [PATCH 4/5] aic7xxx: teach aicasm to not emit unused debug code/data

[Denys Vlasenko <vda.linux@googlemail.com>]

On Monday 28 April 2008 10:25, Denys Vlasenko wrote:
> > But now we're facing another problem: Those symbols
> > referenced from the sequencer code only will in most
> > cases _not_ be printed via the autogenerated _print
> > functions.
> > 
> > So what we really need to do here to do this properly
> > is to write a preprocessor, which checks the _used_ 
> > *_print() functions in the source code and generates
> > the aic7*xx_reg_print.c file on the fly. And remove
> > this code from aicasm entirely.
> 
> I agree that this would be the proper solution in a sense
> that it would autodetect and generate only what is needed.
> 
> > But this really might be considered a bit of an
> > overkill.
> 
> Since this is an ad-hoc system, instead of spending time
> on more difficult system which does this detection
> we can simply manually instruct aicasm to not generate
> *_print() functions which won't be ever called by the driver.
> 
> Basically this would be a respin of my patch #4.
> After you introduced reference counts, I will need
> to add much smaller number of "dont_generate_debug_code"
> fields than before.
> 
> Are you ok with this in principle?

Ping...
--
vda