From: Christoph Hellwig <hch@infradead.org>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, axboe@kernel.dk,
andmike@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] Added flush_disk to factor out common buffer cache flushing code.
Date: Tue, 6 May 2008 04:44:11 -0400 [thread overview]
Message-ID: <20080506084411.GA31380@infradead.org> (raw)
In-Reply-To: <20080505230419.12905.36939.stgit@bluto.andrew>
On Mon, May 05, 2008 at 05:04:19PM -0600, Andrew Patterson wrote:
> Added flush_disk to factor out common buffer cache flushing code.
>
> We need to be able to flush the buffer cache for more than just when a
> disk is changed, so we factor out common cache flush code in
> check_disk_change() to an internal flush_disk() routine. This routine
> will then be used for both disk changes and disk resizes (in a later
> patch).
>
> Include the disk name in the text indicating that there are busy
> inodes on the device and increase the KERN severity of the message.
This doesn't make much sense to me. When a disk has grown there's no
point in invalidating any buffers, and when it has shrunk it's too late
already. Also I suspect modern filesystems might be really allergic to
this kind of under the hood actions. That is if they use the bdev
mapping at all, something that at least xfs and I think btrfs aswell
don't do at all.
next prev parent reply other threads:[~2008-05-06 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 23:04 [PATCH 0/4] detect online disk resize Andrew Patterson
2008-05-05 23:04 ` [PATCH 1/2] Added flush_disk to factor out common buffer cache flushing code Andrew Patterson
2008-05-06 8:44 ` Christoph Hellwig [this message]
2008-05-07 17:59 ` James Bottomley
2008-05-07 18:08 ` Andrew Patterson
2008-05-07 18:21 ` James Bottomley
2008-05-05 23:04 ` [PATCH 2/2] Wrapper for lower-level revalidate_disk routines Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506084411.GA31380@infradead.org \
--to=hch@infradead.org \
--cc=andmike@linux.vnet.ibm.com \
--cc=andrew.patterson@hp.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox