Re: lockdep whine in 2.6.26-rc2-mm1

[Matthew Wilcox <matthew@wil.cx>]

On Tue, May 20, 2008 at 09:27:59AM +0800, Dave Young wrote:
> > The question isn't whether there is or isn't this kind of use right now.
> > The question is whether there might be this kind of use in the future,
> > and if there is, whether we'd like lockdep to warn us.
> 
> In the future, IMHO, the class_interface should go away just as
> class_device. If that happened this problem would going away as well.

Go away ... and be replaced by something else, right?  I mean, it's not
like we don't have a need to bind two kinds of driver to the same
device.  So we're going to continue to have the situation where you can
register a new kind of driver and want to create new devices, so we'll
still have a nesting of some kind.

> Your idea is good. But as I said above, for current situation there's
> no potential problems except class_interface usage, and the
> class_interface will go away
>  in the future.
> 
> So IMO It's not necessary to do this for all classes.

Assuming your analysis is correct, of course.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."