From: Greg KH <greg@kroah.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: akpm@linux-foundation.org, matthew@wil.cx, kay.sievers@vrfy.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3][-mm] reclassify the sg_sysfs_class mutex
Date: Tue, 20 May 2008 21:37:20 -0700 [thread overview]
Message-ID: <20080521043720.GB8950@kroah.com> (raw)
In-Reply-To: <a8e1da0805201825w4c8e35d7o55db8af9e04981df@mail.gmail.com>
On Wed, May 21, 2008 at 09:25:58AM +0800, Dave Young wrote:
> On Wed, May 21, 2008 at 1:22 AM, Greg KH <greg@kroah.com> wrote:
> > On Tue, May 20, 2008 at 05:58:51PM +0800, Dave Young wrote:
> >> [Please first apply the patch 1/3 before this]
> >>
> >> To please lockdep here we use class_reclassify to change
> >> the lock class of sg_sysfs_class
> >
> > Are you suggesting we do this for every struct class in the kernel? If
> > so, why not just do it in the class core, instead of having to modify
> > every single caller?
>
> I don't think it necessary to do this for every class, because only
> class_interface_* calls could cause the issue, and the
> class_interface_* are only used by pcmcia & scsi, do you think there
> will be other users of them?
I do not know, there might be in the future.
thanks,
greg k-h
prev parent reply other threads:[~2008-05-21 4:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:58 [PATCH 2/3][-mm] reclassify the sg_sysfs_class mutex Dave Young
2008-05-20 17:22 ` Greg KH
2008-05-21 1:25 ` Dave Young
2008-05-21 4:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521043720.GB8950@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox