Re: [PATCH 2/3][-mm] reclassify the sg_sysfs_class mutex

Dave Young
2008-05-21T01:26:02Z

On Wed, May 21, 2008 at 1:22 AM, Greg KH <greg@kroah.com> wrote:
> On Tue, May 20, 2008 at 05:58:51PM +0800, Dave Young wrote:
>> [Please first apply the patch 1/3 before this]
>>
>> To please lockdep here we use class_reclassify to change
>> the lock class of sg_sysfs_class
>
> Are you suggesting we do this for every struct class in the kernel? If
> so, why not just do it in the class core, instead of having to modify
> every single caller?

I don't think it necessary to do this for every class, because only
class_interface_* calls could cause the issue, and the
class_interface_* are only used by pcmcia & scsi, do you think there
will be other users of them?

>
> I don't think the overall idea of this patch set is acceptable anyway :(
>
> thanks,
>
> greg k-h
>