From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: herbert@gondor.apana.org.au
Cc: fujita.tomonori@lab.ntt.co.jp, akpm@linux-foundation.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, tsbogend@alpha.franken.de,
bzolnier@gmail.com, James.Bottomley@HansenPartnership.com,
jeff@garzik.org, davem@davemloft.net, linux-mm@kvack.org
Subject: Re: [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask
Date: Wed, 21 May 2008 18:34:45 +0900 [thread overview]
Message-ID: <20080521183429O.tomof@acm.org> (raw)
In-Reply-To: <20080521084700.GA18644@gondor.apana.org.au>
On Wed, 21 May 2008 16:47:00 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Wed, May 21, 2008 at 03:54:14PM +0900, FUJITA Tomonori wrote:
> >
> > As explained, with the current way we define ARCH_KMALLOC_MINALIGN,
> > crypto doesn't need to use it. But to make it clear, we had better
> > clean up these defines, such as renaming it an appropriate name like
> > ARCH_DMA_ALIGN.
>
> No you don't understand the way crypto is using it. We need to
> know exactly the minimum alignment guaranteed by kmalloc. Too much
> or too little are both buggy.
Why do crypto need to know exactly the minimum alignment guaranteed by
kmalloc? Can you tell me an example how the alignment breaks crypto?
For me, the way crypto use it is idential to what the hostdata in
struct Scsi_Host does.
next prev parent reply other threads:[~2008-05-21 9:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:58 [PATCH 0/4] revert the commit 22a9189f (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 2/4] block: add blk_queue_update_dma_pad FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 3/4] ide: use the dma safe check for REQ_TYPE_ATA_PC FUJITA Tomonori
2008-05-20 4:58 ` [PATCH 4/4] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-05-20 7:33 ` Elias Oltmanns
2008-05-20 7:42 ` Jim Paris
2008-05-20 8:14 ` Elias Oltmanns
2008-05-28 6:43 ` [PATCH 3/4] ide: use the dma safe check for REQ_TYPE_ATA_PC Borislav Petkov
2008-05-20 9:31 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask Andrew Morton
2008-05-20 9:38 ` Herbert Xu
2008-05-20 9:52 ` Andrew Morton
2008-05-20 9:58 ` FUJITA Tomonori
2008-05-20 11:32 ` Herbert Xu
2008-05-20 13:25 ` FUJITA Tomonori
2008-05-20 15:34 ` Herbert Xu
2008-05-20 15:53 ` Plans for libsas and SAS-2? Marushak, Nathan
2008-05-20 16:09 ` [PATCH 1/4] block: use ARCH_KMALLOC_MINALIGN as the default dma pad mask FUJITA Tomonori
2008-05-21 1:26 ` Herbert Xu
2008-05-21 1:36 ` FUJITA Tomonori
2008-05-21 3:16 ` Herbert Xu
2008-05-21 6:54 ` FUJITA Tomonori
2008-05-21 8:47 ` Herbert Xu
2008-05-21 9:34 ` FUJITA Tomonori [this message]
2008-05-21 10:05 ` Herbert Xu
2008-05-21 11:01 ` FUJITA Tomonori
2008-05-21 11:25 ` Herbert Xu
2008-05-21 12:09 ` FUJITA Tomonori
2008-05-21 12:22 ` Herbert Xu
2008-05-21 12:46 ` FUJITA Tomonori
2008-05-21 12:55 ` FUJITA Tomonori
2008-05-21 13:19 ` Herbert Xu
2008-05-21 13:18 ` Herbert Xu
2008-05-22 1:14 ` FUJITA Tomonori
2008-05-22 1:19 ` David Miller
2008-05-22 1:21 ` Herbert Xu
2008-05-22 1:32 ` FUJITA Tomonori
2008-05-22 1:56 ` Herbert Xu
2008-05-20 9:55 ` Paul Mundt
2008-05-21 22:11 ` [PATCH 0/4] revert the commit 22a9189f (cdrom: use kmalloced buffers instead of buffers on stack) Thomas Bogendoerfer
2008-05-22 1:13 ` FUJITA Tomonori
2008-05-22 1:18 ` David Miller
2008-05-22 8:43 ` James Bottomley
2008-05-26 9:17 ` FUJITA Tomonori
2008-05-27 18:58 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521183429O.tomof@acm.org \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).