public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] scsi/advansys.c: fix compile errors
Date: Wed, 21 May 2008 23:07:43 +0300	[thread overview]
Message-ID: <20080521200743.GK15355@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080521195332.GV2638@parisc-linux.org>

On Wed, May 21, 2008 at 01:53:33PM -0600, Matthew Wilcox wrote:
> On Wed, May 21, 2008 at 08:41:52PM +0300, Adrian Bunk wrote:
> > This patch fixes the following compile error on architectures not 
> > providing free_dma():
> 
> Last time this came up, I think the consensus was that those
> architectures should be providing a stub free_dma().

I tried building as many modules as possible on frv, and this was the 
only driver that failed this way.

Another possibility would be to let this driver depend on ISA_DMA_API
(similar to e.g. SCSI_EATA).

Sorry for being lazy, but touching X architectures for fixing the 
compiliation of a driver whose hardware will anyway most likely never
be used on this architecture is IMHO not worth the effort...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2008-05-21 20:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 17:41 [2.6 patch] scsi/advansys.c: fix compile errors Adrian Bunk
2008-05-21 19:53 ` Matthew Wilcox
2008-05-21 20:07   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521200743.GK15355@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox